[v2] Address EDK II CI Failures

[edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Michael D Kinney 5 years, 2 months ago

Install the 2020.08.14 release of QEMU for Windows.

The QEMU release from 2020.11.20 is installed into the incorrect
directory and is causing EDK II CI failures in the run to shell
step.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
---
 OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
index 02ed233fdb60..dd19fff50066 100644
--- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
+++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
@@ -132,7 +132,7 @@ jobs:
         build_flags: $(Build.Flags)
         run_flags: $(Run.Flags)
         extra_install_step:
-        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
+        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
           displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
           condition: and(gt(variables.pkg_count, 0), succeeded())
 
-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67933): https://edk2.groups.io/g/devel/message/67933
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Philippe Mathieu-Daudé 5 years, 2 months ago

Hi Michael,

On 11/25/20 6:07 AM, Michael D Kinney wrote:
> Install the 2020.08.14 release of QEMU for Windows.
> 
> The QEMU release from 2020.11.20 is installed into the incorrect
> directory and is causing EDK II CI failures in the run to shell
> step.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 02ed233fdb60..dd19fff50066 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -132,7 +132,7 @@ jobs:
>          build_flags: $(Build.Flags)
>          run_flags: $(Run.Flags)
>          extra_install_step:
> -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"

Is it fixed with 20201124?

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

>            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
>            condition: and(gt(variables.pkg_count, 0), succeeded())
>  
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67942): https://edk2.groups.io/g/devel/message/67942
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Michael D Kinney 5 years, 2 months ago

Hi Phillippe,

We use choco command to install qemu for Windows, and as of this morning, the 20201124
release has not been published on choco.

	https://chocolatey.org/packages/Qemu

Once it is published on choco, we can test it and if it passes, we can revert this 
change and resume using the latest qemu release.

Mike

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> Sent: Wednesday, November 25, 2020 12:02 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>
> Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
> 
> Hi Michael,
> 
> On 11/25/20 6:07 AM, Michael D Kinney wrote:
> > Install the 2020.08.14 release of QEMU for Windows.
> >
> > The QEMU release from 2020.11.20 is installed into the incorrect
> > directory and is causing EDK II CI failures in the run to shell
> > step.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-
> VS2019.yml
> > index 02ed233fdb60..dd19fff50066 100644
> > --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> > +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> > @@ -132,7 +132,7 @@ jobs:
> >          build_flags: $(Build.Flags)
> >          run_flags: $(Run.Flags)
> >          extra_install_step:
> > -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> > +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program
> Files\qemu"
> 
> Is it fixed with 20201124?
> 
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
> 
> >            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
> >            condition: and(gt(variables.pkg_count, 0), succeeded())
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67988): https://edk2.groups.io/g/devel/message/67988
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] chocolatey.org instability [was: OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU]

Posted by Laszlo Ersek 5 years, 1 month ago

On 11/25/20 17:23, Michael D Kinney wrote:
> Hi Phillippe,
> 
> We use choco command to install qemu for Windows, and as of this morning, the 20201124
> release has not been published on choco.
> 
> 	https://chocolatey.org/packages/Qemu
> 
> Once it is published on choco, we can test it and if it passes, we can revert this 
> change and resume using the latest qemu release.

Hijacking the thread a little --
<https://github.com/tianocore/edk2/pull/1319> keeps failing because
chocolatey.org keeps returning "(520) Origin Error" to the

  choco install qemu --version=2020.08.14

command.

Note that this particular version of the QEMU "choco" package still exists:

  https://chocolatey.org/packages/Qemu/2020.08.14

Can we make ourselves independent of "chocolatey.org" somehow? Every
such external dependency can block all merges. Perhaps we should create
another repository under the tianocore organization on github, and keep
Windows binaries for QEMU there.

I'm quite displeased with the stability issues we've recently seen in
the edk2 CI environment recently, and (AFAICT) none of those have been
our fault. What's *really* annoying is that, when a maintainer wants to
work around such an env issue, to proceed with a particular merge, the
maintainer gets to post a separate patch to edk2-devel first, and wait
for review. That means a possibly *multi-day* delay for merging an
already reviewed patch series. This is terrible.

Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#70038): https://edk2.groups.io/g/devel/message/70038
Mute This Topic: https://groups.io/mt/79520534/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Rebecca Cran 5 years, 2 months ago

Related, should we use a known version of Ubuntu in testing?

Currently, there are several lines with 'ubuntu-latest' - e.g.:

.azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest'
.azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest'

OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image: 
'ubuntu-latest'


I'm not familiar with how Azure works, but could this cause problems 
when they update their Ubuntu latest image to 21.04 etc. and things 
change under us?


-- 
Rebecca Cran


On 11/24/20 10:07 PM, Michael D Kinney wrote:
> Install the 2020.08.14 release of QEMU for Windows.
>
> The QEMU release from 2020.11.20 is installed into the incorrect
> directory and is causing EDK II CI failures in the run to shell
> step.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 02ed233fdb60..dd19fff50066 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -132,7 +132,7 @@ jobs:
>           build_flags: $(Build.Flags)
>           run_flags: $(Run.Flags)
>           extra_install_step:
> -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>             displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
>             condition: and(gt(variables.pkg_count, 0), succeeded())
>   


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67981): https://edk2.groups.io/g/devel/message/67981
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Michael D Kinney 5 years, 2 months ago

Hi Rebecca,

I think the general approach is to verify the latest version of everything
including the CI infrastructure components.

If a failure is detected due to a new component, then we can temporarily 
lock in a previous stable version until the issues with the new component
are resolved.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
> Sent: Wednesday, November 25, 2020 6:58 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ard.biesheuvel@arm.com>
> Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
> 
> Related, should we use a known version of Ubuntu in testing?
> 
> Currently, there are several lines with 'ubuntu-latest' - e.g.:
> 
> .azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest'
> .azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest'
> 
> OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image:
> 'ubuntu-latest'
> 
> 
> I'm not familiar with how Azure works, but could this cause problems
> when they update their Ubuntu latest image to 21.04 etc. and things
> change under us?
> 
> 
> --
> Rebecca Cran
> 
> 
> On 11/24/20 10:07 PM, Michael D Kinney wrote:
> > Install the 2020.08.14 release of QEMU for Windows.
> >
> > The QEMU release from 2020.11.20 is installed into the incorrect
> > directory and is causing EDK II CI failures in the run to shell
> > step.
> >
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> > Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >   OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-
> VS2019.yml
> > index 02ed233fdb60..dd19fff50066 100644
> > --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> > +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> > @@ -132,7 +132,7 @@ jobs:
> >           build_flags: $(Build.Flags)
> >           run_flags: $(Run.Flags)
> >           extra_install_step:
> > -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> > +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program
> Files\qemu"
> >             displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
> >             condition: and(gt(variables.pkg_count, 0), succeeded())
> >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67987): https://edk2.groups.io/g/devel/message/67987
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Rebecca Cran 5 years, 2 months ago

Hi Mike,


That does appear to be the current general approach, but I'd suggest 
changing it.

Because in the last week before release we shouldn't be chasing new 
versions of unrelated software, in my opinion.


Fortunately the switch to Ubuntu 20.04 hasn't happened yet, and is due 
to be rolled out beginning November 30th 
(https://github.com/actions/virtual-environments/issues/1816). The CI 
pipeline has a set of warnings: "##[warning]Ubuntu-latest pipelines will 
use Ubuntu-20.04 soon. For more details, see 
https://github.com/actions/virtual-environments/issues/1816"


-- 
Rebecca Cran


On 11/25/20 9:20 AM, Michael D Kinney wrote:

> Hi Rebecca,
>
> I think the general approach is to verify the latest version of everything
> including the CI infrastructure components.
>
> If a failure is detected due to a new component, then we can temporarily
> lock in a previous stable version until the issues with the new component
> are resolved.
>
> Mike
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran
>> Sent: Wednesday, November 25, 2020 6:58 AM
>> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao
>> <gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
>> <ard.biesheuvel@arm.com>
>> Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
>>
>> Related, should we use a known version of Ubuntu in testing?
>>
>> Currently, there are several lines with 'ubuntu-latest' - e.g.:
>>
>> .azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest'
>> .azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest'
>>
>> OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image:
>> 'ubuntu-latest'
>>
>>
>> I'm not familiar with how Azure works, but could this cause problems
>> when they update their Ubuntu latest image to 21.04 etc. and things
>> change under us?
>>
>>
>> --
>> Rebecca Cran
>>
>>
>> On 11/24/20 10:07 PM, Michael D Kinney wrote:
>>> Install the 2020.08.14 release of QEMU for Windows.
>>>
>>> The QEMU release from 2020.11.20 is installed into the incorrect
>>> directory and is causing EDK II CI failures in the run to shell
>>> step.
>>>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>>> ---
>>>    OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-
>> VS2019.yml
>>> index 02ed233fdb60..dd19fff50066 100644
>>> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
>>> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
>>> @@ -132,7 +132,7 @@ jobs:
>>>            build_flags: $(Build.Flags)
>>>            run_flags: $(Run.Flags)
>>>            extra_install_step:
>>> -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>>> +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program
>> Files\qemu"
>>>              displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
>>>              condition: and(gt(variables.pkg_count, 0), succeeded())
>>>
>>
>>
>>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68001): https://edk2.groups.io/g/devel/message/68001
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Michael D Kinney 5 years, 2 months ago

Rebecca,

I agree there is value in running tests against latest versions of all components and there is value in using stable releases of all dependent components.

There is overhead to do both.  There is also overhead to monitor all dependent components, evaluate new releases, and update versions of dependent components.  I do not know how to automate these types of evaluations.

Thanks,

Mike

From: Rebecca Cran <rebecca@nuviainc.com>
Sent: Wednesday, November 25, 2020 11:36 AM
To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Liming Gao <gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU


Hi Mike,



That does appear to be the current general approach, but I'd suggest changing it.

Because in the last week before release we shouldn't be chasing new versions of unrelated software, in my opinion.



Fortunately the switch to Ubuntu 20.04 hasn't happened yet, and is due to be rolled out beginning November 30th (https://github.com/actions/virtual-environments/issues/1816). The CI pipeline has a set of warnings: "##[warning]Ubuntu-latest pipelines will use Ubuntu-20.04 soon. For more details, see https://github.com/actions/virtual-environments/issues/1816"



--
Rebecca Cran



On 11/25/20 9:20 AM, Michael D Kinney wrote:

Hi Rebecca,



I think the general approach is to verify the latest version of everything

including the CI infrastructure components.



If a failure is detected due to a new component, then we can temporarily

lock in a previous stable version until the issues with the new component

are resolved.



Mike



-----Original Message-----

From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io><mailto:devel@edk2.groups.io> On Behalf Of Rebecca Cran

Sent: Wednesday, November 25, 2020 6:58 AM

To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com><mailto:michael.d.kinney@intel.com>

Cc: Sean Brogan <sean.brogan@microsoft.com><mailto:sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com><mailto:Bret.Barkelew@microsoft.com>; Liming Gao

<gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn>; Justen, Jordan L <jordan.l.justen@intel.com><mailto:jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com><mailto:lersek@redhat.com>; Ard Biesheuvel

<ard.biesheuvel@arm.com><mailto:ard.biesheuvel@arm.com>

Subject: Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU



Related, should we use a known version of Ubuntu in testing?



Currently, there are several lines with 'ubuntu-latest' - e.g.:



.azurepipelines/Ubuntu-GCC5.yml:17:    vm_image: 'ubuntu-latest'

.azurepipelines/Ubuntu-PatchCheck.yml:21:  vmImage: 'ubuntu-latest'



OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml:20: vm_image:

'ubuntu-latest'





I'm not familiar with how Azure works, but could this cause problems

when they update their Ubuntu latest image to 21.04 etc. and things

change under us?





--

Rebecca Cran





On 11/24/20 10:07 PM, Michael D Kinney wrote:

Install the 2020.08.14 release of QEMU for Windows.



The QEMU release from 2020.11.20 is installed into the incorrect

directory and is causing EDK II CI failures in the run to shell

step.



Cc: Sean Brogan <sean.brogan@microsoft.com><mailto:sean.brogan@microsoft.com>

Cc: Bret Barkelew <Bret.Barkelew@microsoft.com><mailto:Bret.Barkelew@microsoft.com>

Cc: Liming Gao <gaoliming@byosoft.com.cn><mailto:gaoliming@byosoft.com.cn>

Cc: Jordan Justen <jordan.l.justen@intel.com><mailto:jordan.l.justen@intel.com>

Cc: Laszlo Ersek <lersek@redhat.com><mailto:lersek@redhat.com>

Cc: Ard Biesheuvel <ard.biesheuvel@arm.com><mailto:ard.biesheuvel@arm.com>

Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com><mailto:michael.d.kinney@intel.com>

---

  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-

VS2019.yml

index 02ed233fdb60..dd19fff50066 100644

--- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml

+++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml

@@ -132,7 +132,7 @@ jobs:

          build_flags: $(Build.Flags)

          run_flags: $(Run.Flags)

          extra_install_step:

-        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"

+        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program

Files\qemu"

            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI

            condition: and(gt(variables.pkg_count, 0), succeeded())
























-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68113): https://edk2.groups.io/g/devel/message/68113
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch v2][edk2-stable202011 3/4] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU

Posted by Laszlo Ersek 5 years, 2 months ago

On 11/25/20 06:07, Michael D Kinney wrote:
> Install the 2020.08.14 release of QEMU for Windows.
> 
> The QEMU release from 2020.11.20 is installed into the incorrect
> directory and is causing EDK II CI failures in the run to shell
> step.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 02ed233fdb60..dd19fff50066 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -132,7 +132,7 @@ jobs:
>          build_flags: $(Build.Flags)
>          run_flags: $(Run.Flags)
>          extra_install_step:
> -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
>            condition: and(gt(variables.pkg_count, 0), succeeded())
>  
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67976): https://edk2.groups.io/g/devel/message/67976
Mute This Topic: https://groups.io/mt/78494332/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-