1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures

Michael D Kinney posted 4 patches 3 years, 4 months ago
Failed in applying to current master (apply log)
.azurepipelines/templates/platform-build-run-steps.yml   | 6 ++++++
.azurepipelines/templates/pr-gate-steps.yml              | 6 ++++++
CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HashTests.c | 7 ++++++-
OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml    | 2 +-
4 files changed, 19 insertions(+), 2 deletions(-)
[edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
Posted by Michael D Kinney 3 years, 4 months ago 
* Always fetch the target branch of the PR (usually origin/master)
  so diffs between PR and the target branch can be performed. There
  is no guarantee that the target branch is fetched when a PR is
  evaluated by a CI agent.

* QEMU release for Windows from Nov 20, 2020 is installed into
  wrong directory. Use previous QEMU for Windows release from
  Aug 14, 2020.

* Update CryptoPkg unit tests to skip MD5 unit tests if
  ENABLE_MD5_DEPRECATED_INTERFACES is defined.

Cc: Sean Brogan sean.brogan@microsoft.com
Cc: Bret Barkelew Bret.Barkelew@microsoft.com
Cc: Liming Gao gaoliming@byosoft.com.cn
Cc: Jordan Justen jordan.l.justen@intel.com
Cc: Laszlo Ersek lersek@redhat.com
Cc: Ard Biesheuvel ard.biesheuvel@arm.com
Cc: Andrew Fish afish@apple.com
Cc: Leif Lindholm leif@nuviainc.com
Cc: Jiewen Yao jiewen.yao@intel.com
Cc: Jian J Wang jian.j.wang@intel.com
Cc: Xiaoyu Lu xiaoyux.lu@intel.com
Cc: Guomin Jiang guomin.jiang@intel.com
Signed-off-by: Michael D Kinney michael.d.kinney@intel.com

Michael D Kinney (2):
  OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
  CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Fix MD5 Hash tests

Sean Brogan (2):
  .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch
  .azurepipelines/templates/platform-build-run-steps.yml: Fetch target
    branch

 .azurepipelines/templates/platform-build-run-steps.yml   | 6 ++++++
 .azurepipelines/templates/pr-gate-steps.yml              | 6 ++++++
 CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HashTests.c | 7 ++++++-
 OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml    | 2 +-
 4 files changed, 19 insertions(+), 2 deletions(-)

-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67931): https://edk2.groups.io/g/devel/message/67931
Mute This Topic: https://groups.io/mt/78494330/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
Posted by Michael D Kinney 3 years, 4 months ago 
Hi Liming,

This V2 series also addresses the CryptoPkg unit test failure.

It passed all EDK II CI checks in this PR:

    https://github.com/tianocore/edk2/pull/1144

There are no firmware code changes in this patch series, so I think
it is low risk for the edk2-stable202011 release and should get us
back to a passing CI status.

Best regards,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney
> Sent: Tuesday, November 24, 2020 9:08 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
> 
> * Always fetch the target branch of the PR (usually origin/master)
>   so diffs between PR and the target branch can be performed. There
>   is no guarantee that the target branch is fetched when a PR is
>   evaluated by a CI agent.
> 
> * QEMU release for Windows from Nov 20, 2020 is installed into
>   wrong directory. Use previous QEMU for Windows release from
>   Aug 14, 2020.
> 
> * Update CryptoPkg unit tests to skip MD5 unit tests if
>   ENABLE_MD5_DEPRECATED_INTERFACES is defined.
> 
> Cc: Sean Brogan sean.brogan@microsoft.com
> Cc: Bret Barkelew Bret.Barkelew@microsoft.com
> Cc: Liming Gao gaoliming@byosoft.com.cn
> Cc: Jordan Justen jordan.l.justen@intel.com
> Cc: Laszlo Ersek lersek@redhat.com
> Cc: Ard Biesheuvel ard.biesheuvel@arm.com
> Cc: Andrew Fish afish@apple.com
> Cc: Leif Lindholm leif@nuviainc.com
> Cc: Jiewen Yao jiewen.yao@intel.com
> Cc: Jian J Wang jian.j.wang@intel.com
> Cc: Xiaoyu Lu xiaoyux.lu@intel.com
> Cc: Guomin Jiang guomin.jiang@intel.com
> Signed-off-by: Michael D Kinney michael.d.kinney@intel.com
> 
> Michael D Kinney (2):
>   OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
>   CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Fix MD5 Hash tests
> 
> Sean Brogan (2):
>   .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch
>   .azurepipelines/templates/platform-build-run-steps.yml: Fetch target
>     branch
> 
>  .azurepipelines/templates/platform-build-run-steps.yml   | 6 ++++++
>  .azurepipelines/templates/pr-gate-steps.yml              | 6 ++++++
>  CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HashTests.c | 7 ++++++-
>  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml    | 2 +-
>  4 files changed, 19 insertions(+), 2 deletions(-)
> 
> --
> 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67936): https://edk2.groups.io/g/devel/message/67936
Mute This Topic: https://groups.io/mt/78494330/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
Posted by gaoliming 3 years, 4 months ago 
Mike:
  I agree to merge them for this stable tag, because they fix CI issues that block current merge process. 

Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67936+4905953+8761045@groups.io
> <bounce+27952+67936+4905953+8761045@groups.io> 代表 Michael D
> Kinney
> 发送时间: 2020年11月25日 13:11
> 收件人: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> 主题: Re: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI
> Failures
> 
> Hi Liming,
> 
> This V2 series also addresses the CryptoPkg unit test failure.
> 
> It passed all EDK II CI checks in this PR:
> 
>     https://github.com/tianocore/edk2/pull/1144
> 
> There are no firmware code changes in this patch series, so I think
> it is low risk for the edk2-stable202011 release and should get us
> back to a passing CI status.
> 
> Best regards,
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> > Sent: Tuesday, November 24, 2020 9:08 PM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI
> Failures
> >
> > * Always fetch the target branch of the PR (usually origin/master)
> >   so diffs between PR and the target branch can be performed. There
> >   is no guarantee that the target branch is fetched when a PR is
> >   evaluated by a CI agent.
> >
> > * QEMU release for Windows from Nov 20, 2020 is installed into
> >   wrong directory. Use previous QEMU for Windows release from
> >   Aug 14, 2020.
> >
> > * Update CryptoPkg unit tests to skip MD5 unit tests if
> >   ENABLE_MD5_DEPRECATED_INTERFACES is defined.
> >
> > Cc: Sean Brogan sean.brogan@microsoft.com
> > Cc: Bret Barkelew Bret.Barkelew@microsoft.com
> > Cc: Liming Gao gaoliming@byosoft.com.cn
> > Cc: Jordan Justen jordan.l.justen@intel.com
> > Cc: Laszlo Ersek lersek@redhat.com
> > Cc: Ard Biesheuvel ard.biesheuvel@arm.com
> > Cc: Andrew Fish afish@apple.com
> > Cc: Leif Lindholm leif@nuviainc.com
> > Cc: Jiewen Yao jiewen.yao@intel.com
> > Cc: Jian J Wang jian.j.wang@intel.com
> > Cc: Xiaoyu Lu xiaoyux.lu@intel.com
> > Cc: Guomin Jiang guomin.jiang@intel.com
> > Signed-off-by: Michael D Kinney michael.d.kinney@intel.com
> >
> > Michael D Kinney (2):
> >   OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
> >   CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Fix MD5 Hash tests
> >
> > Sean Brogan (2):
> >   .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch
> >   .azurepipelines/templates/platform-build-run-steps.yml: Fetch target
> >     branch
> >
> >  .azurepipelines/templates/platform-build-run-steps.yml   | 6 ++++++
> >  .azurepipelines/templates/pr-gate-steps.yml              | 6 ++++++
> >  CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HashTests.c | 7 ++++++-
> >  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml    | 2 +-
> >  4 files changed, 19 insertions(+), 2 deletions(-)
> >
> > --
> > 2.29.2.windows.2
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67938): https://edk2.groups.io/g/devel/message/67938
Mute This Topic: https://groups.io/mt/78494564/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
Posted by Michael D Kinney 3 years, 4 months ago 
Merged as commits
    791fb98ef077d29573a24999c03997c174086049
    655084f8f79d73b08d2604b9b279bfc48a01b904
    1064f5c2c8a0128a98c060e7e3eb5334fae88e51
    6d614fd5921f42ce60fe1adfd80cf9a7998dc645

via
    https://github.com/tianocore/edk2/pull/1145


With these commits the EDK II CI Status is all green

    https://github.com/tianocore/edk2/blob/master/ReadMe.rst

Thanks,

Mike


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming
> Sent: Tuesday, November 24, 2020 9:32 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: 'Laszlo Ersek' <lersek@redhat.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Andrew Fish' <afish@apple.com>
> Subject: 回复: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI Failures
> 
> Mike:
>   I agree to merge them for this stable tag, because they fix CI issues that block current merge process.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+67936+4905953+8761045@groups.io
> > <bounce+27952+67936+4905953+8761045@groups.io> 代表 Michael D
> > Kinney
> > 发送时间: 2020年11月25日 13:11
> > 收件人: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > 主题: Re: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI
> > Failures
> >
> > Hi Liming,
> >
> > This V2 series also addresses the CryptoPkg unit test failure.
> >
> > It passed all EDK II CI checks in this PR:
> >
> >     https://github.com/tianocore/edk2/pull/1144
> >
> > There are no firmware code changes in this patch series, so I think
> > it is low risk for the edk2-stable202011 release and should get us
> > back to a passing CI status.
> >
> > Best regards,
> >
> > Mike
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> > D Kinney
> > > Sent: Tuesday, November 24, 2020 9:08 PM
> > > To: devel@edk2.groups.io
> > > Subject: [edk2-devel] [Patch v2][edk2-stable202011 0/4] Address EDK II CI
> > Failures
> > >
> > > * Always fetch the target branch of the PR (usually origin/master)
> > >   so diffs between PR and the target branch can be performed. There
> > >   is no guarantee that the target branch is fetched when a PR is
> > >   evaluated by a CI agent.
> > >
> > > * QEMU release for Windows from Nov 20, 2020 is installed into
> > >   wrong directory. Use previous QEMU for Windows release from
> > >   Aug 14, 2020.
> > >
> > > * Update CryptoPkg unit tests to skip MD5 unit tests if
> > >   ENABLE_MD5_DEPRECATED_INTERFACES is defined.
> > >
> > > Cc: Sean Brogan sean.brogan@microsoft.com
> > > Cc: Bret Barkelew Bret.Barkelew@microsoft.com
> > > Cc: Liming Gao gaoliming@byosoft.com.cn
> > > Cc: Jordan Justen jordan.l.justen@intel.com
> > > Cc: Laszlo Ersek lersek@redhat.com
> > > Cc: Ard Biesheuvel ard.biesheuvel@arm.com
> > > Cc: Andrew Fish afish@apple.com
> > > Cc: Leif Lindholm leif@nuviainc.com
> > > Cc: Jiewen Yao jiewen.yao@intel.com
> > > Cc: Jian J Wang jian.j.wang@intel.com
> > > Cc: Xiaoyu Lu xiaoyux.lu@intel.com
> > > Cc: Guomin Jiang guomin.jiang@intel.com
> > > Signed-off-by: Michael D Kinney michael.d.kinney@intel.com
> > >
> > > Michael D Kinney (2):
> > >   OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
> > >   CryptoPkg/Test/UnitTest/Library/BaseCryptLib: Fix MD5 Hash tests
> > >
> > > Sean Brogan (2):
> > >   .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch
> > >   .azurepipelines/templates/platform-build-run-steps.yml: Fetch target
> > >     branch
> > >
> > >  .azurepipelines/templates/platform-build-run-steps.yml   | 6 ++++++
> > >  .azurepipelines/templates/pr-gate-steps.yml              | 6 ++++++
> > >  CryptoPkg/Test/UnitTest/Library/BaseCryptLib/HashTests.c | 7 ++++++-
> > >  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml    | 2 +-
> > >  4 files changed, 19 insertions(+), 2 deletions(-)
> > >
> > > --
> > > 2.29.2.windows.2
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#67993): https://edk2.groups.io/g/devel/message/67993
Mute This Topic: https://groups.io/mt/78505667/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.