MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- .../SmbiosView/PrintInfo.c | 2 +- .../SmbiosView/QueryTable.c | 4 ++++ .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- 4 files changed, 18 insertions(+), 13 deletions(-)
Fix some typos in smbiosview and SmBios.h. Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and smbiosview. Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. Pull request: https://github.com/tianocore/edk2/pull/1038 Also built OVMF X64 and verified smbiosview still runs. Rebecca Cran (6): ShellPkg: Fix a couple of typos in smbiosview ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS struct MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS ShellPkg: Fix smbiosview string definition name for "boot from CD" MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- .../SmbiosView/PrintInfo.c | 2 +- .../SmbiosView/QueryTable.c | 4 ++++ .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- 4 files changed, 18 insertions(+), 13 deletions(-) -- 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66504): https://edk2.groups.io/g/devel/message/66504 Mute This Topic: https://groups.io/mt/77711797/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Rebecca: They are the good change. But for patch 4/6, it changes the structure field name. It may bring the impact to the platform code. I don't suggest to do the renaming field only for typo purpose. Other changes are good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Thanks Liming > -----邮件原件----- > 发件人: Rebecca Cran <rebecca@nuviainc.com> > 发送时间: 2020年10月22日 2:41 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao > Gao <zhichao.gao@intel.com> > 主题: [PATCH 0/6] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 ARM64 > SoC ID definition > > Fix some typos in smbiosview and SmBios.h. > > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h > and smbiosview. > > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. > > Pull request: https://github.com/tianocore/edk2/pull/1038 > Also built OVMF X64 and verified smbiosview still runs. > > Rebecca Cran (6): > ShellPkg: Fix a couple of typos in smbiosview > ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview > MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field > MdePkg: Fix typos in SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS > struct > MdePkg: Update SmBios.h to fix PROCESSOR_CHARACTERISTIC_FLAGS > ShellPkg: Fix smbiosview string definition name for "boot from CD" > > MdePkg/Include/IndustryStandard/SmBios.h | 21 > ++++++++++--------- > .../SmbiosView/PrintInfo.c | 2 +- > .../SmbiosView/QueryTable.c | 4 ++++ > .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- > 4 files changed, 18 insertions(+), 13 deletions(-) > > -- > 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66521): https://edk2.groups.io/g/devel/message/66521 Mute This Topic: https://groups.io/mt/77722253/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 10/21/20 7:46 PM, gaoliming wrote: > They are the good change. But for patch 4/6, it changes the structure > field name. It may bring the impact to the platform code. I don't suggest to > do the renaming field only for typo purpose. Other changes are good to me. From looking at the code in edk2-platforms, it seems the common pattern is to use positional arguments instead of designated initializers. Of course there could be platforms outside of TianoCore which use the field names, but it looks like a relatively safe change. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66523): https://edk2.groups.io/g/devel/message/66523 Mute This Topic: https://groups.io/mt/77722776/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Rebecca: Patch 4/6 may be safe. But, we may need more time to collect the feedback. Other patches are clear. I suggest to merge them first. Thanks Liming > -----邮件原件----- > 发件人: bounce+27952+66523+4905953+8761045@groups.io > <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca Cran > 发送时间: 2020年10月22日 10:21 > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' > <zhichao.gao@intel.com> > 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > On 10/21/20 7:46 PM, gaoliming wrote: > > They are the good change. But for patch 4/6, it changes the structure > > field name. It may bring the impact to the platform code. I don't suggest to > > do the renaming field only for typo purpose. Other changes are good to me. > > From looking at the code in edk2-platforms, it seems the common pattern > is to use positional arguments instead of designated initializers. Of > course there could be platforms outside of TianoCore which use the field > names, but it looks like a relatively safe change. > > > -- > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66578): https://edk2.groups.io/g/devel/message/66578 Mute This Topic: https://groups.io/mt/77805787/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Liming, I agree 4/6 is invasive, but I also think industry standard headers should match the specifications they implement. If 5-6/6 do not depend on 4/6, then I agree the others can be merged first. Depending on perceived impact, perhaps 4/6 could be held back until just after next stable tag? Best Regards, Leif On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: > Rebecca: > Patch 4/6 may be safe. But, we may need more time to collect the feedback. > > > Other patches are clear. I suggest to merge them first. > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+66523+4905953+8761045@groups.io > > <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca Cran > > 发送时间: 2020年10月22日 10:21 > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > > 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > > <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' > > <zhichao.gao@intel.com> > > 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > On 10/21/20 7:46 PM, gaoliming wrote: > > > They are the good change. But for patch 4/6, it changes the structure > > > field name. It may bring the impact to the platform code. I don't > suggest to > > > do the renaming field only for typo purpose. Other changes are good to > me. > > > > From looking at the code in edk2-platforms, it seems the common pattern > > is to use positional arguments instead of designated initializers. Of > > course there could be platforms outside of TianoCore which use the field > > names, but it looks like a relatively safe change. > > > > > > -- > > Rebecca Cran > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66605): https://edk2.groups.io/g/devel/message/66605 Mute This Topic: https://groups.io/mt/77821253/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Leif: If no objection, I agree to merge patch 4/6 just after next stable tag 202011. Rebecca: Can you create PR for other 5 patches? I can help merge them. Thanks Liming > -----邮件原件----- > 发件人: bounce+27952+66605+4905953+8761045@groups.io > <bounce+27952+66605+4905953+8761045@groups.io> 代表 Leif Lindholm > 发送时间: 2020年10月27日 1:48 > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > 抄送: rebecca@nuviainc.com; 'Michael D Kinney' > <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Ray > Ni' <ray.ni@intel.com>; 'Zhichao Gao' <zhichao.gao@intel.com> > 主题: Re: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h > fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > Hi Liming, > > I agree 4/6 is invasive, but I also think industry standard headers > should match the specifications they implement. > > If 5-6/6 do not depend on 4/6, then I agree the others can be merged > first. > Depending on perceived impact, perhaps 4/6 could be held back until > just after next stable tag? > > Best Regards, > > Leif > > On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: > > Rebecca: > > Patch 4/6 may be safe. But, we may need more time to collect the > feedback. > > > > > > Other patches are clear. I suggest to merge them first. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: bounce+27952+66523+4905953+8761045@groups.io > > > <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca > Cran > > > 发送时间: 2020年10月22日 10:21 > > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > > > 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > > > <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' > > > <zhichao.gao@intel.com> > > > 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > > > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > > > On 10/21/20 7:46 PM, gaoliming wrote: > > > > They are the good change. But for patch 4/6, it changes the > structure > > > > field name. It may bring the impact to the platform code. I don't > > suggest to > > > > do the renaming field only for typo purpose. Other changes are good to > > me. > > > > > > From looking at the code in edk2-platforms, it seems the common > pattern > > > is to use positional arguments instead of designated initializers. Of > > > course there could be platforms outside of TianoCore which use the field > > > names, but it looks like a relatively safe change. > > > > > > > > > -- > > > Rebecca Cran > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66637): https://edk2.groups.io/g/devel/message/66637 Mute This Topic: https://groups.io/mt/77833696/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks. Yes, I'll send a new patch series for 1-4,6 and create a new PR. -- Rebecca Cran On 10/27/20 12:32 AM, gaoliming wrote: > Leif: > If no objection, I agree to merge patch 4/6 just after next stable tag 202011. > > Rebecca: > Can you create PR for other 5 patches? I can help merge them. > > Thanks > Liming >> -----邮件原件----- >> 发件人: bounce+27952+66605+4905953+8761045@groups.io >> <bounce+27952+66605+4905953+8761045@groups.io> 代表 Leif Lindholm >> 发送时间: 2020年10月27日 1:48 >> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn >> 抄送: rebecca@nuviainc.com; 'Michael D Kinney' >> <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; 'Ray >> Ni' <ray.ni@intel.com>; 'Zhichao Gao' <zhichao.gao@intel.com> >> 主题: Re: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h >> fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition >> >> Hi Liming, >> >> I agree 4/6 is invasive, but I also think industry standard headers >> should match the specifications they implement. >> >> If 5-6/6 do not depend on 4/6, then I agree the others can be merged >> first. >> Depending on perceived impact, perhaps 4/6 could be held back until >> just after next stable tag? >> >> Best Regards, >> >> Leif >> >> On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: >>> Rebecca: >>> Patch 4/6 may be safe. But, we may need more time to collect the >> feedback. >>> >>> Other patches are clear. I suggest to merge them first. >>> >>> Thanks >>> Liming >>>> -----邮件原件----- >>>> 发件人: bounce+27952+66523+4905953+8761045@groups.io >>>> <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca >> Cran >>>> 发送时间: 2020年10月22日 10:21 >>>> 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn >>>> 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' >>>> <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' >>>> <zhichao.gao@intel.com> >>>> 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and >>>> SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition >>>> >>>> On 10/21/20 7:46 PM, gaoliming wrote: >>>>> They are the good change. But for patch 4/6, it changes the >> structure >>>>> field name. It may bring the impact to the platform code. I don't >>> suggest to >>>>> do the renaming field only for typo purpose. Other changes are good to >>> me. >>>> From looking at the code in edk2-platforms, it seems the common >> pattern >>>> is to use positional arguments instead of designated initializers. Of >>>> course there could be platforms outside of TianoCore which use the field >>>> names, but it looks like a relatively safe change. >>>> >>>> >>>> -- >>>> Rebecca Cran >>>> >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >> >> >> > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66660): https://edk2.groups.io/g/devel/message/66660 Mute This Topic: https://groups.io/mt/77833696/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Liming, I used to get the complain about the develop progress. The PR for merge should be created by the Maintainers. Refer to https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-maintainer-process-for-the-edk-ii-project. I suggest to let the submitter give the finial patches' fork branch link. Then you can create the PR base on the fork branch and give the push label. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming > Sent: Tuesday, October 27, 2020 2:33 PM > To: devel@edk2.groups.io; leif@nuviainc.com; gaoliming@byosoft.com.cn > Cc: rebecca@nuviainc.com; Kinney, Michael D <michael.d.kinney@intel.com>; > Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, > Zhichao <zhichao.gao@intel.com> > Subject: 回复: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h > fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > Leif: > If no objection, I agree to merge patch 4/6 just after next stable tag 202011. > > Rebecca: > Can you create PR for other 5 patches? I can help merge them. > > Thanks > Liming > > -----邮件原件----- > > 发件人: bounce+27952+66605+4905953+8761045@groups.io > > <bounce+27952+66605+4905953+8761045@groups.io> 代表 Leif Lindholm > > 发送时间: 2020年10月27日 1:48 > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > > 抄送: rebecca@nuviainc.com; 'Michael D Kinney' > > <michael.d.kinney@intel.com>; 'Zhiguang Liu' <zhiguang.liu@intel.com>; > > 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' <zhichao.gao@intel.com> > > 主题: Re: 回复: [edk2-devel] 回复: [PATCH 0/6] smbiosview and SmBios.h > > fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > Hi Liming, > > > > I agree 4/6 is invasive, but I also think industry standard headers > > should match the specifications they implement. > > > > If 5-6/6 do not depend on 4/6, then I agree the others can be merged > > first. > > Depending on perceived impact, perhaps 4/6 could be held back until > > just after next stable tag? > > > > Best Regards, > > > > Leif > > > > On Mon, Oct 26, 2020 at 09:24:21 +0800, gaoliming wrote: > > > Rebecca: > > > Patch 4/6 may be safe. But, we may need more time to collect the > > feedback. > > > > > > > > > Other patches are clear. I suggest to merge them first. > > > > > > Thanks > > > Liming > > > > -----邮件原件----- > > > > 发件人: bounce+27952+66523+4905953+8761045@groups.io > > > > <bounce+27952+66523+4905953+8761045@groups.io> 代表 Rebecca > > Cran > > > > 发送时间: 2020年10月22日 10:21 > > > > 收件人: devel@edk2.groups.io; gaoliming@byosoft.com.cn > > > > 抄送: 'Michael D Kinney' <michael.d.kinney@intel.com>; 'Zhiguang Liu' > > > > <zhiguang.liu@intel.com>; 'Ray Ni' <ray.ni@intel.com>; 'Zhichao Gao' > > > > <zhichao.gao@intel.com> > > > > 主题: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > > > > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > > > > > > > On 10/21/20 7:46 PM, gaoliming wrote: > > > > > They are the good change. But for patch 4/6, it changes the > > structure > > > > > field name. It may bring the impact to the platform code. I > > > > > don't > > > suggest to > > > > > do the renaming field only for typo purpose. Other changes are > > > > > good to > > > me. > > > > > > > > From looking at the code in edk2-platforms, it seems the common > > pattern > > > > is to use positional arguments instead of designated initializers. > > > > Of course there could be platforms outside of TianoCore which use > > > > the field names, but it looks like a relatively safe change. > > > > > > > > > > > > -- > > > > Rebecca Cran > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66640): https://edk2.groups.io/g/devel/message/66640 Mute This Topic: https://groups.io/mt/77834304/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
For 1 - 3, 5 - 6, Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca > Cran > Sent: Thursday, October 22, 2020 10:21 AM > To: devel@edk2.groups.io; gaoliming@byosoft.com.cn > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang > <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Subject: Re: [EXTERNAL] [edk2-devel] 回复: [PATCH 0/6] smbiosview and > SmBios.h fixes, add SMBIOS 3.4.0 ARM64 SoC ID definition > > On 10/21/20 7:46 PM, gaoliming wrote: > > They are the good change. But for patch 4/6, it changes the > > structure field name. It may bring the impact to the platform code. I > > don't suggest to do the renaming field only for typo purpose. Other > changes are good to me. > > From looking at the code in edk2-platforms, it seems the common pattern is > to use positional arguments instead of designated initializers. Of course > there could be platforms outside of TianoCore which use the field names, > but it looks like a relatively safe change. > > > -- > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66558): https://edk2.groups.io/g/devel/message/66558 Mute This Topic: https://groups.io/mt/77722776/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.