MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- .../SmbiosView/PrintInfo.c | 2 +- .../SmbiosView/QueryTable.c | 4 ++++ .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- 4 files changed, 18 insertions(+), 13 deletions(-)
Fix some typos in smbiosview. Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and smbiosview. Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. Pull request: https://github.com/tianocore/edk2/pull/1052 Rebecca Cran (5): ShellPkg: Fix a couple of typos in smbiosview ShellPkg: Fix smbiosview string definition name for "boot from CD" ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- .../SmbiosView/PrintInfo.c | 2 +- .../SmbiosView/QueryTable.c | 4 ++++ .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- 4 files changed, 18 insertions(+), 13 deletions(-) -- 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66664): https://edk2.groups.io/g/devel/message/66664 Mute This Topic: https://groups.io/mt/77843784/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter. Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Rebecca Cran <rebecca@nuviainc.com> > Sent: Wednesday, October 28, 2020 1:29 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu, > Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao > <zhichao.gao@intel.com> > Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 > ARM64 SoC ID definition > > Fix some typos in smbiosview. > > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and > smbiosview. > > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. > > Pull request: https://github.com/tianocore/edk2/pull/1052 > > Rebecca Cran (5): > ShellPkg: Fix a couple of typos in smbiosview > ShellPkg: Fix smbiosview string definition name for "boot from CD" > ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview > MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field > MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 > > MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- > .../SmbiosView/PrintInfo.c | 2 +- > .../SmbiosView/QueryTable.c | 4 ++++ > .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- > 4 files changed, 18 insertions(+), 13 deletions(-) > > -- > 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66782): https://edk2.groups.io/g/devel/message/66782 Mute This Topic: https://groups.io/mt/77843784/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks - I'll try and remember to do that in future. -- Rebecca Cran On 10/29/20 7:08 PM, Gao, Zhichao wrote: > The patch 1-4 are same with V1. If there is no change with previous patches and the patches are already reviewed. You should add the Reviewed-by for the reviewed patches. That would avoid Maintainers/Reviewers to review the patches again. And it is suggested to add the change info in the cover-letter. > Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > Thanks, > Zhichao > >> -----Original Message----- >> From: Rebecca Cran <rebecca@nuviainc.com> >> Sent: Wednesday, October 28, 2020 1:29 AM >> To: devel@edk2.groups.io >> Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D >> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Liu, >> Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao >> <zhichao.gao@intel.com> >> Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 >> ARM64 SoC ID definition >> >> Fix some typos in smbiosview. >> >> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h and >> smbiosview. >> >> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. >> >> Pull request: https://github.com/tianocore/edk2/pull/1052 >> >> Rebecca Cran (5): >> ShellPkg: Fix a couple of typos in smbiosview >> ShellPkg: Fix smbiosview string definition name for "boot from CD" >> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview >> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field >> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 >> >> MdePkg/Include/IndustryStandard/SmBios.h | 21 ++++++++++--------- >> .../SmbiosView/PrintInfo.c | 2 +- >> .../SmbiosView/QueryTable.c | 4 ++++ >> .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- >> 4 files changed, 18 insertions(+), 13 deletions(-) >> >> -- >> 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66821): https://edk2.groups.io/g/devel/message/66821 Mute This Topic: https://groups.io/mt/77843784/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
PR https://github.com/tianocore/edk2/pull/1058 is created. > -----邮件原件----- > 发件人: Gao, Zhichao <zhichao.gao@intel.com> > 发送时间: 2020年10月30日 9:08 > 收件人: Rebecca Cran <rebecca@nuviainc.com>; devel@edk2.groups.io > 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, > Ray <ray.ni@intel.com> > 主题: RE: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 > ARM64 SoC ID definition > > The patch 1-4 are same with V1. If there is no change with previous patches > and the patches are already reviewed. You should add the Reviewed-by for > the reviewed patches. That would avoid Maintainers/Reviewers to review the > patches again. And it is suggested to add the change info in the cover-letter. > Keep my RB for 1-4. I am OK with patch #5: Reviewed-by: Zhichao Gao > <zhichao.gao@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: Rebecca Cran <rebecca@nuviainc.com> > > Sent: Wednesday, October 28, 2020 1:29 AM > > To: devel@edk2.groups.io > > Cc: Rebecca Cran <rebecca@nuviainc.com>; Kinney, Michael D > > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Liu, > > Zhiguang <zhiguang.liu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, > Zhichao > > <zhichao.gao@intel.com> > > Subject: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 > > ARM64 SoC ID definition > > > > Fix some typos in smbiosview. > > > > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h > and > > smbiosview. > > > > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. > > > > Pull request: https://github.com/tianocore/edk2/pull/1052 > > > > Rebecca Cran (5): > > ShellPkg: Fix a couple of typos in smbiosview > > ShellPkg: Fix smbiosview string definition name for "boot from CD" > > ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview > > MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field > > MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be > UINT16 > > > > MdePkg/Include/IndustryStandard/SmBios.h | 21 > ++++++++++--------- > > .../SmbiosView/PrintInfo.c | 2 +- > > .../SmbiosView/QueryTable.c | 4 ++++ > > .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- > > 4 files changed, 18 insertions(+), 13 deletions(-) > > > > -- > > 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66784): https://edk2.groups.io/g/devel/message/66784 Mute This Topic: https://groups.io/mt/77902452/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Rebecca: Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. Thanks Liming > -----邮件原件----- > 发件人: Rebecca Cran <rebecca@nuviainc.com> > 发送时间: 2020年10月28日 1:29 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; > Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao > Gao <zhichao.gao@intel.com> > 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 > ARM64 SoC ID definition > > Fix some typos in smbiosview. > > Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h > and smbiosview. > > Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. > > Pull request: https://github.com/tianocore/edk2/pull/1052 > > Rebecca Cran (5): > ShellPkg: Fix a couple of typos in smbiosview > ShellPkg: Fix smbiosview string definition name for "boot from CD" > ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview > MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field > MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 > > MdePkg/Include/IndustryStandard/SmBios.h | 21 > ++++++++++--------- > .../SmbiosView/PrintInfo.c | 2 +- > .../SmbiosView/QueryTable.c | 4 ++++ > .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- > 4 files changed, 18 insertions(+), 13 deletions(-) > > -- > 2.26.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66674): https://edk2.groups.io/g/devel/message/66674 Mute This Topic: https://groups.io/mt/77853076/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks! On 10/27/20 6:56 PM, gaoliming wrote: > Rebecca: > Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch set. > > Thanks > Liming >> -----邮件原件----- >> 发件人: Rebecca Cran <rebecca@nuviainc.com> >> 发送时间: 2020年10月28日 1:29 >> 收件人: devel@edk2.groups.io >> 抄送: Rebecca Cran <rebecca@nuviainc.com>; Michael D Kinney >> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; >> Zhiguang Liu <zhiguang.liu@intel.com>; Ray Ni <ray.ni@intel.com>; Zhichao >> Gao <zhichao.gao@intel.com> >> 主题: [PATCH v2 0/5] smbiosview and SmBios.h fixes, add SMBIOS 3.4.0 >> ARM64 SoC ID definition >> >> Fix some typos in smbiosview. >> >> Add the SMC ARM64 SoC ID supported bit from SMBIOS 3.4.0 to SmBios.h >> and smbiosview. >> >> Fix the type of the PROCESSOR_CHARACTERISTIC_FLAGS bitfield. >> >> Pull request: https://github.com/tianocore/edk2/pull/1052 >> >> Rebecca Cran (5): >> ShellPkg: Fix a couple of typos in smbiosview >> ShellPkg: Fix smbiosview string definition name for "boot from CD" >> ShellPkg: Add ARM64 SoC ID to Processor Characteristics in smbiosview >> MdePkg: Update SmBios.h to add SMBIOS 3.4.0 ARM64 SoC ID field >> MdePkg: Fix SmBios.h PROCESSOR_CHARACTERISTIC_FLAGS to be UINT16 >> >> MdePkg/Include/IndustryStandard/SmBios.h | 21 >> ++++++++++--------- >> .../SmbiosView/PrintInfo.c | 2 +- >> .../SmbiosView/QueryTable.c | 4 ++++ >> .../SmbiosView/SmbiosViewStrings.uni | 4 ++-- >> 4 files changed, 18 insertions(+), 13 deletions(-) >> >> -- >> 2.26.2 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66677): https://edk2.groups.io/g/devel/message/66677 Mute This Topic: https://groups.io/mt/77853076/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.