1. Patchew
  2. EDK2
  3. [edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg
  4. View patch

[edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Abner Chang posted 4 patches 5 years, 4 months ago
There is a newer version of this series
[edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Abner Chang 5 years, 4 months ago 
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Nickle Wang <nickle.wang@hpe.com>
Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
       TARGET_SECURITY:
         Build.Pkgs: 'SecurityPkg'
         Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
       TARGET_PLATFORMS:
         # For Platforms only check code. Leave it to Platform CI
         # to build them.
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65923): https://edk2.groups.io/g/devel/message/65923
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Sean 5 years, 4 months ago 
On this change i would recommend that you add RedFishPkg to another in 
the list as i don't think the time it takes to compile and test this 
relatively small package makes it worth spinning up another machine, 
syncing sources, installing tools, etc.

Looking at the current matrix it looks like the SecurityPkg only takes 8 
minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is 
faster than the slowest entry.  We generally try to load balance this so 
that CI completes quickly.

vs2019
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=12811&view=results

gcc
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=12810&view=results


Thanks
Sean



On 10/6/2020 3:48 AM, Abner Chang wrote:
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> ---
>   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..b5b09c2cca 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -45,6 +45,9 @@ jobs:
>         TARGET_SECURITY:
>           Build.Pkgs: 'SecurityPkg'
>           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_REDFISH:
> +        Build.Pkgs: 'RedfishPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>         TARGET_PLATFORMS:
>           # For Platforms only check code. Leave it to Platform CI
>           # to build them.
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65941): https://edk2.groups.io/g/devel/message/65941
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Abner Chang 5 years, 4 months ago 

> -----Original Message-----
> From: Sean Brogan [mailto:spbrogan@outlook.com]
> Sent: Wednesday, October 7, 2020 7:05 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> On this change i would recommend that you add RedFishPkg to another in
> the list as i don't think the time it takes to compile and test this relatively
> small package makes it worth spinning up another machine, syncing sources,
> installing tools, etc.

Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
This is the initial commit of RedFishPkg, more drivers will added to this package later on.
https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md

That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.


> 
> Looking at the current matrix it looks like the SecurityPkg only takes 8
> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
> than the slowest entry.  We generally try to load balance this so that CI
> completes quickly.
> 
> vs2019
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12811-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> 2a23G5fMyOkEFrZgBz5M&e=
> 
> gcc
> INVALID URI REMOVED
> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> 3D12810-26view-
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> XbXB9yt4&e=
> 
> 
> Thanks
> Sean
> 
> 
> 
> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > ---
> >   .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >         TARGET_SECURITY:
> >           Build.Pkgs: 'SecurityPkg'
> >           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >         TARGET_PLATFORMS:
> >           # For Platforms only check code. Leave it to Platform CI
> >           # to build them.
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65943): https://edk2.groups.io/g/devel/message/65943
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Sean 5 years, 4 months ago 
I am just suggesting that for CI you should put redfishpkg into an 
existing matrix item rather than create a new matrix item.  Each one of 
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml 
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might 
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> 
> 
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
> 
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://github.com/tianocore/edk2-staging/blob/UEFI_Redfish/Readme.md
> 
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> 
> 
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65944): https://edk2.groups.io/g/devel/message/65944
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Abner Chang 5 years, 4 months ago 

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Sean
> Sent: Wednesday, October 7, 2020 7:46 AM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> devel@edk2.groups.io
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> I am just suggesting that for CI you should put redfishpkg into an existing
> matrix item rather than create a new matrix item.  Each one of those is a
> build that spins up when CI/PR is invoked.
> 
> 
> instead of this (your patch)
> 
> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> b/.azurepipelines/templates/pr-gate-build-job.yml
> index 2683687a1c..b5b09c2cca 100644
> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> @@ -45,6 +45,9 @@ jobs:
>          TARGET_SECURITY:
>            Build.Pkgs: 'SecurityPkg'
>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> +      TARGET_REDFISH:
> +        Build.Pkgs: 'RedfishPkg'
> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>          TARGET_PLATFORMS:
>            # For Platforms only check code. Leave it to Platform CI
>            # to build them.
> 
> I would just do something like below.  (i hand edited the diff so might not be
> perfect but hopefully you get the idea).
> 
> 
> @@ -45,6 +45,9 @@ jobs:
> -        TARGET_SECURITY:
> +        TARGET_SECURITY_REDFISH:
> -          Build.Pkgs: 'SecurityPkg'
> +          Build.Pkgs: 'SecurityPkg,RedfishPkg'
>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> 
> 
Got you. I will put it with NetworkPkg, more like a family. :)
Thanks

> 
> Thanks
> Sean
> 
> 
> On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> >
> >
> >> -----Original Message-----
> >> From: Sean Brogan [mailto:spbrogan@outlook.com]
> >> Sent: Wednesday, October 7, 2020 7:05 AM
> >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> >> <abner.chang@hpe.com>
> >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> >> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> >> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
> >> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> >>
> >> On this change i would recommend that you add RedFishPkg to another in
> >> the list as i don't think the time it takes to compile and test this relatively
> >> small package makes it worth spinning up another machine, syncing
> sources,
> >> installing tools, etc.
> >
> > Sean, do you mean to add RedFishPkg to another package? Or move
> drivers (currently is none) under RedFishPkg to another package?
> > This is the initial commit of RedFishPkg, more drivers will added to this
> package later on.
> > https://github.com/tianocore/edk2-
> staging/blob/UEFI_Redfish/Readme.md
> >
> > That doesn't make sense to put RedFishPkg to any of another to save CI
> time, but what we can do now is remove RedFishPkg from CI test for the
> time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> >
> >
> >>
> >> Looking at the current matrix it looks like the SecurityPkg only takes 8
> >> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is
> faster
> >> than the slowest entry.  We generally try to load balance this so that CI
> >> completes quickly.
> >>
> >> vs2019
> >> INVALID URI REMOVED
> >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> >> 3D12811-26view-
> >>
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> >> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> >> 2a23G5fMyOkEFrZgBz5M&e=
> >>
> >> gcc
> >> INVALID URI REMOVED
> >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> >> 3D12810-26view-
> >>
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> >>
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> >> XbXB9yt4&e=
> >>
> >>
> >> Thanks
> >> Sean
> >>
> >>
> >>
> >> On 10/6/2020 3:48 AM, Abner Chang wrote:
> >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >>> Cc: Nickle Wang <nickle.wang@hpe.com>
> >>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>> ---
> >>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> >>>    1 file changed, 3 insertions(+)
> >>>
> >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> >>> b/.azurepipelines/templates/pr-gate-build-job.yml
> >>> index 2683687a1c..b5b09c2cca 100644
> >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> >>> @@ -45,6 +45,9 @@ jobs:
> >>>          TARGET_SECURITY:
> >>>            Build.Pkgs: 'SecurityPkg'
> >>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >>> +      TARGET_REDFISH:
> >>> +        Build.Pkgs: 'RedfishPkg'
> >>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >>>          TARGET_PLATFORMS:
> >>>            # For Platforms only check code. Leave it to Platform CI
> >>>            # to build them.
> >>>
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65947): https://edk2.groups.io/g/devel/message/65947
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Abner Chang 5 years, 4 months ago 

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 8:02 AM
> To: devel@edk2.groups.io; spbrogan@outlook.com
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v5
> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
> 
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Sean
> > Sent: Wednesday, October 7, 2020 7:46 AM
> > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>;
> > devel@edk2.groups.io
> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> > Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > .azurepipelines/templates: Add RedfishPkg to target build
> >
> > I am just suggesting that for CI you should put redfishpkg into an
> > existing matrix item rather than create a new matrix item.  Each one
> > of those is a build that spins up when CI/PR is invoked.
> >
> >
> > instead of this (your patch)
> >
> > diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > b/.azurepipelines/templates/pr-gate-build-job.yml
> > index 2683687a1c..b5b09c2cca 100644
> > --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > @@ -45,6 +45,9 @@ jobs:
> >          TARGET_SECURITY:
> >            Build.Pkgs: 'SecurityPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > +      TARGET_REDFISH:
> > +        Build.Pkgs: 'RedfishPkg'
> > +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >          TARGET_PLATFORMS:
> >            # For Platforms only check code. Leave it to Platform CI
> >            # to build them.
> >
> > I would just do something like below.  (i hand edited the diff so
> > might not be perfect but hopefully you get the idea).
> >
> >
> > @@ -45,6 +45,9 @@ jobs:
> > -        TARGET_SECURITY:
> > +        TARGET_SECURITY_REDFISH:
> > -          Build.Pkgs: 'SecurityPkg'
> > +          Build.Pkgs: 'SecurityPkg,RedfishPkg'
> >            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> >
> >
> Got you. I will put it with NetworkPkg, more like a family. :) Thanks
Not quite sure how this yaml file works with CI test.
Does it mean RedfishPkg is involved in NetworkPkg CI test? Even CI only runs on TARGET_NETWORK?
But eventually RedfishPkg would be moved out from TARGET_NETWORK once it grows up to big enough, right?

> 
> >
> > Thanks
> > Sean
> >
> >
> > On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Sean Brogan [mailto:spbrogan@outlook.com]
> > >> Sent: Wednesday, October 7, 2020 7:05 AM
> > >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > >> <abner.chang@hpe.com>
> > >> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
> > >> <Bret.Barkelew@microsoft.com>; Michael D Kinney
> > >> <michael.d.kinney@intel.com>; Liming Gao
> > >> <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)
> > >> <nickle.wang@hpe.com>
> > >> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 3/4]
> > >> .azurepipelines/templates: Add RedfishPkg to target build
> > >>
> > >> On this change i would recommend that you add RedFishPkg to another
> > >> in the list as i don't think the time it takes to compile and test
> > >> this relatively small package makes it worth spinning up another
> > >> machine, syncing
> > sources,
> > >> installing tools, etc.
> > >
> > > Sean, do you mean to add RedFishPkg to another package? Or move
> > drivers (currently is none) under RedFishPkg to another package?
> > > This is the initial commit of RedFishPkg, more drivers will added to
> > > this
> > package later on.
> > > https://github.com/tianocore/edk2-
> > staging/blob/UEFI_Redfish/Readme.md
> > >
> > > That doesn't make sense to put RedFishPkg to any of another to save
> > > CI
> > time, but what we can do now is remove RedFishPkg from CI test for the
> > time being. Says don’t add RedfishPkg to GetPackageSupported for now.
> > >
> > >
> > >>
> > >> Looking at the current matrix it looks like the SecurityPkg only
> > >> takes 8 minutes and CRYPTO only takes ~9 minutes.  I also see FMP
> > >> and FAT is
> > faster
> > >> than the slowest entry.  We generally try to load balance this so
> > >> that CI completes quickly.
> > >>
> > >> vs2019
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12811-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
> > >> 2a23G5fMyOkEFrZgBz5M&e=
> > >>
> > >> gcc
> > >> INVALID URI REMOVED
> > >> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
> > >> 3D12810-26view-
> > >>
> >
> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
> > >> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
> > >>
> >
> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
> > >> XbXB9yt4&e=
> > >>
> > >>
> > >> Thanks
> > >> Sean
> > >>
> > >>
> > >>
> > >> On 10/6/2020 3:48 AM, Abner Chang wrote:
> > >>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> > >>> Cc: Sean Brogan <sean.brogan@microsoft.com>
> > >>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > >>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > >>> Cc: Nickle Wang <nickle.wang@hpe.com>
> > >>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > >>> ---
> > >>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
> > >>>    1 file changed, 3 insertions(+)
> > >>>
> > >>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> index 2683687a1c..b5b09c2cca 100644
> > >>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
> > >>> @@ -45,6 +45,9 @@ jobs:
> > >>>          TARGET_SECURITY:
> > >>>            Build.Pkgs: 'SecurityPkg'
> > >>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>> +      TARGET_REDFISH:
> > >>> +        Build.Pkgs: 'RedfishPkg'
> > >>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
> > >>>          TARGET_PLATFORMS:
> > >>>            # For Platforms only check code. Leave it to Platform CI
> > >>>            # to build them.
> > >>>
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65948): https://edk2.groups.io/g/devel/message/65948
Mute This Topic: https://groups.io/mt/77338598/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Bret Barkelew via groups.io 5 years, 4 months ago 
Ah, yes. Good catch. Agree with Sean.

- Bret

From: Sean Brogan<mailto:spbrogan@outlook.com>
Sent: Tuesday, October 6, 2020 4:45 PM
To: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)<mailto:nickle.wang@hpe.com>
Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

I am just suggesting that for CI you should put redfishpkg into an
existing matrix item rather than create a new matrix item.  Each one of
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com>; Michael D Kinney
>> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
>
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0
>
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don’t add RedfishPkg to GetPackageSupported for now.
>
>
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Nickle Wang <nickle.wang@hpe.com>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65946): https://edk2.groups.io/g/devel/message/65946
Mute This Topic: https://groups.io/mt/77353074/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build
Posted by Abner Chang 5 years, 4 months ago 
Ok, v6 sent. Should be the perfect one, I hope so.

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bret Barkelew via groups.io
Sent: Wednesday, October 7, 2020 8:01 AM
To: Sean Brogan <spbrogan@outlook.com>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>
Subject: Re: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

Ah, yes. Good catch. Agree with Sean.

- Bret

From: Sean Brogan<mailto:spbrogan@outlook.com>
Sent: Tuesday, October 6, 2020 4:45 PM
To: Chang, Abner (HPS SW/FW Technologist)<mailto:abner.chang@hpe.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Sean Brogan<mailto:sean.brogan@microsoft.com>; Bret Barkelew<mailto:Bret.Barkelew@microsoft.com>; Kinney, Michael D<mailto:michael.d.kinney@intel.com>; Liming Gao<mailto:gaoliming@byosoft.com.cn>; Wang, Nickle (HPS SW)<mailto:nickle.wang@hpe.com>
Subject: [EXTERNAL] Re: [edk2-devel] [RedfishPkg PATCH v5 3/4] .azurepipelines/templates: Add RedfishPkg to target build

I am just suggesting that for CI you should put redfishpkg into an
existing matrix item rather than create a new matrix item.  Each one of
those is a build that spins up when CI/PR is invoked.


instead of this (your patch)

diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
b/.azurepipelines/templates/pr-gate-build-job.yml
index 2683687a1c..b5b09c2cca 100644
--- a/.azurepipelines/templates/pr-gate-build-job.yml
+++ b/.azurepipelines/templates/pr-gate-build-job.yml
@@ -45,6 +45,9 @@ jobs:
         TARGET_SECURITY:
           Build.Pkgs: 'SecurityPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
+      TARGET_REDFISH:
+        Build.Pkgs: 'RedfishPkg'
+        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
         TARGET_PLATFORMS:
           # For Platforms only check code. Leave it to Platform CI
           # to build them.

I would just do something like below.  (i hand edited the diff so might
not be perfect but hopefully you get the idea).


@@ -45,6 +45,9 @@ jobs:
-        TARGET_SECURITY:
+        TARGET_SECURITY_REDFISH:
-          Build.Pkgs: 'SecurityPkg'
+          Build.Pkgs: 'SecurityPkg,RedfishPkg'
           Build.Targets: 'DEBUG,RELEASE,NO-TARGET'



Thanks
Sean


On 10/6/2020 4:39 PM, Chang, Abner (HPS SW/FW Technologist) wrote:
>
>
>> -----Original Message-----
>> From: Sean Brogan [mailto:spbrogan@outlook.com]
>> Sent: Wednesday, October 7, 2020 7:05 AM
>> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist)
>> <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Bret Barkelew
>> <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>; Michael D Kinney
>> <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>;
>> Wang, Nickle (HPS SW) <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
>> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5
>> 3/4] .azurepipelines/templates: Add RedfishPkg to target build
>>
>> On this change i would recommend that you add RedFishPkg to another in
>> the list as i don't think the time it takes to compile and test this relatively
>> small package makes it worth spinning up another machine, syncing sources,
>> installing tools, etc.
>
> Sean, do you mean to add RedFishPkg to another package? Or move drivers (currently is none) under RedFishPkg to another package?
> This is the initial commit of RedFishPkg, more drivers will added to this package later on.
> https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FUEFI_Redfish%2FReadme.md&amp;data=02%7C01%7CBret.Barkelew%40microsoft.com%7C064c677f2cad4197e11608d86a51f2ab%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637376247502227698&amp;sdata=L4wOv4IxFdOEoUV2IjBG3kUHlBW1Z%2FsQvTQGe67W980%3D&amp;reserved=0>
>
> That doesn't make sense to put RedFishPkg to any of another to save CI time, but what we can do now is remove RedFishPkg from CI test for the time being. Says don't add RedfishPkg to GetPackageSupported for now.
>
>
>>
>> Looking at the current matrix it looks like the SecurityPkg only takes 8
>> minutes and CRYPTO only takes ~9 minutes.  I also see FMP and FAT is faster
>> than the slowest entry.  We generally try to load balance this so that CI
>> completes quickly.
>>
>> vs2019
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12811-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=3XIQ_TF_f0Ck_fkywiGXKd-
>> 2a23G5fMyOkEFrZgBz5M&e=
>>
>> gcc
>> INVALID URI REMOVED
>> 3A__dev.azure.com_tianocore_edk2-2Dci_-5Fbuild_results-3FbuildId-
>> 3D12810-26view-
>> 3Dresults&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ul
>> kskz6qU3NYRO03nHp9P7Z5q59A3E&m=QmpPMx5HlLf978P4ICsd-
>> D4sw4IjDO8v_OJ74lDlU0M&s=4VVVdhJiawmkngs8kXl6ENUdoVGHEueOUZ6
>> XbXB9yt4&e=
>>
>>
>> Thanks
>> Sean
>>
>>
>>
>> On 10/6/2020 3:48 AM, Abner Chang wrote:
>>> Signed-off-by: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
>>> Cc: Sean Brogan <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>
>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
>>> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
>>> Cc: Liming Gao <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>
>>> Cc: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
>>> Reviewed-by: Bret Barkelew <Bret.Barkelew@microsoft.com<mailto:Bret.Barkelew@microsoft.com>>
>>> ---
>>>    .azurepipelines/templates/pr-gate-build-job.yml | 3 +++
>>>    1 file changed, 3 insertions(+)
>>>
>>> diff --git a/.azurepipelines/templates/pr-gate-build-job.yml
>>> b/.azurepipelines/templates/pr-gate-build-job.yml
>>> index 2683687a1c..b5b09c2cca 100644
>>> --- a/.azurepipelines/templates/pr-gate-build-job.yml
>>> +++ b/.azurepipelines/templates/pr-gate-build-job.yml
>>> @@ -45,6 +45,9 @@ jobs:
>>>          TARGET_SECURITY:
>>>            Build.Pkgs: 'SecurityPkg'
>>>            Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>> +      TARGET_REDFISH:
>>> +        Build.Pkgs: 'RedfishPkg'
>>> +        Build.Targets: 'DEBUG,RELEASE,NO-TARGET'
>>>          TARGET_PLATFORMS:
>>>            # For Platforms only check code. Leave it to Platform CI
>>>            # to build them.
>>>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65959): https://edk2.groups.io/g/devel/message/65959
Mute This Topic: https://groups.io/mt/77355658/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.