[edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Abner Chang posted 4 patches 2 weeks ago
Failed in applying to current master (apply log)
.../templates/pr-gate-build-job.yml           |  2 +-
.pytool/CISettings.py                         |  3 +-
Maintainers.txt                               |  5 ++
RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
RedfishPkg/RedfishPkg.dec                     | 18 +++++
RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
6 files changed, 133 insertions(+), 2 deletions(-)
create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
create mode 100644 RedfishPkg/RedfishPkg.dec
create mode 100644 RedfishPkg/RedfishPkg.dsc

[edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Posted by Abner Chang 2 weeks ago
Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
             save time on CI test.
             In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
             this change is not required in v4 pacth set.

Note for v5: Add reviewers's tags.

Note for v4: NOOPT is removed from RedfishPkg.dsc and
             pr-gate-build-job.yml because we don't have host-based
             unit test on Redfish yet. We keep NO-TARGET for the
             non build CI test on RedfishPkg.

Initial version of RedfishPkg and the CI test
on RedfishPkg.

CI Test result:
https://github.com/tianocore/edk2/pull/986

There is no components in RedfishPkg in this commit,
the further edk2 Redfish components will be committed
base on this version.

Abner Chang (4):
  RedfishPkg: Initial commit of RedfishPkg.
  .pytool: Add CI on RedfishPkg
  .azurepipelines/templates: Add RedfishPkg to target build
  edk2: Add maintainers to RedfishPkg

 .../templates/pr-gate-build-job.yml           |  2 +-
 .pytool/CISettings.py                         |  3 +-
 Maintainers.txt                               |  5 ++
 RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
 RedfishPkg/RedfishPkg.dec                     | 18 +++++
 RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
 6 files changed, 133 insertions(+), 2 deletions(-)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65954): https://edk2.groups.io/g/devel/message/65954
Mute This Topic: https://groups.io/mt/77355621/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Posted by Laszlo Ersek 2 weeks ago
Abner,

On 10/07/20 04:15, Abner Chang wrote:
> Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
>              save time on CI test.
>              In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
>              this change is not required in v4 pacth set.

you really need to collect the CC's from *all* the commit messages
across the entire series, and manually add those to your cover letter.

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23

"This will ensure that even if a maintainer is involved in reviewing one
or two of your patches across the series, he or she will get a copy of
your cover letter, which outlines the full feature or bugfix"

No need to repost this, but please remember it in the future.

Thanks
Laszlo

> 
> Note for v5: Add reviewers's tags.
> 
> Note for v4: NOOPT is removed from RedfishPkg.dsc and
>              pr-gate-build-job.yml because we don't have host-based
>              unit test on Redfish yet. We keep NO-TARGET for the
>              non build CI test on RedfishPkg.
> 
> Initial version of RedfishPkg and the CI test
> on RedfishPkg.
> 
> CI Test result:
> https://github.com/tianocore/edk2/pull/986
> 
> There is no components in RedfishPkg in this commit,
> the further edk2 Redfish components will be committed
> base on this version.
> 
> Abner Chang (4):
>   RedfishPkg: Initial commit of RedfishPkg.
>   .pytool: Add CI on RedfishPkg
>   .azurepipelines/templates: Add RedfishPkg to target build
>   edk2: Add maintainers to RedfishPkg
> 
>  .../templates/pr-gate-build-job.yml           |  2 +-
>  .pytool/CISettings.py                         |  3 +-
>  Maintainers.txt                               |  5 ++
>  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec                     | 18 +++++
>  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
>  6 files changed, 133 insertions(+), 2 deletions(-)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65975): https://edk2.groups.io/g/devel/message/65975
Mute This Topic: https://groups.io/mt/77355621/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Posted by Abner Chang 2 weeks ago
Thanks for that information, I never read through that guidance... and I should.

One question Leif,
If the patches get the new tag from reviewers, shall I have to send the new version of patches to the mailing list which includes all of reviewer's tag?

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Wednesday, October 7, 2020 6:49 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> 
> Abner,
> 
> On 10/07/20 04:15, Abner Chang wrote:
> > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> >              save time on CI test.
> >              In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> >              this change is not required in v4 pacth set.
> 
> you really need to collect the CC's from *all* the commit messages across the
> entire series, and manually add those to your cover letter.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-
> unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
> 
> "This will ensure that even if a maintainer is involved in reviewing one or two
> of your patches across the series, he or she will get a copy of your cover
> letter, which outlines the full feature or bugfix"
> 
> No need to repost this, but please remember it in the future.
> 
> Thanks
> Laszlo
> 
> >
> > Note for v5: Add reviewers's tags.
> >
> > Note for v4: NOOPT is removed from RedfishPkg.dsc and
> >              pr-gate-build-job.yml because we don't have host-based
> >              unit test on Redfish yet. We keep NO-TARGET for the
> >              non build CI test on RedfishPkg.
> >
> > Initial version of RedfishPkg and the CI test on RedfishPkg.
> >
> > CI Test result:
> > https://github.com/tianocore/edk2/pull/986
> >
> > There is no components in RedfishPkg in this commit, the further edk2
> > Redfish components will be committed base on this version.
> >
> > Abner Chang (4):
> >   RedfishPkg: Initial commit of RedfishPkg.
> >   .pytool: Add CI on RedfishPkg
> >   .azurepipelines/templates: Add RedfishPkg to target build
> >   edk2: Add maintainers to RedfishPkg
> >
> >  .../templates/pr-gate-build-job.yml           |  2 +-
> >  .pytool/CISettings.py                         |  3 +-
> >  Maintainers.txt                               |  5 ++
> >  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
> >  RedfishPkg/RedfishPkg.dec                     | 18 +++++
> >  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
> >  6 files changed, 133 insertions(+), 2 deletions(-)  create mode
> > 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > RedfishPkg/RedfishPkg.dec  create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65977): https://edk2.groups.io/g/devel/message/65977
Mute This Topic: https://groups.io/mt/77355621/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Posted by Laszlo Ersek 2 weeks ago
On 10/07/20 13:23, Chang, Abner (HPS SW/FW Technologist) wrote:
> Thanks for that information, I never read through that guidance... and I should.
> 
> One question Leif,
> If the patches get the new tag from reviewers, shall I have to send the new version of patches to the mailing list which includes all of reviewer's tag?

No. If the feedback you get purely consists of feedback tags, and
through them, the patch series becomes eligible for merging, then it is
the maintainer's job to apply your series on a local topic branch of
theirs (git-am), pick up the feedback tags (git-rebase + reword on each
patch), and finally push the topic branch to github, open a PR, set the
"push" label, and let the mergify bot merge the series once the CI run
passes.

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers#maint-04

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65985): https://edk2.groups.io/g/devel/message/65985
Mute This Topic: https://groups.io/mt/77355621/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg

Posted by Abner Chang 2 weeks ago
Sorry, it's typo. Below question is to Laszlo not Leif,

>>>If the patches get the new tag from reviewers, shall I have to send the new
>>> version of patches to the mailing list which includes all of reviewer's tag?

I mean there is no more feedbacks on patches itself but just get new feedback tags from reviewers. Can we just add those tags to patches when merge it?
Or as you mentioned in the previous email "...it helps maintainers if they don't need to go back to earlier versions to hunt down feedback tags."

Thanks

> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Wednesday, October 7, 2020 7:24 PM
> To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> 
> Thanks for that information, I never read through that guidance... and I
> should.
> 
> One question Leif,
> If the patches get the new tag from reviewers, shall I have to send the new
> version of patches to the mailing list which includes all of reviewer's tag?
> 
> > -----Original Message-----
> > From: Laszlo Ersek [mailto:lersek@redhat.com]
> > Sent: Wednesday, October 7, 2020 6:49 PM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> > <abner.chang@hpe.com>
> > Subject: Re: [edk2-devel] [RedfishPkg PATCH v6 0/4] Inital RedfishPkg
> >
> > Abner,
> >
> > On 10/07/20 04:15, Abner Chang wrote:
> > > Note for v6: In patch 3/4, move RedfishPkg to TARGET_NETWORK to
> > >              save time on CI test.
> > >              In patch 1/4, add NOOPT back to RedfishPkg.dsc becasue
> > >              this change is not required in v4 pacth set.
> >
> > you really need to collect the CC's from *all* the commit messages
> > across the entire series, and manually add those to your cover letter.
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-
> > unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-23
> >
> > "This will ensure that even if a maintainer is involved in reviewing
> > one or two of your patches across the series, he or she will get a
> > copy of your cover letter, which outlines the full feature or bugfix"
> >
> > No need to repost this, but please remember it in the future.
> >
> > Thanks
> > Laszlo
> >
> > >
> > > Note for v5: Add reviewers's tags.
> > >
> > > Note for v4: NOOPT is removed from RedfishPkg.dsc and
> > >              pr-gate-build-job.yml because we don't have host-based
> > >              unit test on Redfish yet. We keep NO-TARGET for the
> > >              non build CI test on RedfishPkg.
> > >
> > > Initial version of RedfishPkg and the CI test on RedfishPkg.
> > >
> > > CI Test result:
> > > https://github.com/tianocore/edk2/pull/986
> > >
> > > There is no components in RedfishPkg in this commit, the further
> > > edk2 Redfish components will be committed base on this version.
> > >
> > > Abner Chang (4):
> > >   RedfishPkg: Initial commit of RedfishPkg.
> > >   .pytool: Add CI on RedfishPkg
> > >   .azurepipelines/templates: Add RedfishPkg to target build
> > >   edk2: Add maintainers to RedfishPkg
> > >
> > >  .../templates/pr-gate-build-job.yml           |  2 +-
> > >  .pytool/CISettings.py                         |  3 +-
> > >  Maintainers.txt                               |  5 ++
> > >  RedfishPkg/RedfishPkg.ci.yaml                 | 67 +++++++++++++++++++
> > >  RedfishPkg/RedfishPkg.dec                     | 18 +++++
> > >  RedfishPkg/RedfishPkg.dsc                     | 40 +++++++++++
> > >  6 files changed, 133 insertions(+), 2 deletions(-)  create mode
> > > 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > > RedfishPkg/RedfishPkg.dec  create mode 100644
> > > RedfishPkg/RedfishPkg.dsc
> > >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65984): https://edk2.groups.io/g/devel/message/65984
Mute This Topic: https://groups.io/mt/77355621/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-