1. Patchew
  2. EDK2
  3. [edk2-devel] [RedfishPkg PATCH v5 0/4] Inital RedfishPkg
  4. View patch

[edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Abner Chang posted 4 patches 5 years, 4 months ago
There is a newer version of this series
[edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Abner Chang 5 years, 4 months ago 
Initial version of RedfishPkg.

Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
Signed-off-by: Wang Fan <fan.wang@intel.com>
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
---
 RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
 RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
 RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
 3 files changed, 125 insertions(+)
 create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
 create mode 100644 RedfishPkg/RedfishPkg.dec
 create mode 100644 RedfishPkg/RedfishPkg.dsc

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
new file mode 100644
index 0000000000..75c3b6a8ad
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -0,0 +1,67 @@
+## @file
+# CI configuration for NetworkPkg
+#
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+{
+    "LicenseCheck": {
+        "IgnoreFiles": []
+    },
+    "EccCheck": {
+        ## Exception sample looks like below:
+        ## "ExceptionList": [
+        ##     "<ErrorID>", "<KeyWord>"
+        ## ]
+        "ExceptionList": [
+        ],
+        ## Both file path and directory path are accepted.
+        "IgnoreFiles": [
+        ]
+    },
+    "CompilerPlugin": {
+        "DscPath": "RedfishPkg.dsc"
+    },
+    "CharEncodingCheck": {
+        "IgnoreFiles": []
+    },
+    "DependencyCheck": {
+        "AcceptableDependencies": [
+            "MdePkg/MdePkg.dec",
+            "MdeModulePkg/MdeModulePkg.dec",
+            "NetworkPkg/NetworkPkg.dec"
+        ],
+        # For host based unit tests
+        "AcceptableDependencies-HOST_APPLICATION":[],
+        # For UEFI shell based apps
+        "AcceptableDependencies-UEFI_APPLICATION":[
+            "ShellPkg/ShellPkg.dec"
+        ],
+        "IgnoreInf": []
+    },
+    "DscCompleteCheck": {
+        "DscPath": "RedfishPkg.dsc",
+        "IgnoreInf": []
+    },
+    "GuidCheck": {
+        "IgnoreGuidName": [],
+        "IgnoreGuidValue": [],
+        "IgnoreFoldersAndFiles": []
+    },
+    "LibraryClassCheck": {
+        "IgnoreHeaderFile": []
+    },
+
+    ## options defined ci/Plugin/SpellCheck
+    "SpellCheck": {
+        "AuditOnly": True,           # Fails test but run in AuditOnly mode to collect log
+        "IgnoreFiles": [],           # use gitignore syntax to ignore errors in matching files
+        "ExtendWords": [],           # words to extend to the dictionary for this package
+        "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
+        "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
+    },
+
+    "Defines": {
+        "BLD_*_CONTINUOUS_INTEGRATION": "TRUE"
+    }
+}
diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
new file mode 100644
index 0000000000..e95ec5fe10
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dec
@@ -0,0 +1,18 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+##
+
+[Defines]
+  DEC_SPECIFICATION = 0x0001001b
+  PACKAGE_NAME      = RedfishPkg
+  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
+  PACKAGE_VERSION   = 1.0
+
+[Guids]
+  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
+
diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
new file mode 100644
index 0000000000..d5c65f68c3
--- /dev/null
+++ b/RedfishPkg/RedfishPkg.dsc
@@ -0,0 +1,40 @@
+## @file
+# Redfish Package
+#
+# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
+#
+#    SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  PLATFORM_NAME                  = RedfishPkg
+  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
+  PLATFORM_VERSION               = 1.0
+  DSC_SPECIFICATION              = 0x0001001c
+  OUTPUT_DIRECTORY               = Build/RedfishPkg
+  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
+  BUILD_TARGETS                  = DEBUG|RELEASE
+  SKUID_IDENTIFIER               = DEFAULT
+
+[LibraryClasses]
+  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
+  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
+  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
+  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
+  PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
+  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
+  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
+  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
+  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65921): https://edk2.groups.io/g/devel/message/65921
Mute This Topic: https://groups.io/mt/77338595/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Leif Lindholm 5 years, 4 months ago 
One comment:

On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote:
> Initial version of RedfishPkg.
> 
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> Signed-off-by: Wang Fan <fan.wang@intel.com>
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
>  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
>  3 files changed, 125 insertions(+)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc
> 
> diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec
> new file mode 100644
> index 0000000000..e95ec5fe10
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dec
> @@ -0,0 +1,18 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +##
> +
> +[Defines]
> +  DEC_SPECIFICATION = 0x0001001b
> +  PACKAGE_NAME      = RedfishPkg
> +  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
> +  PACKAGE_VERSION   = 1.0
> +
> +[Guids]
> +  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88, 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> +
> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc
> new file mode 100644
> index 0000000000..d5c65f68c3
> --- /dev/null
> +++ b/RedfishPkg/RedfishPkg.dsc
> @@ -0,0 +1,40 @@
> +## @file
> +# Redfish Package
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +# (C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> +#
> +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = RedfishPkg
> +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> +  PLATFORM_VERSION               = 1.0
> +  DSC_SPECIFICATION              = 0x0001001c
> +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> +  BUILD_TARGETS                  = DEBUG|RELEASE

v3 included NOOPT here. That was the version Laszlo gave his R-b for.

v4 cover letter does mention NOOPT being removed, but I can see no
conversation in which this is discussed. What have I missed?

/
    Leif

> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +[LibraryClasses]
> +  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> +  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
> +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> +  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
> +  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> +  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> +  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> +  SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> +  DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf
> +  PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPort80.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +  PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf
> +  DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf
> +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
> -- 
> 2.17.1
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65930): https://edk2.groups.io/g/devel/message/65930
Mute This Topic: https://groups.io/mt/77338595/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Abner Chang 5 years, 4 months ago 

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, October 6, 2020 10:37 PM
> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>;
> Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Michael D Kinney <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial
> commit of RedfishPkg.
> 
> One comment:
> 
> On Tue, Oct 06, 2020 at 18:48:01 +0800, Abner Chang wrote:
> > Initial version of RedfishPkg.
> >
> > Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> > Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
> > Signed-off-by: Wang Fan <fan.wang@intel.com>
> > Signed-off-by: Chang Abner <abner.chang@hpe.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Andrew Fish <afish@apple.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> > ---
> >  RedfishPkg/RedfishPkg.ci.yaml | 67
> +++++++++++++++++++++++++++++++++++
> >  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
> >  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
> >  3 files changed, 125 insertions(+)
> >  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml  create mode 100644
> > RedfishPkg/RedfishPkg.dec  create mode 100644
> > RedfishPkg/RedfishPkg.dsc
> >
> > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec new
> > file mode 100644 index 0000000000..e95ec5fe10
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dec
> > @@ -0,0 +1,18 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR> # #
> > +SPDX-License-Identifier: BSD-2-Clause-Patent ##
> > +
> > +[Defines]
> > +  DEC_SPECIFICATION = 0x0001001b
> > +  PACKAGE_NAME      = RedfishPkg
> > +  PACKAGE_GUID      = c432b76e-5232-11e7-9010-005056c00008
> > +  PACKAGE_VERSION   = 1.0
> > +
> > +[Guids]
> > +  gEfiRedfishPkgTokenSpaceGuid      = { 0x4fdbccb7, 0xe829, 0x4b4c, { 0x88,
> 0x87, 0xb2, 0x3f, 0xd7, 0x25, 0x4b, 0x85 }}
> > +
> > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > file mode 100644 index 0000000000..d5c65f68c3
> > --- /dev/null
> > +++ b/RedfishPkg/RedfishPkg.dsc
> > @@ -0,0 +1,40 @@
> > +## @file
> > +# Redfish Package
> > +#
> > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > +#
> > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > +#
> > +##
> > +
> > +[Defines]
> > +  PLATFORM_NAME                  = RedfishPkg
> > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > +  PLATFORM_VERSION               = 1.0
> > +  DSC_SPECIFICATION              = 0x0001001c
> > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > +  BUILD_TARGETS                  = DEBUG|RELEASE
> 
> v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> 
> v4 cover letter does mention NOOPT being removed, but I can see no
> conversation in which this is discussed. What have I missed?
No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.
We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Abner
> 
> /
>     Leif
> 
> > +  SKUID_IDENTIFIER               = DEFAULT
> > +
> > +[LibraryClasses]
> > +
> > +UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEn
> > +tryPoint.inf
> > +
> >
> +UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/Uefi
> > +BootServicesTableLib.inf
> > +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> > +
> >
> +UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLi
> > +b/UefiRuntimeServicesTableLib.inf
> > +  UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> > +
> >
> +MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMem
> ory
> > +AllocationLib.inf
> > +
> > +DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> > +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> > +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> > +
> >
> +SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchron
> > +izationLib.inf
> > +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> > +  DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLibStdErr.inf
> > +
> >
> +DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Ba
> > +seDebugPrintErrorLevelLib.inf
> > +
> >
> +PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePostCodeLibPo
> rt8
> > +0.inf
> > +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> > +
> >
> +PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Bas
> e
> > +PeCoffGetEntryPointLib.inf
> > +
> >
> +DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTab
> > +leLib.inf
> > +  DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > +
> >
> +ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/D
> xeRe
> > +portStatusCodeLib.inf
> > --
> > 2.17.1
> >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65934): https://edk2.groups.io/g/devel/message/65934
Mute This Topic: https://groups.io/mt/77338595/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Leif Lindholm 5 years, 4 months ago 
Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <
abner.chang@hpe.com> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  =
c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between
Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove
NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back
once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65935): https://edk2.groups.io/g/devel/message/65935
Mute This Topic: https://groups.io/mt/77344489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Abner Chang 5 years, 4 months ago 

From: Leif Lindholm [mailto:leif@nuviainc.com]
Sent: Wednesday, October 7, 2020 12:29 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.
Oops!!!! My fault! Thanks for catching this.

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65945): https://edk2.groups.io/g/devel/message/65945
Mute This Topic: https://groups.io/mt/77352996/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Abner Chang 5 years, 4 months ago 
Yeah, I will send another version for this.
Thanks
Abner

Get Outlook for Android<https://aka.ms/ghei36>
________________________________
From: Leif Lindholm <leif@nuviainc.com>
Sent: Wednesday, October 7, 2020 12:29:28 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.

Hi Abner,

On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com<mailto:abner.chang@hpe.com>> wrote:
> > > diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
> > > file mode 100644 index 0000000000..d5c65f68c3
> > > --- /dev/null
> > > +++ b/RedfishPkg/RedfishPkg.dsc
> > > @@ -0,0 +1,40 @@
> > > +## @file
> > > +# Redfish Package
> > > +#
> > > +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
> > > +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
> > > +#
> > > +#    SPDX-License-Identifier: BSD-2-Clause-Patent
> > > +#
> > > +##
> > > +
> > > +[Defines]
> > > +  PLATFORM_NAME                  = RedfishPkg
> > > +  PLATFORM_GUID                  = c4352870-5232-11e7-9522-005056c00008
> > > +  PLATFORM_VERSION               = 1.0
> > > +  DSC_SPECIFICATION              = 0x0001001c
> > > +  OUTPUT_DIRECTORY               = Build/RedfishPkg
> > > +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
> > > +  BUILD_TARGETS                  = DEBUG|RELEASE
> >
> > v3 included NOOPT here. That was the version Laszlo gave his R-b for.
> >
> > v4 cover letter does mention NOOPT being removed, but I can see no
> > conversation in which this is discussed. What have I missed?
>
> No Leif, you did miss nothing. There was some Q/A conversations between Bret and me about the build target of CI.

This should really be referenced in the cover letter.

> We would like to keep NO-TARGET for the non-build CI test but remove NOOPT for now because we do not have
> the host-based unit test at the moment. We would like to add NOOPT back once we have the corresponding unit test on RedfishPkg.

Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
And it's not clear to me that Laszlo noticed this change.

/
    Leif


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65936): https://edk2.groups.io/g/devel/message/65936
Mute This Topic: https://groups.io/mt/77344644/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [EXTERNAL] RE: [edk2-devel] [RedfishPkg PATCH v5 1/4] RedfishPkg: Initial commit of RedfishPkg.
Posted by Laszlo Ersek 5 years, 4 months ago 
On 10/06/20 18:29, Leif Lindholm wrote:
> Hi Abner,
> 
> On Tue, Oct 6, 2020 at 5:20 PM Chang, Abner (HPS SW/FW Technologist) <
> abner.chang@hpe.com> wrote:
>>>> diff --git a/RedfishPkg/RedfishPkg.dsc b/RedfishPkg/RedfishPkg.dsc new
>>>> file mode 100644 index 0000000000..d5c65f68c3
>>>> --- /dev/null
>>>> +++ b/RedfishPkg/RedfishPkg.dsc
>>>> @@ -0,0 +1,40 @@
>>>> +## @file
>>>> +# Redfish Package
>>>> +#
>>>> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> #
>>>> +(C) Copyright 2020 Hewlett-Packard Enterprise Development LP.
>>>> +#
>>>> +#    SPDX-License-Identifier: BSD-2-Clause-Patent
>>>> +#
>>>> +##
>>>> +
>>>> +[Defines]
>>>> +  PLATFORM_NAME                  = RedfishPkg
>>>> +  PLATFORM_GUID                  =
> c4352870-5232-11e7-9522-005056c00008
>>>> +  PLATFORM_VERSION               = 1.0
>>>> +  DSC_SPECIFICATION              = 0x0001001c
>>>> +  OUTPUT_DIRECTORY               = Build/RedfishPkg
>>>> +  SUPPORTED_ARCHITECTURES        = IA32|X64|ARM|AARCH64|RISCV64
>>>> +  BUILD_TARGETS                  = DEBUG|RELEASE
>>>
>>> v3 included NOOPT here. That was the version Laszlo gave his R-b for.
>>>
>>> v4 cover letter does mention NOOPT being removed, but I can see no
>>> conversation in which this is discussed. What have I missed?
>>
>> No Leif, you did miss nothing. There was some Q/A conversations between
> Bret and me about the build target of CI.
> 
> This should really be referenced in the cover letter.
> 
>> We would like to keep NO-TARGET for the non-build CI test but remove
> NOOPT for now because we do not have
>> the host-based unit test at the moment. We would like to add NOOPT back
> once we have the corresponding unit test on RedfishPkg.
> 
> Right, but dropping it from the .dsc BUILD_TARGETS is not required for that.
> And it's not clear to me that Laszlo noticed this change.

I missed it.

The v4 blurb said, "Note for v4: NOOPT is removed from RedfishPkg.dsc
[...]", and then I wrote in my v4 patch#1 response, "According to the v4
blurb, this patch has not undergone any changes since v3".

So I clearly missed the actual meaning of the blurb. Sorry about that. I
guess I'm more used to patch-granularity changelogs.

Also I believe I didn't expect this series to reach v5, so I didn't do
my usual thing where I apply every version of a patch set separately on
a local topic branch, and then do incremental reviews with git-range-diff.

So it's my fault. A better (patch-granularity) changelog might have
mitigated my mistake, perhaps.

(BTW I've not been CC'd on any version of the blurb.)

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65937): https://edk2.groups.io/g/devel/message/65937
Mute This Topic: https://groups.io/mt/77344489/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.