1. Patchew
  2. EDK2
  3. [edk2-devel] [RedfishPkg PATCH 0/4] Inital RedfishPkg
  4. View patch

[edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Abner Chang posted 4 patches 5 years, 4 months ago
There is a newer version of this series
[edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Posted by Abner Chang 5 years, 4 months ago 
Signed-off-by: Chang Abner <abner.chang@hpe.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 6a22a14796..cc9d173285 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
 M: Ray Ni <ray.ni@intel.com>
 
+RedfishPkg: Redfish related modules
+F: RedfishPkg/
+M: Abner Chang <abner.chang@hpe.com>
+R: Abner Chang <abner.chang@hpe.com>
+R: Nickle Wang <nickle.wang@hpe.com>
+
 SecurityPkg
 F: SecurityPkg/
 W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65718): https://edk2.groups.io/g/devel/message/65718
Mute This Topic: https://groups.io/mt/77193107/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Posted by Laszlo Ersek 5 years, 4 months ago 
On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>  
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Abner Chang <abner.chang@hpe.com>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65722): https://edk2.groups.io/g/devel/message/65722
Mute This Topic: https://groups.io/mt/77193107/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Posted by Abner Chang 5 years, 4 months ago 
Without R, I still can give reviewed-by to others contribute to RedfishPkg right?

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Laszlo Ersek <lersek@redhat.com>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com>
> +R: Abner Chang <abner.chang@hpe.com>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65723): https://edk2.groups.io/g/devel/message/65723
Mute This Topic: https://groups.io/mt/77193107/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Posted by gaoliming 5 years, 4 months ago 
Yes. Maintainer has the both role of reviewer and patch merge. 

 

Thanks

Liming

 

发件人: bounce+27952+65723+4905953+8761045@groups.io
<bounce+27952+65723+4905953+8761045@groups.io> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; Andrew Fish <afish@apple.
com>; Leif Lindholm <leif@nuviainc.com>; Michael D Kinney
<michael.d.kinney@intel.com>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to
RedfishPkg

 

Without R, I still can give reviewed-by to others contribute to RedfishPkg
right?

 

Get Outlook for Android <https://aka.ms/ghei36> 

 

  _____

From: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io
<mailto:devel@edk2.groups.io> 
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg





On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com
<mailto:abner.chang@hpe.com> >
> Cc: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> Cc: Andrew Fish <afish@apple.com <mailto:afish@apple.com> >
> Cc: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com> >
> Cc: Leif Lindholm <leif@nuviainc.com <mailto:leif@nuviainc.com> >
> Cc: Michael D Kinney <michael.d.kinney@intel.com
<mailto:michael.d.kinney@intel.com> >
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> >
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >
> +R: Abner Chang <abner.chang@hpe.com <mailto:abner.chang@hpe.com> >

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com <mailto:nickle.wang@hpe.com> >
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
> 

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65741): https://edk2.groups.io/g/devel/message/65741
Mute This Topic: https://groups.io/mt/77209550/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg
Posted by Abner Chang 5 years, 4 months ago 
Got it! v2 patches sent to mail list.

From: gaoliming [mailto:gaoliming@byosoft.com.cn]
Sent: Wednesday, September 30, 2020 8:59 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; 'Laszlo Ersek' <lersek@redhat.com>
Cc: Wang, Nickle (HPS SW) <nickle.wang@hpe.com>; 'Andrew Fish' <afish@apple.com>; 'Leif Lindholm' <leif@nuviainc.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
Subject: 回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Yes. Maintainer has the both role of reviewer and patch merge.

Thanks
Liming

发件人: bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io> <bounce+27952+65723+4905953+8761045@groups.io<mailto:bounce+27952+65723+4905953+8761045@groups.io>> 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Wang, Nickle (HPS SW) <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>; Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>; Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Without R, I still can give reviewed-by to others contribute to RedfishPkg right?

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> Cc: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> Cc: Andrew Fish <afish@apple.com<mailto:afish@apple.com>>
> Cc: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>
> Cc: Leif Lindholm <leif@nuviainc.com<mailto:leif@nuviainc.com>>
> Cc: Michael D Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>
> +R: Abner Chang <abner.chang@hpe.com<mailto:abner.chang@hpe.com>>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.wang@hpe.com<mailto:nickle.wang@hpe.com>>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65754): https://edk2.groups.io/g/devel/message/65754
Mute This Topic: https://groups.io/mt/77210897/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.