NetworkPkg/HttpDxe/HttpProto.c | 1 + 1 file changed, 1 insertion(+)
BZ #2909,
https://bugzilla.tianocore.org/show_bug.cgi?id=2909
When Http->Configure() is invoked with HttpConfigData set to
NULL to reset the EFI HTTP instance, TLS child instance is
destroyed but HttpInstance->TlsChildHandle is not set to
NULL. After reconfiguring HTTP through Http->Configure()
and sending the HTTP request to HTTPS URL, TLS child
instance is not recreated because
HttpInstance->TlsChildHandle is not NULL.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Wu Jiaxin <jiaxin.wu@intel.com>
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
---
NetworkPkg/HttpDxe/HttpProto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c
index 3c7c6ff9f0c..afc7db5a726 100644
--- a/NetworkPkg/HttpDxe/HttpProto.c
+++ b/NetworkPkg/HttpDxe/HttpProto.c
@@ -873,6 +873,7 @@ HttpCleanProtocol (
// Destroy the TLS instance.
//
HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle);
+ HttpInstance->TlsChildHandle = NULL;
}
if (HttpInstance->Tcp4ChildHandle != NULL) {
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65676): https://edk2.groups.io/g/devel/message/65676
Mute This Topic: https://groups.io/mt/77169386/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com> On 28-Sep-20 08:29, Abner Chang wrote: > BZ #2909, > https://bugzilla.tianocore.org/show_bug.cgi?id=2909 > > When Http->Configure() is invoked with HttpConfigData set to > NULL to reset the EFI HTTP instance, TLS child instance is > destroyed but HttpInstance->TlsChildHandle is not set to > NULL. After reconfiguring HTTP through Http->Configure() > and sending the HTTP request to HTTPS URL, TLS child > instance is not recreated because > HttpInstance->TlsChildHandle is not NULL. > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > Cc: Wu Jiaxin <jiaxin.wu@intel.com> > Cc: Fu Siyuan <siyuan.fu@intel.com> > Cc: Nickle Wang <nickle.wang@hpe.com> > --- > NetworkPkg/HttpDxe/HttpProto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c > index 3c7c6ff9f0c..afc7db5a726 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > // Destroy the TLS instance. > // > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->TlsChildHandle); > + HttpInstance->TlsChildHandle = NULL; > } > > if (HttpInstance->Tcp4ChildHandle != NULL) { -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65727): https://edk2.groups.io/g/devel/message/65727 Mute This Topic: https://groups.io/mt/77169386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Maciej, Could you please help to merge this patch? Thanks! Abner > -----Original Message----- > From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com] > Sent: Tuesday, September 29, 2020 9:47 PM > To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; > devel@edk2.groups.io > Cc: Wu Jiaxin <jiaxin.wu@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; > Wang, Nickle (HPS SW) <nickle.wang@hpe.com> > Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared > when reset > > Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com> > > On 28-Sep-20 08:29, Abner Chang wrote: > > BZ #2909, > > INVALID URI REMOVED > > e.org_show-5Fbug.cgi-3Fid- > 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_ > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX > bkL2XI7A > > ieZI7M- > u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e= > > > > When Http->Configure() is invoked with HttpConfigData set to NULL to > > reset the EFI HTTP instance, TLS child instance is destroyed but > > HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring > > HTTP through Http->Configure() and sending the HTTP request to HTTPS > > URL, TLS child instance is not recreated because > > HttpInstance->TlsChildHandle is not NULL. > > > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > > > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > > Cc: Wu Jiaxin <jiaxin.wu@intel.com> > > Cc: Fu Siyuan <siyuan.fu@intel.com> > > Cc: Nickle Wang <nickle.wang@hpe.com> > > --- > > NetworkPkg/HttpDxe/HttpProto.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c > > b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 > 100644 > > --- a/NetworkPkg/HttpDxe/HttpProto.c > > +++ b/NetworkPkg/HttpDxe/HttpProto.c > > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > > // Destroy the TLS instance. > > // > > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, > > HttpInstance->TlsChildHandle); > > + HttpInstance->TlsChildHandle = NULL; > > } > > > > if (HttpInstance->Tcp4ChildHandle != NULL) { -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66022): https://edk2.groups.io/g/devel/message/66022 Mute This Topic: https://groups.io/mt/77169386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Abner, Waiting for review on a different patch on NetworkPkg, else CI likely fires in my face when I try to integrate yours. https://edk2.groups.io/g/devel/message/65833 Thanks, Maciej On 08-Oct-20 15:50, Abner Chang wrote: > Hi Maciej, > Could you please help to merge this patch? Thanks! > Abner > >> -----Original Message----- >> From: Rabeda, Maciej [mailto:maciej.rabeda@linux.intel.com] >> Sent: Tuesday, September 29, 2020 9:47 PM >> To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; >> devel@edk2.groups.io >> Cc: Wu Jiaxin <jiaxin.wu@intel.com>; Fu Siyuan <siyuan.fu@intel.com>; >> Wang, Nickle (HPS SW) <nickle.wang@hpe.com> >> Subject: Re: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared >> when reset >> >> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com> >> >> On 28-Sep-20 08:29, Abner Chang wrote: >>> BZ #2909, >>> INVALID URI REMOVED >>> e.org_show-5Fbug.cgi-3Fid- >> 3D2909&d=DwICaQ&c=C5b8zRQO1miGmBeVZ2LFWg&r=_ >> SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=gVilLut38Vw51w0YX >> bkL2XI7A >>> ieZI7M- >> u7_bYls4zQo&s=eavHqEkeSVmQnn5EYDmq9TnEyjp8MS3_hdpPDgG9hSY&e= >>> When Http->Configure() is invoked with HttpConfigData set to NULL to >>> reset the EFI HTTP instance, TLS child instance is destroyed but >>> HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring >>> HTTP through Http->Configure() and sending the HTTP request to HTTPS >>> URL, TLS child instance is not recreated because >>> HttpInstance->TlsChildHandle is not NULL. >>> >>> Signed-off-by: Abner Chang <abner.chang@hpe.com> >>> >>> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> >>> Cc: Wu Jiaxin <jiaxin.wu@intel.com> >>> Cc: Fu Siyuan <siyuan.fu@intel.com> >>> Cc: Nickle Wang <nickle.wang@hpe.com> >>> --- >>> NetworkPkg/HttpDxe/HttpProto.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/NetworkPkg/HttpDxe/HttpProto.c >>> b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 >> 100644 >>> --- a/NetworkPkg/HttpDxe/HttpProto.c >>> +++ b/NetworkPkg/HttpDxe/HttpProto.c >>> @@ -873,6 +873,7 @@ HttpCleanProtocol ( >>> // Destroy the TLS instance. >>> // >>> HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, >>> HttpInstance->TlsChildHandle); >>> + HttpInstance->TlsChildHandle = NULL; >>> } >>> >>> if (HttpInstance->Tcp4ChildHandle != NULL) { > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#66032): https://edk2.groups.io/g/devel/message/66032 Mute This Topic: https://groups.io/mt/77169386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com> Thanks, Jiaxin > -----Original Message----- > From: Abner Chang <abner.chang@hpe.com> > Sent: Monday, September 28, 2020 2:30 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Maciej Rabeda <maciej.rabeda@linux.intel.com>; > Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Nickle > Wang <nickle.wang@hpe.com> > Subject: [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when > reset > > BZ #2909, > https://bugzilla.tianocore.org/show_bug.cgi?id=2909 > > When Http->Configure() is invoked with HttpConfigData set to > NULL to reset the EFI HTTP instance, TLS child instance is > destroyed but HttpInstance->TlsChildHandle is not set to > NULL. After reconfiguring HTTP through Http->Configure() > and sending the HTTP request to HTTPS URL, TLS child > instance is not recreated because > HttpInstance->TlsChildHandle is not NULL. > > Signed-off-by: Abner Chang <abner.chang@hpe.com> > > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > Cc: Wu Jiaxin <jiaxin.wu@intel.com> > Cc: Fu Siyuan <siyuan.fu@intel.com> > Cc: Nickle Wang <nickle.wang@hpe.com> > --- > NetworkPkg/HttpDxe/HttpProto.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/NetworkPkg/HttpDxe/HttpProto.c > b/NetworkPkg/HttpDxe/HttpProto.c > index 3c7c6ff9f0c..afc7db5a726 100644 > --- a/NetworkPkg/HttpDxe/HttpProto.c > +++ b/NetworkPkg/HttpDxe/HttpProto.c > @@ -873,6 +873,7 @@ HttpCleanProtocol ( > // Destroy the TLS instance. > // > HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance- > >TlsChildHandle); > + HttpInstance->TlsChildHandle = NULL; > } > > if (HttpInstance->Tcp4ChildHandle != NULL) { > -- > 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65677): https://edk2.groups.io/g/devel/message/65677 Mute This Topic: https://groups.io/mt/77169386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.