From nobody Sat May 18 10:30:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+65676+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65676+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1601274580; cv=none; d=zohomail.com; s=zohoarc; b=OxMaCxpvy48zYaZSrwSmFOFyMR7TQRpnv6/kTDitxMsSG5MOmuNmiDMcXOWK3H7QTF2tXBphbAPB2JqyLDS/RB6ZQjn3UXBhOhvHY3KmHCcKfskf/uExKeHIg8TjWrawmuCZDVOuql6nuTmKU+zZpy3L9UsVGBQ2SU/2TKLiddI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601274580; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=SipSWv5iDIWooTHtUccLVKZZNss7j+0NsSQove6NvKo=; b=HRrYWMePpEfr3Tu8p4rjX2J06BlfVbN2+jlcJ+qoqhJKOm/FlSZNGRZD2miYJ812pvtJFnJd+1m1ZUaIGlD/JlZ5tMbquUZyMdpwsN6e8BNvWqAAU78UtQHaIxtDUz7VoDBVGXZq11t++oFjYMR07mAQEyoIJAiL19zzeUvuA3s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+65676+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 160127458033973.38828928047224; Sun, 27 Sep 2020 23:29:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WbwWYY1788612xEHpuQKrFR4; Sun, 27 Sep 2020 23:29:39 -0700 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.30760.1601274579128312164 for ; Sun, 27 Sep 2020 23:29:39 -0700 X-Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08S6Pfsi024051; Mon, 28 Sep 2020 06:29:38 GMT X-Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 33suuct9sj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Sep 2020 06:29:38 +0000 X-Received: from g2t2360.austin.hpecorp.net (g2t2360.austin.hpecorp.net [16.196.225.135]) by g2t2352.austin.hpe.com (Postfix) with ESMTP id E98239B; Mon, 28 Sep 2020 06:29:37 +0000 (UTC) X-Received: from SAC2XFT1JT.asiapacific.hpqcorp.net (sac2xft1jt.asiapacific.hpqcorp.net [10.43.42.132]) by g2t2360.austin.hpecorp.net (Postfix) with ESMTP id 6B87436; Mon, 28 Sep 2020 06:29:36 +0000 (UTC) From: "Abner Chang" To: devel@edk2.groups.io Cc: abner.chang@hpe.com, Maciej Rabeda , Wu Jiaxin , Fu Siyuan , Nickle Wang Subject: [edk2-devel] [PATCH] NetworkPkg/HttpDxe: TlsChildHandle is not cleared when reset Date: Mon, 28 Sep 2020 14:29:34 +0800 Message-Id: <20200928062934.505108-1-abner.chang@hpe.com> X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@hpe.com X-Gm-Message-State: WSCF9EiUSXoS71S8z5D80NKBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1601274579; bh=sGcv7ftEhn0rQieUAd/+s2AAzPRu7/UoOzpMJuRCA/U=; h=Cc:Date:From:Reply-To:Subject:To; b=YV3uGxTOF66rIK45Xg6kCNdWkT5CPJqnfpQ8wWwpD4tuSHheiwZ0UuUk0Mz9LlOWV/D prKJnQa9CXT9qNwvtO7ngDUCqpVVHEihNzvOCa/p/6MQCbuxGuW6FiTcxBjCtzQDz3POT GcmuJUrbH3+e42Xa9cUecrxnIT2UhTQBk2k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ #2909, https://bugzilla.tianocore.org/show_bug.cgi?id=3D2909 When Http->Configure() is invoked with HttpConfigData set to NULL to reset the EFI HTTP instance, TLS child instance is destroyed but HttpInstance->TlsChildHandle is not set to NULL. After reconfiguring HTTP through Http->Configure() and sending the HTTP request to HTTPS URL, TLS child instance is not recreated because HttpInstance->TlsChildHandle is not NULL. Signed-off-by: Abner Chang Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Fu Siyuan Cc: Nickle Wang Reviewed-by: Maciej Rabeda Reviewed-by: Wu Jiaxin --- NetworkPkg/HttpDxe/HttpProto.c | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 3c7c6ff9f0c..afc7db5a726 100644 --- a/NetworkPkg/HttpDxe/HttpProto.c +++ b/NetworkPkg/HttpDxe/HttpProto.c @@ -873,6 +873,7 @@ HttpCleanProtocol ( // Destroy the TLS instance. // HttpInstance->TlsSb->DestroyChild (HttpInstance->TlsSb, HttpInstance->= TlsChildHandle); + HttpInstance->TlsChildHandle =3D NULL; } =20 if (HttpInstance->Tcp4ChildHandle !=3D NULL) { --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#65676): https://edk2.groups.io/g/devel/message/65676 Mute This Topic: https://groups.io/mt/77169386/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-