[edk2-devel] [PATCH v3 edk2-platforms 0/8] Add ACPI tables support for SbsaQemu

Tanmay Jagdale posted 8 patches 3 years, 8 months ago
Failed in applying to current master (apply log)
Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |   8 +-
Silicon/Qemu/SbsaQemu/Acpi.dsc.inc                                |  36 ++
Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  12 +-
Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   9 +
Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf                   |  47 ++
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |  67 +++
Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h     | 199 ++++++++
Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   | 485 ++++++++++++++++++++
Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc                        |  67 +++
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl                         | 449 ++++++++++++++++++
Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc                        |  80 ++++
Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc                        |  67 +++
Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc                        |  43 ++
Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc                        |  53 +++
14 files changed, 1618 insertions(+), 4 deletions(-)
create mode 100644 Silicon/Qemu/SbsaQemu/Acpi.dsc.inc
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
create mode 100644 Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc
create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc
[edk2-devel] [PATCH v3 edk2-platforms 0/8] Add ACPI tables support for SbsaQemu
Posted by Tanmay Jagdale 3 years, 8 months ago
This patch series adds ACPI tables support for the SbsaQemu platform.
We are using a pseudo static approach to create the ACPI tables.

The ACPI tables namely DBG2, DSDT, MCFG, SPCR, GTDT are created in a
static way at compile time because they hold a fixed configuration
and there are no changes at runtime.

The MADT, SSDT and PPTT tables are dependant on the number of CPUs and
hence they are created at runtime based on the number of CPUs the user
has requested

Changes in v3:
  - Dropped ASSERT() in CountCpusFromFdt() function in patch 4.
  - Changed EFI_D_ERROR to DEBUG_ERROR

Changes in v2:
  - Moved PcdCoreCount and Fdtlib related changes in SbsaQemu.dsc to a
    separate patch (Patch 3).
  - Removed Acpi6x.h header file includes and used IndustryStandard/Acpi.h
  - Whitespace cleanups
  - Added proper code comments

Tanmay Jagdale (8):
  SbsaQemu: Initial support for static ACPI tables
  SbsaQemu: AcpiTables: Add PCI support and MCFG Table
  SbsaQemu: SbsaQemu.dsc: Move CoreCount and Fdtlib
  SbsaQemu: Add new ACPI driver and FDT parser to count CPUs
  SbsaQemu: AcpiDxe: Create MADT table at runtime
  SbsaQemu: AcpiDxe: Create SSDT table at runtime
  SbsaQemu: AcpiDxe: Create PPTT table at runtime
  SbsaQemu: AcpiTables: Add DBG2 Table

 Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |   8 +-
 Silicon/Qemu/SbsaQemu/Acpi.dsc.inc                                |  36 ++
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  12 +-
 Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   9 +
 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf                   |  47 ++
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |  67 +++
 Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h     | 199 ++++++++
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   | 485 ++++++++++++++++++++
 Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc                        |  67 +++
 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl                         | 449 ++++++++++++++++++
 Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc                        |  80 ++++
 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc                        |  67 +++
 Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc                        |  43 ++
 Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc                        |  53 +++
 14 files changed, 1618 insertions(+), 4 deletions(-)
 create mode 100644 Silicon/Qemu/SbsaQemu/Acpi.dsc.inc
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
 create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
 create mode 100644 Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
 create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc
 create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc

-- 
2.28.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64611): https://edk2.groups.io/g/devel/message/64611
Mute This Topic: https://groups.io/mt/76406662/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 edk2-platforms 0/8] Add ACPI tables support for SbsaQemu
Posted by Leif Lindholm 3 years, 8 months ago
On Tue, Aug 25, 2020 at 19:09:50 +0530, Tanmay Jagdale wrote:
> This patch series adds ACPI tables support for the SbsaQemu platform.
> We are using a pseudo static approach to create the ACPI tables.
> 
> The ACPI tables namely DBG2, DSDT, MCFG, SPCR, GTDT are created in a
> static way at compile time because they hold a fixed configuration
> and there are no changes at runtime.
> 
> The MADT, SSDT and PPTT tables are dependant on the number of CPUs and
> hence they are created at runtime based on the number of CPUs the user
> has requested
> 
> Changes in v3:
>   - Dropped ASSERT() in CountCpusFromFdt() function in patch 4.
>   - Changed EFI_D_ERROR to DEBUG_ERROR
> 
> Changes in v2:
>   - Moved PcdCoreCount and Fdtlib related changes in SbsaQemu.dsc to a
>     separate patch (Patch 3).
>   - Removed Acpi6x.h header file includes and used IndustryStandard/Acpi.h
>   - Whitespace cleanups
>   - Added proper code comments

Thanks for quick respin.
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as 23863e9e9d40..90c3b3bc0c3e.

> Tanmay Jagdale (8):
>   SbsaQemu: Initial support for static ACPI tables
>   SbsaQemu: AcpiTables: Add PCI support and MCFG Table
>   SbsaQemu: SbsaQemu.dsc: Move CoreCount and Fdtlib
>   SbsaQemu: Add new ACPI driver and FDT parser to count CPUs
>   SbsaQemu: AcpiDxe: Create MADT table at runtime
>   SbsaQemu: AcpiDxe: Create SSDT table at runtime
>   SbsaQemu: AcpiDxe: Create PPTT table at runtime
>   SbsaQemu: AcpiTables: Add DBG2 Table
> 
>  Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                |   8 +-
>  Silicon/Qemu/SbsaQemu/Acpi.dsc.inc                                |  36 ++
>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               |  12 +-
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf                               |   9 +
>  Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf                   |  47 ++
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf |  67 +++
>  Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h     | 199 ++++++++
>  Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c   | 485 ++++++++++++++++++++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc                        |  67 +++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl                         | 449 ++++++++++++++++++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc                        |  80 ++++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc                        |  67 +++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc                        |  43 ++
>  Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc                        |  53 +++
>  14 files changed, 1618 insertions(+), 4 deletions(-)
>  create mode 100644 Silicon/Qemu/SbsaQemu/Acpi.dsc.inc
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
>  create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
>  create mode 100644 Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h
>  create mode 100644 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Fadt.aslc
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Gtdt.aslc
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Mcfg.aslc
>  create mode 100644 Silicon/Qemu/SbsaQemu/AcpiTables/Spcr.aslc
> 
> -- 
> 2.28.0
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#64620): https://edk2.groups.io/g/devel/message/64620
Mute This Topic: https://groups.io/mt/76406662/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-