.pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 ++++++++++++++++++ .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++ .pytool/Plugin/LicenseCheck/Readme.md | 17 +++ ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + CryptoPkg/CryptoPkg.ci.yaml | 3 + EmulatorPkg/EmulatorPkg.ci.yaml | 4 + FatPkg/FatPkg.ci.yaml | 3 + FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + MdeModulePkg/MdeModulePkg.ci.yaml | 4 + MdePkg/MdePkg.ci.yaml | 4 + NetworkPkg/NetworkPkg.ci.yaml | 3 + OvmfPkg/OvmfPkg.ci.yaml | 4 + PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + SecurityPkg/SecurityPkg.ci.yaml | 3 + ShellPkg/ShellPkg.ci.yaml | 3 + UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + .../UnitTestFrameworkPkg.ci.yaml | 4 + 17 files changed, 194 insertions(+) create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck.py create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml create mode 100644 .pytool/Plugin/LicenseCheck/Readme.md
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's
a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert the change.These patch series introduce
a plugin LicenseCheck into open ci so that license issues can
still be checked after the checker is disabled in PatchCheck.py.
1/15 is the plugin implementation.
2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers
to skip license check for some files like generated files.
Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can pass this checker.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Shenglei Zhang (15):
.pytool/Plugin: Add a plugin LicenseCheck
FatPkg/FatPkg.ci.yaml: Add configuration for LicenseCheck
ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for LicenseCheck
CryptoPkg/CryptoPkg.ci.yaml: Add configuration for LicenseCheck
EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for LicenseCheck
FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for LicenseCheck
MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for LicenseCheck
MdePkg/MdePkg.ci.yaml: Add configuration for LicenseCheck
NetworkPkg/NetworkPkg.ci.yaml: Add configuration for LicenseCheck
OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for
LicenseCheck
SecurityPkg/SecurityPkg.ci.yaml: Add configuration for LicenseCheck
ShellPkg/ShellPkg.ci.yaml: Add configuration for LicenseCheck
UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for LicenseCheck
UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml file
.pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 ++++++++++++++++++
.../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++
.pytool/Plugin/LicenseCheck/Readme.md | 17 +++
ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 +
CryptoPkg/CryptoPkg.ci.yaml | 3 +
EmulatorPkg/EmulatorPkg.ci.yaml | 4 +
FatPkg/FatPkg.ci.yaml | 3 +
FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +
MdeModulePkg/MdeModulePkg.ci.yaml | 4 +
MdePkg/MdePkg.ci.yaml | 4 +
NetworkPkg/NetworkPkg.ci.yaml | 3 +
OvmfPkg/OvmfPkg.ci.yaml | 4 +
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +
SecurityPkg/SecurityPkg.ci.yaml | 3 +
ShellPkg/ShellPkg.ci.yaml | 3 +
UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +
.../UnitTestFrameworkPkg.ci.yaml | 4 +
17 files changed, 194 insertions(+)
create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck.py
create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/LicenseCheck/Readme.md
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#62806): https://edk2.groups.io/g/devel/message/62806
Mute This Topic: https://groups.io/mt/75678207/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On 7/20/20 2:36 AM, Zhang, Shenglei wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > LicenseCheck is now enabled in PatchCheck.py. But there's > a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" > to suggest revert the change.These patch series introduce > a plugin LicenseCheck into open ci so that license issues can > still be checked after the checker is disabled in PatchCheck.py. > 1/15 is the plugin implementation. > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers > to skip license check for some files like generated files. Has there been any progress on this? I'm waiting for it because it's required for my bhyve changes. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63268): https://edk2.groups.io/g/devel/message/63268 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Rebecca: I see Shenglei patch. I plan to finish review early of this week, then merge this patch set, and revert the original change in PatchCheck.py. Thanks Liming -----Original Message----- From: Rebecca Cran <rebecca@bsdio.com> Sent: 2020年7月25日 9:38 To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zhang@intel.com> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao Zhang <chao.b.zhang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Gao, Liming <liming.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com> Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci On 7/20/20 2:36 AM, Zhang, Shenglei wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > LicenseCheck is now enabled in PatchCheck.py. But there's a patch > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" > to suggest revert the change.These patch series introduce a plugin > LicenseCheck into open ci so that license issues can still be checked > after the checker is disabled in PatchCheck.py. > 1/15 is the plugin implementation. > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers to > skip license check for some files like generated files. Has there been any progress on this? I'm waiting for it because it's required for my bhyve changes. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63278): https://edk2.groups.io/g/devel/message/63278 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
CI already runs PatchCheck. If we ported PatchCheck to a CI plugin, then the plugin could perform both the current PatchCheck features and the license check. What this option evaluated? If we did provide PatchCheck as a CI plugin, developers I believe developers could run a stuart command likely for the NOOPT target to run a PatchCheck CI plugin locally. Thanks, Mike > -----Original Message----- > From: Zhang, Shenglei <shenglei.zhang@intel.com> > Sent: Monday, July 20, 2020 1:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean > Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Dong, Eric > <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; > Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Chao Zhang > <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin > <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; > Gao, Liming <liming.gao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; > Andrew Fish <afish@apple.com>; Ni, Ray > <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; > Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm > <leif@nuviainc.com> > Subject: [PATCH 00/15] Add a plugin LicenseCheck in open > ci > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > LicenseCheck is now enabled in PatchCheck.py. But > there's > a patch "Revert 'BaseTools/PatchCheck.py: Add > LicenseCheck'" > to suggest revert the change.These patch series > introduce > a plugin LicenseCheck into open ci so that license > issues can > still be checked after the checker is disabled in > PatchCheck.py. > 1/15 is the plugin implementation. > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow > developers > to skip license check for some files like generated > files. > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can > pass this checker. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > Cc: Eric Dong <eric.dong@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Chao Zhang <chao.b.zhang@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > Cc: Jiaxin Wu <jiaxin.wu@intel.com> > Cc: Siyuan Fu <siyuan.fu@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Andrew Fish <afish@apple.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Shenglei Zhang (15): > .pytool/Plugin: Add a plugin LicenseCheck > FatPkg/FatPkg.ci.yaml: Add configuration for > LicenseCheck > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for > LicenseCheck > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for > LicenseCheck > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for > LicenseCheck > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration > for LicenseCheck > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration > for LicenseCheck > MdePkg/MdePkg.ci.yaml: Add configuration for > LicenseCheck > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for > LicenseCheck > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for > LicenseCheck > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add > configuration for > LicenseCheck > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for > LicenseCheck > ShellPkg/ShellPkg.ci.yaml: Add configuration for > LicenseCheck > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for > LicenseCheck > UnitTestFrameworkPkg: Add configuration for > LicenseCheck in yaml file > > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 > ++++++++++++++++++ > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++ > .pytool/Plugin/LicenseCheck/Readme.md | 17 +++ > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + > CryptoPkg/CryptoPkg.ci.yaml | 3 + > EmulatorPkg/EmulatorPkg.ci.yaml | 4 + > FatPkg/FatPkg.ci.yaml | 3 + > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + > MdeModulePkg/MdeModulePkg.ci.yaml | 4 + > MdePkg/MdePkg.ci.yaml | 4 + > NetworkPkg/NetworkPkg.ci.yaml | 3 + > OvmfPkg/OvmfPkg.ci.yaml | 4 + > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + > SecurityPkg/SecurityPkg.ci.yaml | 3 + > ShellPkg/ShellPkg.ci.yaml | 3 + > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + > .../UnitTestFrameworkPkg.ci.yaml | 4 + > 17 files changed, 194 insertions(+) > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck.py > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml > create mode 100644 > .pytool/Plugin/LicenseCheck/Readme.md > > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63420): https://edk2.groups.io/g/devel/message/63420 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Mike: Previous discussion (https://edk2.groups.io/g/devel/message/62494) is to revert the license check change in PatchCheck, and enable license check as plugin. If so, the package maintainers can configure the package level exception list to allow some special cases, such as autogen file. Thanks Liming -----Original Message----- From: Kinney, Michael D <michael.d.kinney@intel.com> Sent: 2020年7月29日 7:34 To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao Zhang <chao.b.zhang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Gao, Liming <liming.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in open ci CI already runs PatchCheck. If we ported PatchCheck to a CI plugin, then the plugin could perform both the current PatchCheck features and the license check. What this option evaluated? If we did provide PatchCheck as a CI plugin, developers I believe developers could run a stuart command likely for the NOOPT target to run a PatchCheck CI plugin locally. Thanks, Mike > -----Original Message----- > From: Zhang, Shenglei <shenglei.zhang@intel.com> > Sent: Monday, July 20, 2020 1:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan > <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao > <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, > Siyuan <siyuan.fu@intel.com>; Gao, Liming <liming.gao@intel.com>; > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; > Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX > <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif > Lindholm <leif@nuviainc.com> > Subject: [PATCH 00/15] Add a plugin LicenseCheck in open ci > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > LicenseCheck is now enabled in PatchCheck.py. But there's a patch > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" > to suggest revert the change.These patch series introduce a plugin > LicenseCheck into open ci so that license issues can still be checked > after the checker is disabled in PatchCheck.py. > 1/15 is the plugin implementation. > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers to > skip license check for some files like generated files. > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can pass this > checker. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > Cc: Eric Dong <eric.dong@intel.com> > Cc: Laszlo Ersek <lersek@redhat.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Chao Zhang <chao.b.zhang@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > Cc: Jiaxin Wu <jiaxin.wu@intel.com> > Cc: Siyuan Fu <siyuan.fu@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Andrew Fish <afish@apple.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Jian J Wang <jian.j.wang@intel.com> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Shenglei Zhang (15): > .pytool/Plugin: Add a plugin LicenseCheck > FatPkg/FatPkg.ci.yaml: Add configuration for LicenseCheck > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for LicenseCheck > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for LicenseCheck > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for LicenseCheck > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for > LicenseCheck > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for > LicenseCheck > MdePkg/MdePkg.ci.yaml: Add configuration for LicenseCheck > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for LicenseCheck > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for > LicenseCheck > SecurityPkg/SecurityPkg.ci.yaml: Add configuration for LicenseCheck > ShellPkg/ShellPkg.ci.yaml: Add configuration for LicenseCheck > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for LicenseCheck > UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml > file > > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 > ++++++++++++++++++ > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++ > .pytool/Plugin/LicenseCheck/Readme.md | 17 +++ > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + > CryptoPkg/CryptoPkg.ci.yaml | 3 + > EmulatorPkg/EmulatorPkg.ci.yaml | 4 + > FatPkg/FatPkg.ci.yaml | 3 + > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + > MdeModulePkg/MdeModulePkg.ci.yaml | 4 + > MdePkg/MdePkg.ci.yaml | 4 + > NetworkPkg/NetworkPkg.ci.yaml | 3 + > OvmfPkg/OvmfPkg.ci.yaml | 4 + > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + > SecurityPkg/SecurityPkg.ci.yaml | 3 + > ShellPkg/ShellPkg.ci.yaml | 3 + > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + > .../UnitTestFrameworkPkg.ci.yaml | 4 + > 17 files changed, 194 insertions(+) > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck.py > create mode 100644 > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml > create mode 100644 > .pytool/Plugin/LicenseCheck/Readme.md > > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63424): https://edk2.groups.io/g/devel/message/63424 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Liming, There are exception to PatchCheck as well for line endings and tabs. Seems like a similar problem, and a single CI plugin could support all these cases. Mike > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Tuesday, July 28, 2020 6:12 PM > To: Kinney, Michael D <michael.d.kinney@intel.com>; > Zhang, Shenglei <shenglei.zhang@intel.com>; > devel@edk2.groups.io > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret > Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric > <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; > Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Chao Zhang > <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin > <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A > <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, > Ray <ray.ni@intel.com>; Lu, XiaoyuX > <xiaoyux.lu@intel.com>; Ard Biesheuvel > <ard.biesheuvel@arm.com>; Leif Lindholm > <leif@nuviainc.com>; Gao, Liming <liming.gao@intel.com> > Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in > open ci > > Mike: > Previous discussion > (https://edk2.groups.io/g/devel/message/62494) is to > revert the license check change in PatchCheck, and > enable license check as plugin. If so, the package > maintainers can configure the package level exception > list to allow some special cases, such as autogen file. > > Thanks > Liming > -----Original Message----- > From: Kinney, Michael D <michael.d.kinney@intel.com> > Sent: 2020年7月29日 7:34 > To: Zhang, Shenglei <shenglei.zhang@intel.com>; > devel@edk2.groups.io; Kinney, Michael D > <michael.d.kinney@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret > Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric > <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; > Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Chao Zhang > <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin > <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; > Gao, Liming <liming.gao@intel.com>; Wang, Jian J > <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; > Andrew Fish <afish@apple.com>; Ni, Ray > <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; > Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm > <leif@nuviainc.com> > Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in > open ci > > CI already runs PatchCheck. If we ported PatchCheck to > a CI plugin, then the plugin could perform both the > current PatchCheck features and the license check. > > What this option evaluated? > > If we did provide PatchCheck as a CI plugin, developers > I believe developers could run a stuart command likely > for the NOOPT target to run a PatchCheck CI plugin > locally. > > Thanks, > > Mike > > > -----Original Message----- > > From: Zhang, Shenglei <shenglei.zhang@intel.com> > > Sent: Monday, July 20, 2020 1:37 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; > Sean Brogan > > <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Dong, Eric > <eric.dong@intel.com>; > > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao > > <zhichao.gao@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Chao > > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L > > <jordan.l.justen@intel.com>; Maciej Rabeda > > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin > <jiaxin.wu@intel.com>; Fu, > > Siyuan <siyuan.fu@intel.com>; Gao, Liming > <liming.gao@intel.com>; > > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A > <hao.a.wu@intel.com>; > > Andrew Fish <afish@apple.com>; Ni, Ray > <ray.ni@intel.com>; Lu, XiaoyuX > > <xiaoyux.lu@intel.com>; Ard Biesheuvel > <ard.biesheuvel@arm.com>; Leif > > Lindholm <leif@nuviainc.com> > > Subject: [PATCH 00/15] Add a plugin LicenseCheck in > open ci > > > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > > LicenseCheck is now enabled in PatchCheck.py. But > there's a patch > > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" > > to suggest revert the change.These patch series > introduce a plugin > > LicenseCheck into open ci so that license issues can > still be checked > > after the checker is disabled in PatchCheck.py. > > 1/15 is the plugin implementation. > > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow > developers to > > skip license check for some files like generated > files. > > > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can > pass this > > checker. > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Eric Dong <eric.dong@intel.com> > > Cc: Laszlo Ersek <lersek@redhat.com> > > Cc: Zhichao Gao <zhichao.gao@intel.com> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Chao Zhang <chao.b.zhang@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > > Cc: Jiaxin Wu <jiaxin.wu@intel.com> > > Cc: Siyuan Fu <siyuan.fu@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc: Andrew Fish <afish@apple.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com> > > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > > Cc: Leif Lindholm <leif@nuviainc.com> > > Shenglei Zhang (15): > > .pytool/Plugin: Add a plugin LicenseCheck > > FatPkg/FatPkg.ci.yaml: Add configuration for > LicenseCheck > > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for > LicenseCheck > > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for > LicenseCheck > > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration > for LicenseCheck > > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration > for > > LicenseCheck > > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration > for > > LicenseCheck > > MdePkg/MdePkg.ci.yaml: Add configuration for > LicenseCheck > > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for > LicenseCheck > > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for > LicenseCheck > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add > configuration for > > LicenseCheck > > SecurityPkg/SecurityPkg.ci.yaml: Add configuration > for LicenseCheck > > ShellPkg/ShellPkg.ci.yaml: Add configuration for > LicenseCheck > > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for > LicenseCheck > > UnitTestFrameworkPkg: Add configuration for > LicenseCheck in yaml > > file > > > > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 > > ++++++++++++++++++ > > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 > ++ > > .pytool/Plugin/LicenseCheck/Readme.md | 17 > +++ > > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + > > CryptoPkg/CryptoPkg.ci.yaml | 3 + > > EmulatorPkg/EmulatorPkg.ci.yaml | 4 + > > FatPkg/FatPkg.ci.yaml | 3 + > > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + > > MdeModulePkg/MdeModulePkg.ci.yaml | 4 + > > MdePkg/MdePkg.ci.yaml | 4 + > > NetworkPkg/NetworkPkg.ci.yaml | 3 + > > OvmfPkg/OvmfPkg.ci.yaml | 4 + > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + > > SecurityPkg/SecurityPkg.ci.yaml | 3 + > > ShellPkg/ShellPkg.ci.yaml | 3 + > > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + > > .../UnitTestFrameworkPkg.ci.yaml | 4 + > > 17 files changed, 194 insertions(+) > > create mode 100644 > > .pytool/Plugin/LicenseCheck/LicenseCheck.py > > create mode 100644 > > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml > > create mode 100644 > > .pytool/Plugin/LicenseCheck/Readme.md > > > > -- > > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63427): https://edk2.groups.io/g/devel/message/63427 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Mike: I think this is a separate request. I submit BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2868 for it. Thanks Liming -----Original Message----- From: Kinney, Michael D <michael.d.kinney@intel.com> Sent: 2020年7月29日 9:33 To: Gao, Liming <liming.gao@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com> Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao Zhang <chao.b.zhang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com> Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in open ci Hi Liming, There are exception to PatchCheck as well for line endings and tabs. Seems like a similar problem, and a single CI plugin could support all these cases. Mike > -----Original Message----- > From: Gao, Liming <liming.gao@intel.com> > Sent: Tuesday, July 28, 2020 6:12 PM > To: Kinney, Michael D <michael.d.kinney@intel.com>; Zhang, Shenglei > <shenglei.zhang@intel.com>; devel@edk2.groups.io > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao > <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, > Siyuan <siyuan.fu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; > Wu, Hao A <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray > <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel > <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com>; Gao, > Liming <liming.gao@intel.com> > Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in open ci > > Mike: > Previous discussion > (https://edk2.groups.io/g/devel/message/62494) is to revert the > license check change in PatchCheck, and enable license check as > plugin. If so, the package maintainers can configure the package level > exception list to allow some special cases, such as autogen file. > > Thanks > Liming > -----Original Message----- > From: Kinney, Michael D <michael.d.kinney@intel.com> > Sent: 2020年7月29日 7:34 > To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io; > Kinney, Michael D <michael.d.kinney@intel.com> > Cc: Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew > <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao > <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L > <jordan.l.justen@intel.com>; Maciej Rabeda > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, > Siyuan <siyuan.fu@intel.com>; Gao, Liming <liming.gao@intel.com>; > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; > Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX > <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif > Lindholm <leif@nuviainc.com> > Subject: RE: [PATCH 00/15] Add a plugin LicenseCheck in open ci > > CI already runs PatchCheck. If we ported PatchCheck to a CI plugin, > then the plugin could perform both the current PatchCheck features and > the license check. > > What this option evaluated? > > If we did provide PatchCheck as a CI plugin, developers I believe > developers could run a stuart command likely for the NOOPT target to > run a PatchCheck CI plugin locally. > > Thanks, > > Mike > > > -----Original Message----- > > From: Zhang, Shenglei <shenglei.zhang@intel.com> > > Sent: Monday, July 20, 2020 1:37 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; > Sean Brogan > > <sean.brogan@microsoft.com>; Bret Barkelew > > <Bret.Barkelew@microsoft.com>; Dong, Eric > <eric.dong@intel.com>; > > Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao > > <zhichao.gao@intel.com>; Yao, Jiewen > <jiewen.yao@intel.com>; Chao > > Zhang <chao.b.zhang@intel.com>; Justen, Jordan L > > <jordan.l.justen@intel.com>; Maciej Rabeda > > <maciej.rabeda@linux.intel.com>; Wu, Jiaxin > <jiaxin.wu@intel.com>; Fu, > > Siyuan <siyuan.fu@intel.com>; Gao, Liming > <liming.gao@intel.com>; > > Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A > <hao.a.wu@intel.com>; > > Andrew Fish <afish@apple.com>; Ni, Ray > <ray.ni@intel.com>; Lu, XiaoyuX > > <xiaoyux.lu@intel.com>; Ard Biesheuvel > <ard.biesheuvel@arm.com>; Leif > > Lindholm <leif@nuviainc.com> > > Subject: [PATCH 00/15] Add a plugin LicenseCheck in > open ci > > > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2691 > > REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=2833 > > LicenseCheck is now enabled in PatchCheck.py. But > there's a patch > > "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'" > > to suggest revert the change.These patch series > introduce a plugin > > LicenseCheck into open ci so that license issues can > still be checked > > after the checker is disabled in PatchCheck.py. > > 1/15 is the plugin implementation. > > 2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow > developers to > > skip license check for some files like generated > files. > > > > Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can > pass this > > checker. > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Sean Brogan <sean.brogan@microsoft.com> > > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> > > Cc: Eric Dong <eric.dong@intel.com> > > Cc: Laszlo Ersek <lersek@redhat.com> > > Cc: Zhichao Gao <zhichao.gao@intel.com> > > Cc: Jiewen Yao <jiewen.yao@intel.com> > > Cc: Chao Zhang <chao.b.zhang@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> > > Cc: Jiaxin Wu <jiaxin.wu@intel.com> > > Cc: Siyuan Fu <siyuan.fu@intel.com> > > Cc: Liming Gao <liming.gao@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > Cc: Jordan Justen <jordan.l.justen@intel.com> > > Cc: Andrew Fish <afish@apple.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Jian J Wang <jian.j.wang@intel.com> > > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com> > > Cc: Ard Biesheuvel <ard.biesheuvel@arm.com> > > Cc: Leif Lindholm <leif@nuviainc.com> Shenglei Zhang (15): > > .pytool/Plugin: Add a plugin LicenseCheck > > FatPkg/FatPkg.ci.yaml: Add configuration for > LicenseCheck > > ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for > LicenseCheck > > CryptoPkg/CryptoPkg.ci.yaml: Add configuration for > LicenseCheck > > EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration > for LicenseCheck > > FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration > for > > LicenseCheck > > MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration > for > > LicenseCheck > > MdePkg/MdePkg.ci.yaml: Add configuration for > LicenseCheck > > NetworkPkg/NetworkPkg.ci.yaml: Add configuration for > LicenseCheck > > OvmfPkg/OvmfPkg.ci.yaml: Add configuration for > LicenseCheck > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add > configuration for > > LicenseCheck > > SecurityPkg/SecurityPkg.ci.yaml: Add configuration > for LicenseCheck > > ShellPkg/ShellPkg.ci.yaml: Add configuration for > LicenseCheck > > UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for > LicenseCheck > > UnitTestFrameworkPkg: Add configuration for > LicenseCheck in yaml > > file > > > > .pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 > > ++++++++++++++++++ > > .../LicenseCheck/LicenseCheck_plug_in.yaml | 11 > ++ > > .pytool/Plugin/LicenseCheck/Readme.md | 17 > +++ > > ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 + > > CryptoPkg/CryptoPkg.ci.yaml | 3 + > > EmulatorPkg/EmulatorPkg.ci.yaml | 4 + > > FatPkg/FatPkg.ci.yaml | 3 + > > FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 + > > MdeModulePkg/MdeModulePkg.ci.yaml | 4 + > > MdePkg/MdePkg.ci.yaml | 4 + > > NetworkPkg/NetworkPkg.ci.yaml | 3 + > > OvmfPkg/OvmfPkg.ci.yaml | 4 + > > PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 + > > SecurityPkg/SecurityPkg.ci.yaml | 3 + > > ShellPkg/ShellPkg.ci.yaml | 3 + > > UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 + > > .../UnitTestFrameworkPkg.ci.yaml | 4 + > > 17 files changed, 194 insertions(+) create mode 100644 > > .pytool/Plugin/LicenseCheck/LicenseCheck.py > > create mode 100644 > > .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml > > create mode 100644 > > .pytool/Plugin/LicenseCheck/Readme.md > > > > -- > > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63433): https://edk2.groups.io/g/devel/message/63433 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 07/29/20 03:32, Kinney, Michael D wrote: > Hi Liming, > > There are exception to PatchCheck as well for line endings and tabs. > > Seems like a similar problem, and a single CI plugin could > support all these cases. The exceptions for LicenseCheck are individual files that package maintainers (and contributors too) could customize. The primary use case is permitting generated files to have no SPDX tag at all. PatchCheck does not have a customizable exception list; it only considers general rules that apply to the whole tree. I did suggest "@file: generated" as a general marker for generated files (which would opt them out of SPDX enforcement), here: <https://bugzilla.tianocore.org/show_bug.cgi?id=2833#c1>. I'm equally happy with an IgnoreFiles stanza in "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some files under OvmfPkg. What's important to me is that we can control and update the license checks for OvmfPkg/ files with OvmfPkg/ patches. That is, in case we need to tweak the license check for some OvmfPkg/ file, the corresponding patch should need OvmfPkg maintainer approval *only*. Adding exceptions to PatchCheck has been difficult, as (a) it affects all of edk2, (b) technically it needs to pass BaseTools review. With the license check, I'm happy to have the mechanism under BaseTools and/or CI, but the policy should be per package. Again my sole motivation at this time is generated files that we need to check in for whatever reason. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63439): https://edk2.groups.io/g/devel/message/63439 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
> On Jul 29, 2020, at 2:21 AM, Laszlo Ersek <lersek@redhat.com> wrote: > > On 07/29/20 03:32, Kinney, Michael D wrote: >> Hi Liming, >> >> There are exception to PatchCheck as well for line endings and tabs. >> >> Seems like a similar problem, and a single CI plugin could >> support all these cases. > > The exceptions for LicenseCheck are individual files that package > maintainers (and contributors too) could customize. The primary use case > is permitting generated files to have no SPDX tag at all. PatchCheck > does not have a customizable exception list; it only considers general > rules that apply to the whole tree. > > I did suggest "@file: generated" as a general marker for generated files > (which would opt them out of SPDX enforcement), here: > <https://bugzilla.tianocore.org/show_bug.cgi?id=2833#c1>. > This sounds like a good plan for any file generated by the edk2. Thanks, Andrew Fish > I'm equally happy with an IgnoreFiles stanza in > "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some > files under OvmfPkg. What's important to me is that we can control and > update the license checks for OvmfPkg/ files with OvmfPkg/ patches. That > is, in case we need to tweak the license check for some OvmfPkg/ file, > the corresponding patch should need OvmfPkg maintainer approval *only*. > Adding exceptions to PatchCheck has been difficult, as (a) it affects > all of edk2, (b) technically it needs to pass BaseTools review. > > With the license check, I'm happy to have the mechanism under BaseTools > and/or CI, but the policy should be per package. Again my sole > motivation at this time is generated files that we need to check in for > whatever reason. > > Thanks! > Laszlo > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63452): https://edk2.groups.io/g/devel/message/63452 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
-----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Andrew Fish via groups.io Sent: 2020年7月29日 23:22 To: edk2-devel-groups-io <devel@edk2.groups.io>; Laszlo Ersek <lersek@redhat.com> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang, Shenglei <shenglei.zhang@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao Zhang <chao.b.zhang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com> Subject: Re: [edk2-devel] [PATCH 00/15] Add a plugin LicenseCheck in open ci > On Jul 29, 2020, at 2:21 AM, Laszlo Ersek <lersek@redhat.com> wrote: > > On 07/29/20 03:32, Kinney, Michael D wrote: >> Hi Liming, >> >> There are exception to PatchCheck as well for line endings and tabs. >> >> Seems like a similar problem, and a single CI plugin could support >> all these cases. > > The exceptions for LicenseCheck are individual files that package > maintainers (and contributors too) could customize. The primary use > case is permitting generated files to have no SPDX tag at all. > PatchCheck does not have a customizable exception list; it only > considers general rules that apply to the whole tree. > > I did suggest "@file: generated" as a general marker for generated > files (which would opt them out of SPDX enforcement), here: > <https://bugzilla.tianocore.org/show_bug.cgi?id=2833#c1>. > This sounds like a good plan for any file generated by the edk2. [Liming] I agree this is a good suggestion. This requires all generated files to follow this rule. The first step is to enable LicenseCheck plugin (the patch has passed review and ready for merge, https://edk2.groups.io/g/devel/message/63447). Then, package maintainers can add the exception files. Next, we can continue to enhance LicenseCheck. Thanks Liming Thanks, Andrew Fish > I'm equally happy with an IgnoreFiles stanza in > "OvmfPkg/OvmfPkg.ci.yaml", or a marker like "@file: generated" in some > files under OvmfPkg. What's important to me is that we can control and > update the license checks for OvmfPkg/ files with OvmfPkg/ patches. > That is, in case we need to tweak the license check for some OvmfPkg/ > file, the corresponding patch should need OvmfPkg maintainer approval *only*. > Adding exceptions to PatchCheck has been difficult, as (a) it affects > all of edk2, (b) technically it needs to pass BaseTools review. > > With the license check, I'm happy to have the mechanism under > BaseTools and/or CI, but the policy should be per package. Again my > sole motivation at this time is generated files that we need to check > in for whatever reason. > > Thanks! > Laszlo > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63461): https://edk2.groups.io/g/devel/message/63461 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 07/29/20 01:33, Kinney, Michael D wrote: > CI already runs PatchCheck. If we ported PatchCheck to > a CI plugin, then the plugin could perform both the > current PatchCheck features and the license check. > > What this option evaluated? > > If we did provide PatchCheck as a CI plugin, developers > I believe developers could run a stuart command likely > for the NOOPT target to run a PatchCheck CI plugin locally. Not sure if I understand correctly, but I very much like the ability to run PatchCheck without needing anything else than a local Python binary. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63438): https://edk2.groups.io/g/devel/message/63438 Mute This Topic: https://groups.io/mt/75678207/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, Jul 29, 2020 at 11:12:02 +0200, Laszlo Ersek wrote:
> On 07/29/20 01:33, Kinney, Michael D wrote:
> > CI already runs PatchCheck. If we ported PatchCheck to
> > a CI plugin, then the plugin could perform both the
> > current PatchCheck features and the license check.
> >
> > What this option evaluated?
> >
> > If we did provide PatchCheck as a CI plugin, developers
> > I believe developers could run a stuart command likely
> > for the NOOPT target to run a PatchCheck CI plugin locally.
>
> Not sure if I understand correctly, but I very much like the ability to
> run PatchCheck without needing anything else than a local Python binary.
Likewise.
/
Leif
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63445): https://edk2.groups.io/g/devel/message/63445
Mute This Topic: https://groups.io/mt/75678207/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Shenglei:
I have one comment. Seemly, LicenseCheck_plug_in.yaml copyright may be Intel one.
Reviewed-by: Liming Gao <liming.gao@intel.com> for this patch set.
Thanks
Liming
-----Original Message-----
From: Zhang, Shenglei <shenglei.zhang@intel.com>
Sent: 2020年7月20日 16:37
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Dong, Eric <eric.dong@intel.com>; Laszlo Ersek <lersek@redhat.com>; Gao, Zhichao <zhichao.gao@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chao Zhang <chao.b.zhang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Maciej Rabeda <maciej.rabeda@linux.intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Gao, Liming <liming.gao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Andrew Fish <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Ard Biesheuvel <ard.biesheuvel@arm.com>; Leif Lindholm <leif@nuviainc.com>
Subject: [PATCH 00/15] Add a plugin LicenseCheck in open ci
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2691
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2833
LicenseCheck is now enabled in PatchCheck.py. But there's a patch "Revert 'BaseTools/PatchCheck.py: Add LicenseCheck'"
to suggest revert the change.These patch series introduce a plugin LicenseCheck into open ci so that license issues can still be checked after the checker is disabled in PatchCheck.py.
1/15 is the plugin implementation.
2/15 ~ 15/15 introduce sections "IgnoreFiles" to allow developers to skip license check for some files like generated files.
Only BSD-2-Clause-Patent and BSD-3-Clause-Patent can pass this checker.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Siyuan Fu <siyuan.fu@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Shenglei Zhang (15):
.pytool/Plugin: Add a plugin LicenseCheck
FatPkg/FatPkg.ci.yaml: Add configuration for LicenseCheck
ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for LicenseCheck
CryptoPkg/CryptoPkg.ci.yaml: Add configuration for LicenseCheck
EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for LicenseCheck
FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for LicenseCheck
MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for LicenseCheck
MdePkg/MdePkg.ci.yaml: Add configuration for LicenseCheck
NetworkPkg/NetworkPkg.ci.yaml: Add configuration for LicenseCheck
OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for
LicenseCheck
SecurityPkg/SecurityPkg.ci.yaml: Add configuration for LicenseCheck
ShellPkg/ShellPkg.ci.yaml: Add configuration for LicenseCheck
UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for LicenseCheck
UnitTestFrameworkPkg: Add configuration for LicenseCheck in yaml file
.pytool/Plugin/LicenseCheck/LicenseCheck.py | 118 ++++++++++++++++++
.../LicenseCheck/LicenseCheck_plug_in.yaml | 11 ++
.pytool/Plugin/LicenseCheck/Readme.md | 17 +++
ArmVirtPkg/ArmVirtPkg.ci.yaml | 4 +
CryptoPkg/CryptoPkg.ci.yaml | 3 +
EmulatorPkg/EmulatorPkg.ci.yaml | 4 +
FatPkg/FatPkg.ci.yaml | 3 +
FmpDevicePkg/FmpDevicePkg.ci.yaml | 3 +
MdeModulePkg/MdeModulePkg.ci.yaml | 4 +
MdePkg/MdePkg.ci.yaml | 4 +
NetworkPkg/NetworkPkg.ci.yaml | 3 +
OvmfPkg/OvmfPkg.ci.yaml | 4 +
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 3 +
SecurityPkg/SecurityPkg.ci.yaml | 3 +
ShellPkg/ShellPkg.ci.yaml | 3 +
UefiCpuPkg/UefiCpuPkg.ci.yaml | 3 +
.../UnitTestFrameworkPkg.ci.yaml | 4 +
17 files changed, 194 insertions(+)
create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck.py
create mode 100644 .pytool/Plugin/LicenseCheck/LicenseCheck_plug_in.yaml
create mode 100644 .pytool/Plugin/LicenseCheck/Readme.md
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63281): https://edk2.groups.io/g/devel/message/63281
Mute This Topic: https://groups.io/mt/75678207/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.