BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836
Current PatchCheck.py checks each line to ensure line's length is not
larger than 76. But there's a case that length of user's name is much
longer than that number. So enhance the script to handle this case.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
BaseTools/Scripts/PatchCheck.py | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
index 52244b0bc4d8..7db0775d14d1 100755
--- a/BaseTools/Scripts/PatchCheck.py
+++ b/BaseTools/Scripts/PatchCheck.py
@@ -268,7 +268,14 @@ class CommitMessageCheck:
for i in range(2, count):
if (len(lines[i]) >= 76 and
len(lines[i].split()) > 1 and
- not lines[i].startswith('git-svn-id:')):
+ not lines[i].startswith('git-svn-id:') and
+ not lines[i].startswith('Reviewed-by') and
+ not lines[i].startswith('Acked-by:') and
+ not lines[i].startswith('Tested-by:') and
+ not lines[i].startswith('Reported-by:') and
+ not lines[i].startswith('Suggested-by:') and
+ not lines[i].startswith('Signed-off-by:') and
+ not lines[i].startswith('Cc:')):
#
# Print a warning if body line is longer than 75 characters
#
--
2.18.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#62647): https://edk2.groups.io/g/devel/message/62647
Mute This Topic: https://groups.io/mt/75535068/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Bob Feng <bob.c.feng@intel.com> -----Original Message----- From: Zhang, Shenglei <shenglei.zhang@intel.com> Sent: Thursday, July 16, 2020 11:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >= 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters # -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62944): https://edk2.groups.io/g/devel/message/62944 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Shenglei, After you send out the patch for review, please update the Bugzilla status as in-progress and provide the code review link. Thanks, Bob -----Original Message----- From: Zhang, Shenglei <shenglei.zhang@intel.com> Sent: Thursday, July 16, 2020 11:14 AM To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >= 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters # -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62945): https://edk2.groups.io/g/devel/message/62945 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Bob, Code review is for our internal use. Should I append it on Bugzilla? Thanks, Shenglei > -----Original Message----- > From: Feng, Bob C <bob.c.feng@intel.com> > Sent: Tuesday, July 21, 2020 11:39 AM > To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <liming.gao@intel.com> > Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user > name in xxx-by > > Shenglei, > > After you send out the patch for review, please update the Bugzilla status as > in-progress and provide the code review link. > > Thanks, > Bob > > -----Original Message----- > From: Zhang, Shenglei <shenglei.zhang@intel.com> > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name > in xxx-by > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 > Current PatchCheck.py checks each line to ensure line's length is not larger > than 76. But there's a case that length of user's name is much longer than > that number. So enhance the script to handle this case. > > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >= 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 characters > # > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62949): https://edk2.groups.io/g/devel/message/62949 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Shenglei, I mean this link https://edk2.groups.io/g/devel/message/62647 Thanks, Bob -----Original Message----- From: Zhang, Shenglei <shenglei.zhang@intel.com> Sent: Tuesday, July 21, 2020 1:21 PM To: Feng, Bob C <bob.c.feng@intel.com>; devel@edk2.groups.io Cc: Gao, Liming <liming.gao@intel.com> Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Bob, Code review is for our internal use. Should I append it on Bugzilla? Thanks, Shenglei > -----Original Message----- > From: Feng, Bob C <bob.c.feng@intel.com> > Sent: Tuesday, July 21, 2020 11:39 AM > To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <liming.gao@intel.com> > Subject: RE: [PATCH] BaseTools/PatchCheck.py: Skip length check for > user name in xxx-by > > Shenglei, > > After you send out the patch for review, please update the Bugzilla > status as in-progress and provide the code review link. > > Thanks, > Bob > > -----Original Message----- > From: Zhang, Shenglei <shenglei.zhang@intel.com> > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming > <liming.gao@intel.com> > Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user > name in xxx-by > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 > Current PatchCheck.py checks each line to ensure line's length is not > larger than 76. But there's a case that length of user's name is much > longer than that number. So enhance the script to handle this case. > > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >= 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 characters > # > -- > 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62961): https://edk2.groups.io/g/devel/message/62961 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Yuwei Chen<yuwei.chen@intel.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Zhang, > Shenglei > Sent: Thursday, July 16, 2020 11:14 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com> > Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check > for user name in xxx-by > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 > Current PatchCheck.py checks each line to ensure line's length is not larger > than 76. But there's a case that length of user's name is much longer than > that number. So enhance the script to handle this case. > > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Liming Gao <liming.gao@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> > --- > BaseTools/Scripts/PatchCheck.py | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Scripts/PatchCheck.py > b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 > 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -268,7 +268,14 @@ class CommitMessageCheck: > for i in range(2, count): > if (len(lines[i]) >= 76 and > len(lines[i].split()) > 1 and > - not lines[i].startswith('git-svn-id:')): > + not lines[i].startswith('git-svn-id:') and > + not lines[i].startswith('Reviewed-by') and > + not lines[i].startswith('Acked-by:') and > + not lines[i].startswith('Tested-by:') and > + not lines[i].startswith('Reported-by:') and > + not lines[i].startswith('Suggested-by:') and > + not lines[i].startswith('Signed-off-by:') and > + not lines[i].startswith('Cc:')): > # > # Print a warning if body line is longer than 75 characters > # > -- > 2.18.0.windows.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62672): https://edk2.groups.io/g/devel/message/62672 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Liming Gao <liming.gao@intel.com> -----Original Message----- From: Zhang, Shenglei <shenglei.zhang@intel.com> Sent: 2020年7月16日 11:14 To: devel@edk2.groups.io Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com> Subject: [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <liming.gao@intel.com> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >= 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters # -- 2.18.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62653): https://edk2.groups.io/g/devel/message/62653 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.