From nobody Thu May 2 14:59:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62647+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62647+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594869239; cv=none; d=zohomail.com; s=zohoarc; b=ic3sLS10llzqXl2JAooUqmFWR/CQkdChNvFHhyvjf7l2qthC3GI7gutrzO1XuxKQzp4O+Q3mIs+MtN1wAacyZheC46MMa0Y8GFZomvCVLxz8rNtWj5W2Pfst7Bau9G1lfs1ZT68PO1aDknfy0fARSmdWdXnBw8iCGPh6ootG2Lk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594869239; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=Qid143izKdgyunbnV9EKYQMQdBHiLX+ULXWF5Cx5eCU=; b=LNIdV8kkL2ugQQ51tyC8sT0vrM9Gfx3WxnTPwRRulwn9ffyqLE0JreAtYyboxBu8YYF+bFqHY/CqT+fsI+nyqh7E6xa0yq5o9jLb79I4rb9b0h932X3sqlOIAjEL2HxobAiy1LKihIks+LnwggG/nFeVCKC3QVzcluqPPAJb+gk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62647+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594869239837665.4085982317115; Wed, 15 Jul 2020 20:13:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tddwYY1788612xA5il6uO2S8; Wed, 15 Jul 2020 20:13:59 -0700 X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.8106.1594869238701047809 for ; Wed, 15 Jul 2020 20:13:58 -0700 IronPort-SDR: UIdY6nsZRwsYdovow4C3czE1Jc/Ov3AZBETUJsM4hu7Lu/TJsw9BdeaO1k3fG8FuqFpJrBOALo 3q38oWOYbOtA== X-IronPort-AV: E=McAfee;i="6000,8403,9683"; a="137440953" X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="137440953" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2020 20:13:57 -0700 IronPort-SDR: rRNx3GrQkmGZl1OJZ2AB4WGWddNQm/kyvgkrNdVPKaCFc5T9F9yKV1DSvVAFd9X/wxMXvQMbfw SF4t1GjkJZtQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,357,1589266800"; d="scan'208";a="486461367" X-Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by fmsmga005.fm.intel.com with ESMTP; 15 Jul 2020 20:13:56 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Skip length check for user name in xxx-by Date: Thu, 16 Jul 2020 11:13:46 +0800 Message-Id: <20200716031346.40160-1-shenglei.zhang@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,shenglei.zhang@intel.com X-Gm-Message-State: 8JQK3JSbQt0PeqdqD9uOJbl0x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594869239; bh=yu05UJvQSK/d3awlhD66QQA7ZuLHsxtf/UOvD1Vs7n4=; h=Cc:Date:From:Reply-To:Subject:To; b=f0EfQVt9fzFC+38fsC03qhSupBiTsE1i4/hdiIJYxPQP1aZ1fWulzN2avRMcEgXvpOv Jj4Kg2X59QAxBdYKdS2jKbyy5z279CnWHe5zpyrAaCk705NpAs6/PEdWDeaWKCykQA5xs poZfo/yc2n63rDC6grupsWpjSztyylYV3aE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2836 Current PatchCheck.py checks each line to ensure line's length is not larger than 76. But there's a case that length of user's name is much longer than that number. So enhance the script to handle this case. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang Reviewed-by: Bob Feng Reviewed-by: Liming Gao Reviewed-by: Yuwei Chen --- BaseTools/Scripts/PatchCheck.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 52244b0bc4d8..7db0775d14d1 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -268,7 +268,14 @@ class CommitMessageCheck: for i in range(2, count): if (len(lines[i]) >=3D 76 and len(lines[i].split()) > 1 and - not lines[i].startswith('git-svn-id:')): + not lines[i].startswith('git-svn-id:') and + not lines[i].startswith('Reviewed-by') and + not lines[i].startswith('Acked-by:') and + not lines[i].startswith('Tested-by:') and + not lines[i].startswith('Reported-by:') and + not lines[i].startswith('Suggested-by:') and + not lines[i].startswith('Signed-off-by:') and + not lines[i].startswith('Cc:')): # # Print a warning if body line is longer than 75 characters # --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62647): https://edk2.groups.io/g/devel/message/62647 Mute This Topic: https://groups.io/mt/75535068/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-