SecurityPkg/TcgStorageOpalLib: Fix retval of OpalGetFeatureDescriptor

[edk2-devel] [PATCH] SecurityPkg/TcgStorageOpalLib: Fix retval of OpalGetFeatureDescriptor

Gao, Zhichao posted 1 patch 3 years, 9 months ago

Download mbox

Failed in applying to current master (apply log)

SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[edk2-devel] [PATCH] SecurityPkg/TcgStorageOpalLib: Fix retval of OpalGetFeatureDescriptor

Posted by Gao, Zhichao 3 years, 9 months ago

From: Baranee <anbazhagan@hp.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2597

OpalGetFeatureDescriptor doesn't return failure if requested
FeatureCode is not supported.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
index b58597e61f..873ca1909b 100644
--- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
+++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c
@@ -1892,9 +1892,10 @@ OpalGetFeatureDescriptor (
 
     *DataSize = Size;
     CopyMem (Data, Feat, Size);
+    return TcgResultSuccess;
   }
 
-  return TcgResultSuccess;
+  return TcgResultFailure;
 }
 
 /**
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#62275): https://edk2.groups.io/g/devel/message/62275
Mute This Topic: https://groups.io/mt/75390679/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-