From nobody Tue May 7 14:07:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62275+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62275+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594262323; cv=none; d=zohomail.com; s=zohoarc; b=dM7r9T6zdHSSzg5EWh6EDztkm2zCM1ZzKNAHygtZO1k4w1EXVsfk6uuP28mBQnklYD3nHjbiO6yyTzd/GjiNa0Nw+dWrlikeyPZOwufVs+Hg1ZeEr4S9fUqfS9vIEBuc+sWRxzYFY8+iJguVfVZNmyrr/q5L99eDXd5i8SHTyPo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594262323; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=u1AEXS9ELbWPYICQwzo0PuUP/eIM3AqrtN7Jlq8md7s=; b=AKSB2L73Eb3ci4l6W7uRqY18T9/GM2e0WoIX1SIHDGPc8jsDmK58rGJr/GGPW8FqnmI9vbj/+6ldO66r7ttrgDR1uKXNBPc0tVr5bNDKiyZb32rxblCoMHy98NqZSad8EFP+oqfkhXaZyUkd+gIxbSZOp1H1NLt5OTpLCoyRuCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62275+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 159426232384536.43652230115697; Wed, 8 Jul 2020 19:38:43 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qdNgYY1788612xx33oFVaJu0; Wed, 08 Jul 2020 19:38:43 -0700 X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.3340.1594262322469193827 for ; Wed, 08 Jul 2020 19:38:42 -0700 IronPort-SDR: P0TSIX+7Q8r8AULpw7tMwy7o38vAa3jAc3vZqlxUQpV+sV28RRyvF5LwL+W8CCNtfHXhKPUpqi jnhUGW+6eTlw== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="136160309" X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="136160309" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 19:38:36 -0700 IronPort-SDR: XP6AOC00GQL9kfcDcrP72mebZoTBFbg2/UNOXaray/T17kZoKOOlBKzEduaIK9PPquKxwwSvXl pp/lYrDVdgWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="283990834" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.114]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2020 19:38:35 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Baranee , Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH] SecurityPkg/TcgStorageOpalLib: Fix retval of OpalGetFeatureDescriptor Date: Thu, 9 Jul 2020 10:38:18 +0800 Message-Id: <20200709023818.26408-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: 3EM5bmfrgbG5y8H7PoUGRpDex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594262323; bh=we4ILdzHZnZheATioWlXDpasE/Xz0V9QxXpUtYRWqQU=; h=Cc:Date:From:Reply-To:Subject:To; b=UKh8mAPUnioc6t8Ka12ZtJqF5tAF2uCZ8B6qgkxA88IO7k+LwaK1IYSAGscOvR6QyBQ mud5YVvdHjCBK+uXguCRoESEMv4lLItNTbxH3raDwtJFfrlxX7EGtQaJXa5fXQcr/BjPj 71e/zj9EUmmNd/3neNeOkHFstx6sZZLeBuA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Baranee REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2597 OpalGetFeatureDescriptor doesn't return failure if requested FeatureCode is not supported. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Zhichao Gao --- SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c b/S= ecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c index b58597e61f..873ca1909b 100644 --- a/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c +++ b/SecurityPkg/Library/TcgStorageOpalLib/TcgStorageOpalCore.c @@ -1892,9 +1892,10 @@ OpalGetFeatureDescriptor ( =20 *DataSize =3D Size; CopyMem (Data, Feat, Size); + return TcgResultSuccess; } =20 - return TcgResultSuccess; + return TcgResultFailure; } =20 /** --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62275): https://edk2.groups.io/g/devel/message/62275 Mute This Topic: https://groups.io/mt/75390679/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-