[v1] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

Jiang, Guomin posted 1 patch 4 years, 1 month ago

Diff against v1 v1 v1 v1
Download mbox

Failed in applying to current master (apply log)

There is a newer version of this series

.../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c       | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR

Posted by Jiang, Guomin 4 years, 1 month ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2589

According to code logic, it just judge the condition rather than the
status, it should use the ASSERT rather than ASSERT_EFI_ERROR.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
Signed-off-by: Guomin Jiang <guomin.jiang@intel.com>
---
 .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
index 29b6916f61..aa2bf14fa8 100644
--- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
+++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c
@@ -69,7 +69,7 @@ RecordPciDeviceInList(
   ASSERT_EFI_ERROR(Status);
 
   NewPciDevice = AllocateZeroPool(sizeof(*NewPciDevice));
-  ASSERT_EFI_ERROR(NewPciDevice != NULL);
+  ASSERT(NewPciDevice != NULL);
 
   NewPciDevice->Signature   = PCI_DEVICE_INSTANCE_SIGNATURE;
   NewPciDevice->PciSegment  = PciSegment;
-- 
2.25.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55969): https://edk2.groups.io/g/devel/message/55969
Mute This Topic: https://groups.io/mt/72044540/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-