From nobody Thu May 2 17:44:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55969+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55969+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584571856; cv=none; d=zohomail.com; s=zohoarc; b=kld5TwEf4EOHuNMNTxS94BGYGQVZaaVB2uvsskIvZD463QAPYnvt5hk0Fg56R/U9SYEU52DhU82yJmqbmFO6qJJ4bwDUnEc4CatvaXo7TG95UUky+mQbCWIb7A3T35+jDe0ni+oXjyIIveYV/TPjmS1r5J5m/2iGDZWRG8L4R58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584571856; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=bLhM49ulgSaKgTzB7OZmJeskArN5rQSF9WRkHPaP1WQ=; b=BO87FFVjpc5jhu1N7jf49LaUsp8Jmb2QJ3JO3bJNfrkBcDvrvcuZcTw4BnikZNZgJVd+3rXtXQM88N7UWnuGZBzMly5jKHgBN4acBI4IEkMRHwdjynrRseBRWpaaseaJJrS2bf5YmpOyYJXgP4zIPzZS1W8PDMUkWRt5MlQaZCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55969+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584571856825723.8405615922162; Wed, 18 Mar 2020 15:50:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id OzZgYY1788612xDOxwfKV5NP; Wed, 18 Mar 2020 15:50:56 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.9877.1584514141809764468 for ; Tue, 17 Mar 2020 23:49:02 -0700 IronPort-SDR: clwECLm0f9yrZC51xMAWFEfISgQA/9R56Vsy/S2IfuB3AeVAGg0SizBDxv9QtWj7wyV2KWEgiS vyR0XbAVzRVw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 23:49:01 -0700 IronPort-SDR: bZaKt3SUGdIYMsEKaOiIe1yUKLwihMYVp5LOsOfj8ANPVdBh953OFztmPpC0m/SPZ1VezkmzXf nDO/B1eu3tTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="444063600" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga005.fm.intel.com with ESMTP; 17 Mar 2020 23:48:59 -0700 From: "Jiang, Guomin" To: devel@edk2.groups.io Cc: Guomin Jiang , Ray Ni , Rangasai V Chaganty Subject: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Date: Wed, 18 Mar 2020 14:47:42 +0800 Message-Id: <20200318064742.910-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: lhZ4y4SPo93oAEV3ZxuFQEWsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584571856; bh=5jVKwc0zcg93xEKKa+o1T9FZx09AaqIQMJr+HqNoslI=; h=Cc:Date:From:Reply-To:Subject:To; b=lKY9ynr3XQ8Eg6ijD9H+bHQSFXvDF6f/jTIdjlZ/zEa+iqTUwyfosELX3ie9mdaj3TO vowmFJAwJ0Fx1CfDo4Br6PGUvsm0VPuuLtb84k5pANgKCtYUWdFck10M/76CIaiusFEjF 3BNxb1WwBPcSH1NpcWBpQpPtTWutJfxgR1I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); =20 NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); =20 NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55969): https://edk2.groups.io/g/devel/message/55969 Mute This Topic: https://groups.io/mt/72044540/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-