[edk2-devel] [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

Gao, Zhichao posted 1 patch 1 week ago
Failed in applying to current master (apply log)
MdePkg/Include/IndustryStandard/SmBios.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

[edk2-devel] [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

Posted by Gao, Zhichao 1 week ago
From: Matthew Carlson <macarl@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482

Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
for type 17. One is "Extended Speed", the other is "Extended
Configured Memory Speed". The lack of these field may cause strange
error i some operating systems.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 MdePkg/Include/IndustryStandard/SmBios.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 8b3c4d7ba9..b5401599db 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1,7 +1,7 @@
 /** @file
   Industry Standard Definitions of SMBIOS Table Specification v3.3.0.
 
-Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
 (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
 (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -1843,6 +1843,11 @@ typedef struct {
   UINT64                                    VolatileSize;
   UINT64                                    CacheSize;
   UINT64                                    LogicalSize;
+  //
+  // Add for smbios 3.3.0
+  //
+  UINT32                                    ExtendedSpeed;
+  UINT32                                    ExtendedConfiguredMemorySpeed;
 } SMBIOS_TABLE_TYPE17;
 
 ///
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53999): https://edk2.groups.io/g/devel/message/53999
Mute This Topic: https://groups.io/mt/71045349/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

Posted by Liming Gao 1 week ago
Zhichao:
  Two comments. 

Thanks
Liming
> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Friday, February 7, 2020 2:07 PM
> To: devel@edk2.groups.io
> Cc: Matthew Carlson <macarl@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
> 
> From: Matthew Carlson <macarl@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482
> 
> Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
> for type 17. One is "Extended Speed", the other is "Extended
> Configured Memory Speed". The lack of these field may cause strange
> error i some operating systems.
Seemly, this is typo. It should be in some operating systems

> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  MdePkg/Include/IndustryStandard/SmBios.h | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index 8b3c4d7ba9..b5401599db 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1,7 +1,7 @@
>  /** @file
>    Industry Standard Definitions of SMBIOS Table Specification v3.3.0.
> 
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.<BR>
Don't change copyright. Original patch doesn't touch it. 

Thanks
Liming
>  (C) Copyright 2015-2017 Hewlett Packard Enterprise Development LP<BR>
>  (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development LP<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -1843,6 +1843,11 @@ typedef struct {
>    UINT64                                    VolatileSize;
>    UINT64                                    CacheSize;
>    UINT64                                    LogicalSize;
> +  //
> +  // Add for smbios 3.3.0
> +  //
> +  UINT32                                    ExtendedSpeed;
> +  UINT32                                    ExtendedConfiguredMemorySpeed;
>  } SMBIOS_TABLE_TYPE17;
> 
>  ///
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54000): https://edk2.groups.io/g/devel/message/54000
Mute This Topic: https://groups.io/mt/71045349/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-