[edk2-devel] [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17

Gao, Zhichao posted 1 patch 4 years, 1 month ago
Failed in applying to current master (apply log)
MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
1 file changed, 5 insertions(+)
[edk2-devel] [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
Posted by Gao, Zhichao 4 years, 1 month ago
From: Matthew Carlson <macarl@microsoft.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482

Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
for type 17. One is "Extended Speed", the other is "Extended
Configured Memory Speed". The lack of these field may cause strange
error in some operating systems.

Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
V2:

1. fix some typo.
2. Do not update the copyright.

 MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
index 8b3c4d7ba9..def874be28 100644
--- a/MdePkg/Include/IndustryStandard/SmBios.h
+++ b/MdePkg/Include/IndustryStandard/SmBios.h
@@ -1843,6 +1843,11 @@ typedef struct {
   UINT64                                    VolatileSize;
   UINT64                                    CacheSize;
   UINT64                                    LogicalSize;
+  //
+  // Add for smbios 3.3.0
+  //
+  UINT32                                    ExtendedSpeed;
+  UINT32                                    ExtendedConfiguredMemorySpeed;
 } SMBIOS_TABLE_TYPE17;
 
 ///
-- 
2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54028): https://edk2.groups.io/g/devel/message/54028
Mute This Topic: https://groups.io/mt/71047467/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
Posted by Liming Gao 4 years, 1 month ago
Reviewed-by: Liming Gao <liming.gao@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Friday, February 7, 2020 4:37 PM
> To: devel@edk2.groups.io
> Cc: Matthew Carlson <macarl@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH V2] MdePkg/SmBios.h: Add two additional DWORD for smbios 3.3.0 type17
> 
> From: Matthew Carlson <macarl@microsoft.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2482
> 
> Refer to DSP0134_3.3.0.pdf, there are two additional DWORD added
> for type 17. One is "Extended Speed", the other is "Extended
> Configured Memory Speed". The lack of these field may cause strange
> error in some operating systems.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
> V2:
> 
> 1. fix some typo.
> 2. Do not update the copyright.
> 
>  MdePkg/Include/IndustryStandard/SmBios.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/SmBios.h b/MdePkg/Include/IndustryStandard/SmBios.h
> index 8b3c4d7ba9..def874be28 100644
> --- a/MdePkg/Include/IndustryStandard/SmBios.h
> +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> @@ -1843,6 +1843,11 @@ typedef struct {
>    UINT64                                    VolatileSize;
>    UINT64                                    CacheSize;
>    UINT64                                    LogicalSize;
> +  //
> +  // Add for smbios 3.3.0
> +  //
> +  UINT32                                    ExtendedSpeed;
> +  UINT32                                    ExtendedConfiguredMemorySpeed;
>  } SMBIOS_TABLE_TYPE17;
> 
>  ///
> --
> 2.16.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54032): https://edk2.groups.io/g/devel/message/54032
Mute This Topic: https://groups.io/mt/71047467/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-