[edk2-devel] [PATCH 0/2] some ARM fixes

Ard Biesheuvel posted 2 patches 2 weeks ago
Failed in applying to current master (apply log)
ArmPkg/ArmPkg.dec                                                    |  4 --
ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 -----
ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                       |  1 +
ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                      |  1 +
ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c   | 66 +-------------------
ArmPlatformPkg/PrePeiCore/PrePeiCore.c                               |  5 ++
ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S              | 24 -------
ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm            | 29 ---------
ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S                  | 23 -------
ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm                | 28 ---------
10 files changed, 9 insertions(+), 189 deletions(-)
delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S
delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm

[edk2-devel] [PATCH 0/2] some ARM fixes

Posted by Ard Biesheuvel 2 weeks ago
Some preparatory fixes for TPM measured boot on ARM systems.

Patch #1 removes EnterS3WithImmediateWake() with the associated support
code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
longer being called anywhere, and will be removed from ResetSystemLib,
and the support code dependencies on DXE facilities are preventing this
library from being used in the PEI phase, which is needed for TPM support.

Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms.
This is causing TPM crypto code to blow up.

Ard Biesheuvel (2):
  ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake ()
  ArmPlatformPkg/PrePeiCore: enable VFP at startup

 ArmPkg/ArmPkg.dec                                                    |  4 --
 ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 -----
 ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                       |  1 +
 ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                      |  1 +
 ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c   | 66 +-------------------
 ArmPlatformPkg/PrePeiCore/PrePeiCore.c                               |  5 ++
 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S              | 24 -------
 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm            | 29 ---------
 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S                  | 23 -------
 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm                | 28 ---------
 10 files changed, 9 insertions(+), 189 deletions(-)
 delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
 delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
 delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S
 delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm

-- 
2.20.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#52966): https://edk2.groups.io/g/devel/message/52966
Mute This Topic: https://groups.io/mt/69498789/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] some ARM fixes

Posted by Ard Biesheuvel 6 days ago
On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> Some preparatory fixes for TPM measured boot on ARM systems.
>
> Patch #1 removes EnterS3WithImmediateWake() with the associated support
> code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
> longer being called anywhere, and will be removed from ResetSystemLib,
> and the support code dependencies on DXE facilities are preventing this
> library from being used in the PEI phase, which is needed for TPM support.
>
> Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms.
> This is causing TPM crypto code to blow up.
>
> Ard Biesheuvel (2):
>   ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake ()
>   ArmPlatformPkg/PrePeiCore: enable VFP at startup
>

Ping?


>  ArmPkg/ArmPkg.dec                                                    |  4 --
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 -----
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                       |  1 +
>  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                      |  1 +
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c   | 66 +-------------------
>  ArmPlatformPkg/PrePeiCore/PrePeiCore.c                               |  5 ++
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S              | 24 -------
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm            | 29 ---------
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S                  | 23 -------
>  ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm                | 28 ---------
>  10 files changed, 9 insertions(+), 189 deletions(-)
>  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
>  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
>  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S
>  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm
>
> --
> 2.20.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53230): https://edk2.groups.io/g/devel/message/53230
Mute This Topic: https://groups.io/mt/69498789/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/2] some ARM fixes

Posted by Ard Biesheuvel 6 days ago
On Tue, 14 Jan 2020 at 17:43, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> >
> > Some preparatory fixes for TPM measured boot on ARM systems.
> >
> > Patch #1 removes EnterS3WithImmediateWake() with the associated support
> > code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no
> > longer being called anywhere, and will be removed from ResetSystemLib,
> > and the support code dependencies on DXE facilities are preventing this
> > library from being used in the PEI phase, which is needed for TPM support.
> >
> > Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms.
> > This is causing TPM crypto code to blow up.
> >
> > Ard Biesheuvel (2):
> >   ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake ()
> >   ArmPlatformPkg/PrePeiCore: enable VFP at startup
> >
>
> Ping?
>

Merged, thanks.

>
> >  ArmPkg/ArmPkg.dec                                                    |  4 --
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 -----
> >  ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf                       |  1 +
> >  ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf                      |  1 +
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c   | 66 +-------------------
> >  ArmPlatformPkg/PrePeiCore/PrePeiCore.c                               |  5 ++
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S              | 24 -------
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm            | 29 ---------
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S                  | 23 -------
> >  ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm                | 28 ---------
> >  10 files changed, 9 insertions(+), 189 deletions(-)
> >  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S
> >  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm
> >  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S
> >  delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm
> >
> > --
> > 2.20.1
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53248): https://edk2.groups.io/g/devel/message/53248
Mute This Topic: https://groups.io/mt/69498789/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-