From nobody Wed Apr 24 07:16:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52967+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52967+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1578388945; cv=none; d=zohomail.com; s=zohoarc; b=C7GTGyqnnSf8sPAsZrqDtKw1JLmpI9qszd4QAcvwD4S9pzg3NvyGWxsrLRmj9IHHhNrxSKreOHvv9hLxJa10BBORN3Zj90EtbTC+nEo4grW+nHjG8gvTKET8CYJ0frPjPu+Hdu+cAFtvx1Ee6C8KVj6oYFsmiDslBMIpB9CW2jk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578388945; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=e7/gCESo/A1GKU7I4Oy0zYoZ5mfykuyKjxZuFcvjYkI=; b=BNYumuOZ7mhnugrrIZBBUeH05h51b44/iAtYfxDSO1RU5yYtizLhxezXNxvkHQQeNI322W3eMPbpBrK4AVGMA6FaAQYOc/H6zYrSFpYmajPbRvZTPb6RkY29ekbx9xpazFNC6z4vtw25ojK8YHFKHfX9GbEYjipCGHtykFgNnwE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52967+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1578388945846657.7762347473439; Tue, 7 Jan 2020 01:22:25 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id vMZYYY1788612xSd3QCXciD3; Tue, 07 Jan 2020 01:22:24 -0800 X-Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web09.3482.1578388944179527884 for ; Tue, 07 Jan 2020 01:22:24 -0800 X-Received: by mail-wr1-f68.google.com with SMTP id b6so53110193wrq.0 for ; Tue, 07 Jan 2020 01:22:23 -0800 (PST) X-Gm-Message-State: KhwfklrNzkvzzSGmK2mtiZdhx1787277AA= X-Google-Smtp-Source: APXvYqynGnN9Lf5pcdcxrykdlhzhkfvlp1H6VediNC7TJqSFq1rspdOzIPCvU5GcNmkm53k4r7MVSA== X-Received: by 2002:a5d:55d1:: with SMTP id i17mr105360525wrw.165.1578388942212; Tue, 07 Jan 2020 01:22:22 -0800 (PST) X-Received: from localhost.localdomain ([2a01:cb1d:112:6f00:cc7e:d2b6:8b0c:cb36]) by smtp.gmail.com with ESMTPSA id h66sm27445476wme.41.2020.01.07.01.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 01:22:20 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, Ard Biesheuvel Subject: [edk2-devel] [PATCH 1/2] ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake () Date: Tue, 7 Jan 2020 10:22:14 +0100 Message-Id: <20200107092215.3271-2-ard.biesheuvel@linaro.org> In-Reply-To: <20200107092215.3271-1-ard.biesheuvel@linaro.org> References: <20200107092215.3271-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578388944; bh=zINDv90N3Kd9jiBmgktmYN5Ca257h4Xcm+R5swvdSbo=; h=Cc:Date:From:Reply-To:Subject:To; b=nFdD6MySWftETMgU0O3JFi4VSYrqYwNYvFwgeP6G+bYgRLiOI1OGZ+IcdWN7I1lQRvN qfaDcN2uTzratgpPIluKF8JZPbmQSSlgU5JbTnWwkh0paKFAXaaVoxcF9W3bKWY0oD3w4 5kfNF9l4TBD2t/1d+p4ncmbR9sWMJtBiwBk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" EnterS3WithImmediateWake () no longer has any callers, so remove it from ResetSystemLib. Note that this means the hack to support warm reboot by jumping to the SEC entry point with the MMU and caches off is also no longer used, and can be removed as well, along with the PCD PcdArmReenterPeiForCapsuleWarmReboot that was introduced for this purpose. Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.dec | 4 = -- ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 = ----- ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 66 = +------------------- ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S | 24 = ------- ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm | 29 = --------- ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S | 23 = ------- ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm | 28 = --------- 7 files changed, 2 insertions(+), 189 deletions(-) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index 39ff339c956d..eaf1072d9ef3 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -78,10 +78,6 @@ [PcdsFeatureFlag.common] # Define if the GICv3 controller should use the GICv2 legacy gArmTokenSpaceGuid.PcdArmGicV3WithV2Legacy|FALSE|BOOLEAN|0x00000042 =20 - # Whether to implement warm reboot for capsule update using a jump back = to the - # PEI entry point with caches and interrupts disabled. - gArmTokenSpaceGuid.PcdArmReenterPeiForCapsuleWarmReboot|FALSE|BOOLEAN|0x= 0000001F - [PcdsFeatureFlag.ARM] # Whether to map normal memory as non-shareable. FALSE is the safe choic= e, but # TRUE may be appropriate to fix performance problems if you don't care = about diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemL= ib.inf b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.i= nf index fa19bf649131..c17b28cfac79 100644 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf +++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf @@ -15,14 +15,6 @@ [Defines] VERSION_STRING =3D 1.0 LIBRARY_CLASS =3D ResetSystemLib =20 -[Sources.AARCH64] - AArch64/Reset.S | GCC - AArch64/Reset.asm | MSFT - -[Sources.ARM] - Arm/Reset.S | GCC - Arm/Reset.asm | RVCT - [Sources] ArmSmcPsciResetSystemLib.c =20 @@ -32,15 +24,6 @@ [Packages] MdePkg/MdePkg.dec =20 [LibraryClasses] - ArmMmuLib ArmSmcLib BaseLib DebugLib - UefiBootServicesTableLib - UefiRuntimeLib - -[FeaturePcd] - gArmTokenSpaceGuid.PcdArmReenterPeiForCapsuleWarmReboot - -[FixedPcd] - gArmTokenSpaceGuid.PcdFvBaseAddress diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemL= ib.c b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c index b2dde9bfc13a..22fcf989e903 100644 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c +++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c @@ -10,13 +10,10 @@ =20 #include =20 -#include -#include #include #include #include -#include -#include +#include =20 #include =20 @@ -76,8 +73,6 @@ ResetShutdown ( ArmCallSmc (&ArmSmcArgs); } =20 -VOID DisableMmuAndReenterPei (VOID); - /** This function causes the system to enter S3 and then wake up immediately. =20 @@ -89,64 +84,7 @@ EnterS3WithImmediateWake ( VOID ) { - EFI_PHYSICAL_ADDRESS Alloc; - EFI_MEMORY_DESCRIPTOR *MemMap; - UINTN MemMapSize; - UINTN MapKey, DescriptorSize; - UINT32 DescriptorVersion; - EFI_STATUS Status; - - if (FeaturePcdGet (PcdArmReenterPeiForCapsuleWarmReboot) && - !EfiAtRuntime ()) { - // - // At boot time, we are the only core running, so we can implement the - // immediate wake (which is used by capsule update) by disabling the M= MU - // and interrupts, and jumping to the PEI entry point. - // - - // - // Obtain the size of the memory map - // - MemMapSize =3D 0; - MemMap =3D NULL; - Status =3D gBS->GetMemoryMap (&MemMapSize, MemMap, &MapKey, &Descripto= rSize, - &DescriptorVersion); - ASSERT (Status =3D=3D EFI_BUFFER_TOO_SMALL); - - // - // Add some slack to the allocation to cater for changes in the memory - // map if ExitBootServices () fails the first time around. - // - MemMapSize +=3D SIZE_4KB; - Status =3D gBS->AllocatePages (AllocateAnyPages, EfiBootServicesData, - EFI_SIZE_TO_PAGES (MemMapSize), &Alloc); - ASSERT_EFI_ERROR (Status); - - MemMap =3D (EFI_MEMORY_DESCRIPTOR *)(UINTN)Alloc; - - Status =3D gBS->GetMemoryMap (&MemMapSize, MemMap, &MapKey, &Descripto= rSize, - &DescriptorVersion); - ASSERT_EFI_ERROR (Status); - - Status =3D gBS->ExitBootServices (gImageHandle, MapKey); - if (EFI_ERROR (Status)) { - // - // ExitBootServices () may fail the first time around if an event fi= red - // right after the call to GetMemoryMap() which allocated or freed m= emory. - // Since that first call to ExitBootServices () will disarm the time= r, - // this is guaranteed not to happen again, so one additional attempt - // should suffice. - // - Status =3D gBS->GetMemoryMap (&MemMapSize, MemMap, &MapKey, &Descrip= torSize, - &DescriptorVersion); - ASSERT_EFI_ERROR (Status); - - Status =3D gBS->ExitBootServices (gImageHandle, MapKey); - ASSERT_EFI_ERROR (Status); - } - - DisableMmuAndReenterPei (); - } + // Not implemented } =20 /** diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S b/ArmP= kg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S deleted file mode 100644 index d0d908b7d70d..000000000000 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S +++ /dev/null @@ -1,24 +0,0 @@ -/** @file - ResetSystemLib implementation using PSCI calls - - Copyright (c) 2018, Linaro Ltd. All rights reserved.
- - SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#include - -ASM_FUNC(DisableMmuAndReenterPei) - stp x29, x30, [sp, #-16]! - mov x29, sp - - bl ArmDisableMmu - - // no memory accesses after MMU and caches have been disabled - - MOV64 (x0, FixedPcdGet64 (PcdFvBaseAddress)) - blr x0 - - // never returns - nop diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm b/Ar= mPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm deleted file mode 100644 index 752df072511b..000000000000 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm +++ /dev/null @@ -1,29 +0,0 @@ -;/** @file -; ResetSystemLib implementation using PSCI calls -; -; Copyright (c) 2018, Linaro Ltd. All rights reserved.
-; -; SPDX-License-Identifier: BSD-2-Clause-Patent -; -;**/ - - AREA Reset, CODE, READONLY - - EXPORT DisableMmuAndReenterPei - IMPORT ArmDisableMmu - -DisableMmuAndReenterPei - stp x29, x30, [sp, #-16]! - mov x29, sp - - bl ArmDisableMmu - - ; no memory accesses after MMU and caches have been disabled - - movl x0, FixedPcdGet64 (PcdFvBaseAddress) - blr x0 - - ; never returns - nop - - END diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S b/ArmPkg/L= ibrary/ArmSmcPsciResetSystemLib/Arm/Reset.S deleted file mode 100644 index c0c5bcf19723..000000000000 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S +++ /dev/null @@ -1,23 +0,0 @@ -/** @file - ResetSystemLib implementation using PSCI calls - - Copyright (c) 2018, Linaro Ltd. All rights reserved.
- - SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#include - -ASM_FUNC(DisableMmuAndReenterPei) - push {lr} - - bl ArmDisableMmu - - // no memory accesses after MMU and caches have been disabled - - MOV32 (r0, FixedPcdGet64 (PcdFvBaseAddress)) - blx r0 - - // never returns - nop diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm b/ArmPkg= /Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm deleted file mode 100644 index ab7519a5a926..000000000000 --- a/ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm +++ /dev/null @@ -1,28 +0,0 @@ -;/** @file -; ResetSystemLib implementation using PSCI calls -; -; Copyright (c) 2018, Linaro Ltd. All rights reserved.
-; -; SPDX-License-Identifier: BSD-2-Clause-Patent -; -;**/ - - INCLUDE AsmMacroExport.inc - PRESERVE8 - - IMPORT ArmDisableMmu - -RVCT_ASM_EXPORT DisableMmuAndReenterPei - push {lr} - - bl ArmDisableMmu - - ; no memory accesses after MMU and caches have been disabled - - mov32 r0, FixedPcdGet64 (PcdFvBaseAddress) - blx r0 - - ; never returns - nop - - END --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52967): https://edk2.groups.io/g/devel/message/52967 Mute This Topic: https://groups.io/mt/69498790/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed Apr 24 07:16:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+52968+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52968+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1578388946; cv=none; d=zohomail.com; s=zohoarc; b=e6ofFJZWbzryYDAxZzkXtXo1Kz+mmhiBIzVJqPNxtngVG6g3PZ/IFC8Ban0WVTAO0FGWQB4sB+LvxtHazO/MgVTDRlMOp/VHWSMQkBWbTuxS7+t8UHoC2OpAvrevf5AqIFBY6SEJCF/HGkqX4sgqcddguMuiOpNRCjLy/j7Vso4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1578388946; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ooyfM0xE6u4/ZK+EZPFa6VRtldacobo7TrqA8I6R0Mg=; b=IWzR07Wt4F2Zmbwb90UX5bbbVrzxSVl0jT4AQBi4795Oi52DlHtRaxk7oWKanzssB+hoSXOuHBsgOIj6xFikipQp6K0mCaGpNzLN60nvVBG1JUk1yECJvFbHQ1BfnKHI2FraY9J6An+oZnTf7GX8RU9+EmwrNkufqA/h1kYxymI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+52968+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 157838894661590.2879725066341; Tue, 7 Jan 2020 01:22:26 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id yeJJYY1788612x6nsgtFYfOS; Tue, 07 Jan 2020 01:22:25 -0800 X-Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.3576.1578388944916976593 for ; Tue, 07 Jan 2020 01:22:25 -0800 X-Received: by mail-wm1-f66.google.com with SMTP id a5so18120793wmb.0 for ; Tue, 07 Jan 2020 01:22:24 -0800 (PST) X-Gm-Message-State: LeGClaJheVjOTIff1Jp9oonTx1787277AA= X-Google-Smtp-Source: APXvYqwySLWJb/EDjU5hfjXWEHtiMhSdjQRwYJp07Y1avZYKkbxBBvC65CHH5+wclaQSnqnek0UkSg== X-Received: by 2002:a05:600c:d6:: with SMTP id u22mr40853980wmm.77.1578388943186; Tue, 07 Jan 2020 01:22:23 -0800 (PST) X-Received: from localhost.localdomain ([2a01:cb1d:112:6f00:cc7e:d2b6:8b0c:cb36]) by smtp.gmail.com with ESMTPSA id h66sm27445476wme.41.2020.01.07.01.22.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 01:22:22 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, Ard Biesheuvel Subject: [edk2-devel] [PATCH 2/2] ArmPlatformPkg/PrePeiCore: enable VFP at startup Date: Tue, 7 Jan 2020 10:22:15 +0100 Message-Id: <20200107092215.3271-3-ard.biesheuvel@linaro.org> In-Reply-To: <20200107092215.3271-1-ard.biesheuvel@linaro.org> References: <20200107092215.3271-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1578388945; bh=kXnSdC5AkBbva6XyNTjsqqA5hUJQWKxx52JhXUcfPYM=; h=Cc:Date:From:Reply-To:Subject:To; b=hPZ1xjO7JGkFYphxKwrAj0H6vbcShay/nfKspNHwcuUEx/rFsIbjkBkuoaUPTlRRhWi rch8rHwjR/FIaBHS0bEFcrvmZEDHNhxHXjTiQKgooidLdoP419sLcixg7nkyCWoHLJGI9 l+yjA53Jd1ibljrh7QCbaR4NweinahqmZiE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" While the alternative PEI-less SEC implementation in PrePi already takes the EnableVFP PCD into account, the PrePeiCore code does not, and so we may end up triggering synchronous exception when code attempts to use FP or SIMD registers, which is permitted by the spec. So enable the VFP as early as feasible. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 + ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 + ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 5 +++++ 3 files changed, 7 insertions(+) diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf b/ArmPlatformPk= g/PrePeiCore/PrePeiCoreMPCore.inf index f2ac45d171bc..104c7da53317 100644 --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf @@ -62,6 +62,7 @@ [FeaturePcd] [FixedPcd] gArmTokenSpaceGuid.PcdFvBaseAddress gArmTokenSpaceGuid.PcdFvSize + gArmTokenSpaceGuid.PcdVFPEnabled =20 gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf b/ArmPlatformP= kg/PrePeiCore/PrePeiCoreUniCore.inf index 84c319c3679b..ceb173d34f5d 100644 --- a/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf @@ -60,6 +60,7 @@ [FeaturePcd] [FixedPcd] gArmTokenSpaceGuid.PcdFvBaseAddress gArmTokenSpaceGuid.PcdFvSize + gArmTokenSpaceGuid.PcdVFPEnabled =20 gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase gArmPlatformTokenSpaceGuid.PcdCPUCorePrimaryStackSize diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c b/ArmPlatformPkg/PrePei= Core/PrePeiCore.c index 4911f67577a2..4f691d62cf3b 100644 --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c @@ -77,6 +77,11 @@ CEntryPoint ( ASSERT (((UINTN)PeiVectorTable & ARM_VECTOR_TABLE_ALIGNMENT) =3D=3D 0); ArmWriteVBar ((UINTN)PeiVectorTable); =20 + // Enable Floating Point + if (FixedPcdGet32 (PcdVFPEnabled)) { + ArmEnableVFP (); + } + //Note: The MMU will be enabled by MemoryPeim. Only the primary core wil= l have the MMU on. =20 // If not primary Jump to Secondary Main --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52968): https://edk2.groups.io/g/devel/message/52968 Mute This Topic: https://groups.io/mt/69498791/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-