[v2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

[edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

Posted by Gao, Zhichao 6 years, 4 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219

First previous patch remove the VT100Plus's arrow keys' support.
Add it back.

The arrow keys would send ESC [A through to ESC [D. Add this
support for the new introduced terminal type.

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
---
 .../Universal/Console/TerminalDxe/TerminalConIn.c         | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
index ac31f27984..f8c71f95c1 100644
--- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
+++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
@@ -1670,8 +1670,12 @@ UnicodeToEfiKey (
 
       if (TerminalDevice->TerminalType == TerminalTypePcAnsi    ||
           TerminalDevice->TerminalType == TerminalTypeVt100     ||
-          TerminalDevice->TerminalType == TerminalTypeVtUtf8 ||
-          TerminalDevice->TerminalType == TerminalTypeTtyTerm ||
+          TerminalDevice->TerminalType == TerminalTypeVt100Plus ||
+          TerminalDevice->TerminalType == TerminalTypeVtUtf8    ||
+          TerminalDevice->TerminalType == TerminalTypeTtyTerm   ||
+          TerminalDevice->TerminalType == TerminalTypeLinux     ||
+          TerminalDevice->TerminalType == TerminalTypeXtermR6   ||
+          TerminalDevice->TerminalType == TerminalTypeVt400     ||
           TerminalDevice->TerminalType == TerminalTypeSCO) {
         switch (UnicodeChar) {
         case 'A':
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48164): https://edk2.groups.io/g/devel/message/48164
Mute This Topic: https://groups.io/mt/34305777/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

Posted by Ni, Ray 6 years, 4 months ago

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Thursday, September 26, 2019 6:09 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219
> 
> First previous patch remove the VT100Plus's arrow keys' support.
> Add it back.
> 
> The arrow keys would send ESC [A through to ESC [D. Add this
> support for the new introduced terminal type.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../Universal/Console/TerminalDxe/TerminalConIn.c         | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
> b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
> index ac31f27984..f8c71f95c1 100644
> --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
> @@ -1670,8 +1670,12 @@ UnicodeToEfiKey (
> 
>        if (TerminalDevice->TerminalType == TerminalTypePcAnsi    ||
>            TerminalDevice->TerminalType == TerminalTypeVt100     ||
> -          TerminalDevice->TerminalType == TerminalTypeVtUtf8 ||
> -          TerminalDevice->TerminalType == TerminalTypeTtyTerm ||
> +          TerminalDevice->TerminalType == TerminalTypeVt100Plus ||
> +          TerminalDevice->TerminalType == TerminalTypeVtUtf8    ||
> +          TerminalDevice->TerminalType == TerminalTypeTtyTerm   ||
> +          TerminalDevice->TerminalType == TerminalTypeLinux     ||
> +          TerminalDevice->TerminalType == TerminalTypeXtermR6   ||
> +          TerminalDevice->TerminalType == TerminalTypeVt400     ||
>            TerminalDevice->TerminalType == TerminalTypeSCO) {
>          switch (UnicodeChar) {
>          case 'A':
> --
> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48165): https://edk2.groups.io/g/devel/message/48165
Mute This Topic: https://groups.io/mt/34305777/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

Posted by Liming Gao 6 years, 4 months ago

Push @e86664d2b03d0a84b8b952f3d5111424b3e9c916

>-----Original Message-----
>From: Ni, Ray
>Sent: Friday, September 27, 2019 9:12 AM
>To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
>Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow
>keys support
>
>Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>> -----Original Message-----
>> From: Gao, Zhichao <zhichao.gao@intel.com>
>> Sent: Thursday, September 26, 2019 6:09 PM
>> To: devel@edk2.groups.io
>> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A
><hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Gao, Liming
>> <liming.gao@intel.com>
>> Subject: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys
>support
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219
>>
>> First previous patch remove the VT100Plus's arrow keys' support.
>> Add it back.
>>
>> The arrow keys would send ESC [A through to ESC [D. Add this
>> support for the new introduced terminal type.
>>
>> Cc: Jian J Wang <jian.j.wang@intel.com>
>> Cc: Hao A Wu <hao.a.wu@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Liming Gao <liming.gao@intel.com>
>> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
>> ---
>>  .../Universal/Console/TerminalDxe/TerminalConIn.c         | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git
>a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> index ac31f27984..f8c71f95c1 100644
>> --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c
>> @@ -1670,8 +1670,12 @@ UnicodeToEfiKey (
>>
>>        if (TerminalDevice->TerminalType == TerminalTypePcAnsi    ||
>>            TerminalDevice->TerminalType == TerminalTypeVt100     ||
>> -          TerminalDevice->TerminalType == TerminalTypeVtUtf8 ||
>> -          TerminalDevice->TerminalType == TerminalTypeTtyTerm ||
>> +          TerminalDevice->TerminalType == TerminalTypeVt100Plus ||
>> +          TerminalDevice->TerminalType == TerminalTypeVtUtf8    ||
>> +          TerminalDevice->TerminalType == TerminalTypeTtyTerm   ||
>> +          TerminalDevice->TerminalType == TerminalTypeLinux     ||
>> +          TerminalDevice->TerminalType == TerminalTypeXtermR6   ||
>> +          TerminalDevice->TerminalType == TerminalTypeVt400     ||
>>            TerminalDevice->TerminalType == TerminalTypeSCO) {
>>          switch (UnicodeChar) {
>>          case 'A':
>> --
>> 2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#48205): https://edk2.groups.io/g/devel/message/48205
Mute This Topic: https://groups.io/mt/34305777/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-