From nobody Fri Mar 29 10:14:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+48164+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48164+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1569546517; cv=none; d=zoho.com; s=zohoarc; b=hOY709YcPFDofv5eVY88Fio8RJX2Xzl1xmR3B53B/WFv7jjNTGJ1gFRwi5oEw+nkhg7/LSVuZkTH/IXDGl87E1c0sODjMbgoqnNMZ0LlEAe/yMsF9FKrOIh3QyVL/kVRy9lfZWJq7CtPfpFqj4OOV4QQgXp/LpCCL8PFaX+KKi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1569546517; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=t/Nh7asH5kTRd37OF2zBXY5MTRIWHrQwJJlExNE6D+8=; b=aIqcyXTcqIQybFzKPYI+Kqvx1ZzvgAsRHoXlB3G+rBeTl9cGGUwcIKljOVUdZJ9nCABieEbJLaDyuboeh8MnM7QshJexrSGM3/lHQNb1P1WOferGt3vL4vwmPEj5T3FLo27NOfXhBNOmyPqRpzCIfOwV2ecPMmcDv9Iij10R+Wk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+48164+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1569546517835813.1739697493451; Thu, 26 Sep 2019 18:08:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PdWBYY1788612x9K9yGLVrXf; Thu, 26 Sep 2019 18:08:36 -0700 X-Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 26 Sep 2019 18:08:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 18:08:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,553,1559545200"; d="scan'208";a="204053160" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.119]) by fmsmga001.fm.intel.com with ESMTP; 26 Sep 2019 18:08:34 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Ray Ni , Liming Gao Subject: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Date: Fri, 27 Sep 2019 09:08:31 +0800 Message-Id: <20190927010831.25944-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: 1HtYFcwrr246nJO9CzaRpRqUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1569546516; bh=2r5+8iYar+FsFfTa//OqYtn/jHxoONxtXOmhkFBD3Rc=; h=Cc:Date:From:Reply-To:Subject:To; b=Ta1HONmk3X5kIfaE+AeLu27+PayPk8SI9ZGf7qkdE+0eAHEeyagwYSGooap1cieBfOK Ql7FSdAsgKoZHKokDRQvq4OuRnvhuNOEBpP5ShDVKl0V+bpoFewqiLkGHjGCXvqFVlxOO vX/GquLgIkqD3SMFmFtFjl4f578njr9LLIo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2219 First previous patch remove the VT100Plus's arrow keys' support. Add it back. The arrow keys would send ESC [A through to ESC [D. Add this support for the new introduced terminal type. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Liming Gao Signed-off-by: Zhichao Gao Reviewed-by: Ray Ni --- .../Universal/Console/TerminalDxe/TerminalConIn.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c b/M= deModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c index ac31f27984..f8c71f95c1 100644 --- a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c +++ b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalConIn.c @@ -1670,8 +1670,12 @@ UnicodeToEfiKey ( =20 if (TerminalDevice->TerminalType =3D=3D TerminalTypePcAnsi || TerminalDevice->TerminalType =3D=3D TerminalTypeVt100 || - TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8 || - TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm || + TerminalDevice->TerminalType =3D=3D TerminalTypeVt100Plus || + TerminalDevice->TerminalType =3D=3D TerminalTypeVtUtf8 || + TerminalDevice->TerminalType =3D=3D TerminalTypeTtyTerm || + TerminalDevice->TerminalType =3D=3D TerminalTypeLinux || + TerminalDevice->TerminalType =3D=3D TerminalTypeXtermR6 || + TerminalDevice->TerminalType =3D=3D TerminalTypeVt400 || TerminalDevice->TerminalType =3D=3D TerminalTypeSCO) { switch (UnicodeChar) { case 'A': --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48164): https://edk2.groups.io/g/devel/message/48164 Mute This Topic: https://groups.io/mt/34305777/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-