1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard register defines

Javeed, Ashraf posted 1 patch 4 years, 8 months ago
Failed in applying to current master (apply log)
MdePkg/Include/IndustryStandard/PciExpress21.h | 39 ++++++++++++++++++++++++++++++++++++---
1 file changed, 36 insertions(+), 3 deletions(-)
[edk2-devel] [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard register defines
Posted by Javeed, Ashraf 4 years, 8 months ago 
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
The following two PCI Capability Structure registers are updated as per
the PCI Base Specification Revision 4:-
(1) The PCI Device capability register 2(PCI_REG_PCIE_DEVICE_CAPABILITY2)
    needs to be upgraded for the PCI features like -
    LN system CLS (LnSystemCLS),
    10b Tag completer/requester register fields
    (TenBitTagCompleterSupported, TenBitTagRequesterSupported),
    Emergency power reduction support and initialization requirement
    (EmergencyPowerReductionSupported,
     EmergencyPowerReductionInitializationRequired),
    and FRS support (FrsSupported ).

(2) The PCI Device Control register 2(PCI_REG_PCIE_DEVICE_CONTROL2) needs
    to be upgraded for the -
    Emergency power reduction request enabling
    (EmergencyPowerReductionRequest), and also the 10b Extended Tag
    enabling (TenBitTagRequesterEnable).

The following two are defined as per the PCI Express Base Specification
Revision 2.1:-
(1) Defined macro definitions for all the ranges of Maximum Payload Sizes
    and Maximum Read Request Sizes register fields

(2) Defined macro definitions for all the ranges of Completion Timeout
    value.


Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
---

In V2: Reserved field name change in PCI_REG_PCIE_DEVICE_CAPABILITY2
---
 MdePkg/Include/IndustryStandard/PciExpress21.h | 39 ++++++++++++++++++++++++++++++++++++---
 1 file changed, 36 insertions(+), 3 deletions(-)

diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h b/MdePkg/Include/IndustryStandard/PciExpress21.h
index d4003de74c..f17f570775 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
@@ -91,6 +91,24 @@ typedef union {
   UINT16   Uint16;
 } PCI_REG_PCIE_DEVICE_CONTROL;
 
+#define PCIE_MAX_PAYLOAD_SIZE_128B   0
+#define PCIE_MAX_PAYLOAD_SIZE_256B   1
+#define PCIE_MAX_PAYLOAD_SIZE_512B   2
+#define PCIE_MAX_PAYLOAD_SIZE_1024B  3
+#define PCIE_MAX_PAYLOAD_SIZE_2048B  4
+#define PCIE_MAX_PAYLOAD_SIZE_4096B  5
+#define PCIE_MAX_PAYLOAD_SIZE_RVSD1  6
+#define PCIE_MAX_PAYLOAD_SIZE_RVSD2  7
+
+#define PCIE_MAX_READ_REQ_SIZE_128B    0
+#define PCIE_MAX_READ_REQ_SIZE_256B    1
+#define PCIE_MAX_READ_REQ_SIZE_512B    2
+#define PCIE_MAX_READ_REQ_SIZE_1024B   3
+#define PCIE_MAX_READ_REQ_SIZE_2048B   4
+#define PCIE_MAX_READ_REQ_SIZE_4096B   5
+#define PCIE_MAX_READ_REQ_SIZE_RVSD1   6
+#define PCIE_MAX_READ_REQ_SIZE_RVSD2   7
+
 typedef union {
   struct {
     UINT16 CorrectableError : 1;
@@ -250,16 +268,30 @@ typedef union {
     UINT32 NoRoEnabledPrPrPassing : 1;
     UINT32 LtrMechanism : 1;
     UINT32 TphCompleter : 2;
-    UINT32 Reserved : 4;
+    UINT32 LnSystemCLS : 2;
+    UINT32 TenBitTagCompleterSupported : 1;
+    UINT32 TenBitTagRequesterSupported : 1;
     UINT32 Obff : 2;
     UINT32 ExtendedFmtField : 1;
     UINT32 EndEndTlpPrefix : 1;
     UINT32 MaxEndEndTlpPrefixes : 2;
-    UINT32 Reserved2 : 8;
+    UINT32 EmergencyPowerReductionSupported : 2;
+    UINT32 EmergencyPowerReductionInitializationRequired : 1;
+    UINT32 Reserved3 : 4;
+    UINT32 FrsSupported : 1;
   } Bits;
   UINT32   Uint32;
 } PCI_REG_PCIE_DEVICE_CAPABILITY2;
 
+#define PCIE_COMPLETION_TIMEOUT_NOT_SUPPORTED           0
+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_SUPPORTED       1
+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_SUPPORTED       2
+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_SUPPORTED     3
+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_SUPPORTED     6
+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_SUPPORTED   7
+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_D_SUPPORTED   14
+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_D_SUPPORTED 15
+
 #define PCIE_DEVICE_CAPABILITY_OBFF_MESSAGE BIT0
 #define PCIE_DEVICE_CAPABILITY_OBFF_WAKE    BIT1
 
@@ -273,7 +305,8 @@ typedef union {
     UINT16 IdoRequest : 1;
     UINT16 IdoCompletion : 1;
     UINT16 LtrMechanism : 2;
-    UINT16 Reserved : 2;
+    UINT16 EmergencyPowerReductionRequest : 1;
+    UINT16 TenBitTagRequesterEnable : 1;
     UINT16 Obff : 2;
     UINT16 EndEndTlpPrefixBlocking : 1;
   } Bits;
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44475): https://edk2.groups.io/g/devel/message/44475
Mute This Topic: https://groups.io/mt/32638894/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard register defines
Posted by Liming Gao 4 years, 8 months ago 
The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Javeed, Ashraf
>Sent: Monday, July 29, 2019 11:51 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Wu, Hao A
><hao.a.wu@intel.com>
>Subject: [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard
>register defines
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
>The following two PCI Capability Structure registers are updated as per
>the PCI Base Specification Revision 4:-
>(1) The PCI Device capability register 2(PCI_REG_PCIE_DEVICE_CAPABILITY2)
>    needs to be upgraded for the PCI features like -
>    LN system CLS (LnSystemCLS),
>    10b Tag completer/requester register fields
>    (TenBitTagCompleterSupported, TenBitTagRequesterSupported),
>    Emergency power reduction support and initialization requirement
>    (EmergencyPowerReductionSupported,
>     EmergencyPowerReductionInitializationRequired),
>    and FRS support (FrsSupported ).
>
>(2) The PCI Device Control register 2(PCI_REG_PCIE_DEVICE_CONTROL2)
>needs
>    to be upgraded for the -
>    Emergency power reduction request enabling
>    (EmergencyPowerReductionRequest), and also the 10b Extended Tag
>    enabling (TenBitTagRequesterEnable).
>
>The following two are defined as per the PCI Express Base Specification
>Revision 2.1:-
>(1) Defined macro definitions for all the ranges of Maximum Payload Sizes
>    and Maximum Read Request Sizes register fields
>
>(2) Defined macro definitions for all the ranges of Completion Timeout
>    value.
>
>
>Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
>Cc: Michael D Kinney <michael.d.kinney@intel.com>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Ray Ni <ray.ni@intel.com>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>---
>
>In V2: Reserved field name change in PCI_REG_PCIE_DEVICE_CAPABILITY2
>---
> MdePkg/Include/IndustryStandard/PciExpress21.h | 39
>++++++++++++++++++++++++++++++++++++---
> 1 file changed, 36 insertions(+), 3 deletions(-)
>
>diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h
>b/MdePkg/Include/IndustryStandard/PciExpress21.h
>index d4003de74c..f17f570775 100644
>--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
>+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
>@@ -91,6 +91,24 @@ typedef union {
>   UINT16   Uint16;
> } PCI_REG_PCIE_DEVICE_CONTROL;
>
>+#define PCIE_MAX_PAYLOAD_SIZE_128B   0
>+#define PCIE_MAX_PAYLOAD_SIZE_256B   1
>+#define PCIE_MAX_PAYLOAD_SIZE_512B   2
>+#define PCIE_MAX_PAYLOAD_SIZE_1024B  3
>+#define PCIE_MAX_PAYLOAD_SIZE_2048B  4
>+#define PCIE_MAX_PAYLOAD_SIZE_4096B  5
>+#define PCIE_MAX_PAYLOAD_SIZE_RVSD1  6
>+#define PCIE_MAX_PAYLOAD_SIZE_RVSD2  7
>+
>+#define PCIE_MAX_READ_REQ_SIZE_128B    0
>+#define PCIE_MAX_READ_REQ_SIZE_256B    1
>+#define PCIE_MAX_READ_REQ_SIZE_512B    2
>+#define PCIE_MAX_READ_REQ_SIZE_1024B   3
>+#define PCIE_MAX_READ_REQ_SIZE_2048B   4
>+#define PCIE_MAX_READ_REQ_SIZE_4096B   5
>+#define PCIE_MAX_READ_REQ_SIZE_RVSD1   6
>+#define PCIE_MAX_READ_REQ_SIZE_RVSD2   7
>+
> typedef union {
>   struct {
>     UINT16 CorrectableError : 1;
>@@ -250,16 +268,30 @@ typedef union {
>     UINT32 NoRoEnabledPrPrPassing : 1;
>     UINT32 LtrMechanism : 1;
>     UINT32 TphCompleter : 2;
>-    UINT32 Reserved : 4;
>+    UINT32 LnSystemCLS : 2;
>+    UINT32 TenBitTagCompleterSupported : 1;
>+    UINT32 TenBitTagRequesterSupported : 1;
>     UINT32 Obff : 2;
>     UINT32 ExtendedFmtField : 1;
>     UINT32 EndEndTlpPrefix : 1;
>     UINT32 MaxEndEndTlpPrefixes : 2;
>-    UINT32 Reserved2 : 8;
>+    UINT32 EmergencyPowerReductionSupported : 2;
>+    UINT32 EmergencyPowerReductionInitializationRequired : 1;
>+    UINT32 Reserved3 : 4;
>+    UINT32 FrsSupported : 1;
>   } Bits;
>   UINT32   Uint32;
> } PCI_REG_PCIE_DEVICE_CAPABILITY2;
>
>+#define PCIE_COMPLETION_TIMEOUT_NOT_SUPPORTED           0
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_SUPPORTED       1
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_SUPPORTED       2
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_SUPPORTED     3
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_SUPPORTED     6
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_SUPPORTED   7
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_D_SUPPORTED   14
>+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_D_SUPPORTED 15
>+
> #define PCIE_DEVICE_CAPABILITY_OBFF_MESSAGE BIT0
> #define PCIE_DEVICE_CAPABILITY_OBFF_WAKE    BIT1
>
>@@ -273,7 +305,8 @@ typedef union {
>     UINT16 IdoRequest : 1;
>     UINT16 IdoCompletion : 1;
>     UINT16 LtrMechanism : 2;
>-    UINT16 Reserved : 2;
>+    UINT16 EmergencyPowerReductionRequest : 1;
>+    UINT16 TenBitTagRequesterEnable : 1;
>     UINT16 Obff : 2;
>     UINT16 EndEndTlpPrefixBlocking : 1;
>   } Bits;
>--
>2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44484): https://edk2.groups.io/g/devel/message/44484
Mute This Topic: https://groups.io/mt/32638894/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard register defines
Posted by Javeed, Ashraf 4 years, 8 months ago 
Thanks Liming!

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, July 29, 2019 1:24 PM
> To: Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> Subject: RE: [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry standard
> register defines
> 
> The patch is good. Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> >-----Original Message-----
> >From: Javeed, Ashraf
> >Sent: Monday, July 29, 2019 11:51 AM
> >To: devel@edk2.groups.io
> >Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> ><liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; Wu, Hao A
> ><hao.a.wu@intel.com>
> >Subject: [Patch V2] MdePkg/PciExpress21.h: Fix the PCI industry
> >standard register defines
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2007
> >The following two PCI Capability Structure registers are updated as per
> >the PCI Base Specification Revision 4:-
> >(1) The PCI Device capability register 2(PCI_REG_PCIE_DEVICE_CAPABILITY2)
> >    needs to be upgraded for the PCI features like -
> >    LN system CLS (LnSystemCLS),
> >    10b Tag completer/requester register fields
> >    (TenBitTagCompleterSupported, TenBitTagRequesterSupported),
> >    Emergency power reduction support and initialization requirement
> >    (EmergencyPowerReductionSupported,
> >     EmergencyPowerReductionInitializationRequired),
> >    and FRS support (FrsSupported ).
> >
> >(2) The PCI Device Control register 2(PCI_REG_PCIE_DEVICE_CONTROL2)
> >needs
> >    to be upgraded for the -
> >    Emergency power reduction request enabling
> >    (EmergencyPowerReductionRequest), and also the 10b Extended Tag
> >    enabling (TenBitTagRequesterEnable).
> >
> >The following two are defined as per the PCI Express Base Specification
> >Revision 2.1:-
> >(1) Defined macro definitions for all the ranges of Maximum Payload Sizes
> >    and Maximum Read Request Sizes register fields
> >
> >(2) Defined macro definitions for all the ranges of Completion Timeout
> >    value.
> >
> >
> >Signed-off-by: Ashraf Javeed <ashraf.javeed@intel.com>
> >Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >Cc: Liming Gao <liming.gao@intel.com>
> >Cc: Ray Ni <ray.ni@intel.com>
> >Cc: Hao A Wu <hao.a.wu@intel.com>
> >---
> >
> >In V2: Reserved field name change in PCI_REG_PCIE_DEVICE_CAPABILITY2
> >---
> > MdePkg/Include/IndustryStandard/PciExpress21.h | 39
> >++++++++++++++++++++++++++++++++++++---
> > 1 file changed, 36 insertions(+), 3 deletions(-)
> >
> >diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h
> >b/MdePkg/Include/IndustryStandard/PciExpress21.h
> >index d4003de74c..f17f570775 100644
> >--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
> >+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
> >@@ -91,6 +91,24 @@ typedef union {
> >   UINT16   Uint16;
> > } PCI_REG_PCIE_DEVICE_CONTROL;
> >
> >+#define PCIE_MAX_PAYLOAD_SIZE_128B   0
> >+#define PCIE_MAX_PAYLOAD_SIZE_256B   1
> >+#define PCIE_MAX_PAYLOAD_SIZE_512B   2
> >+#define PCIE_MAX_PAYLOAD_SIZE_1024B  3 #define
> >+PCIE_MAX_PAYLOAD_SIZE_2048B  4 #define
> PCIE_MAX_PAYLOAD_SIZE_4096B  5
> >+#define PCIE_MAX_PAYLOAD_SIZE_RVSD1  6 #define
> >+PCIE_MAX_PAYLOAD_SIZE_RVSD2  7
> >+
> >+#define PCIE_MAX_READ_REQ_SIZE_128B    0
> >+#define PCIE_MAX_READ_REQ_SIZE_256B    1
> >+#define PCIE_MAX_READ_REQ_SIZE_512B    2
> >+#define PCIE_MAX_READ_REQ_SIZE_1024B   3
> >+#define PCIE_MAX_READ_REQ_SIZE_2048B   4
> >+#define PCIE_MAX_READ_REQ_SIZE_4096B   5
> >+#define PCIE_MAX_READ_REQ_SIZE_RVSD1   6
> >+#define PCIE_MAX_READ_REQ_SIZE_RVSD2   7
> >+
> > typedef union {
> >   struct {
> >     UINT16 CorrectableError : 1;
> >@@ -250,16 +268,30 @@ typedef union {
> >     UINT32 NoRoEnabledPrPrPassing : 1;
> >     UINT32 LtrMechanism : 1;
> >     UINT32 TphCompleter : 2;
> >-    UINT32 Reserved : 4;
> >+    UINT32 LnSystemCLS : 2;
> >+    UINT32 TenBitTagCompleterSupported : 1;
> >+    UINT32 TenBitTagRequesterSupported : 1;
> >     UINT32 Obff : 2;
> >     UINT32 ExtendedFmtField : 1;
> >     UINT32 EndEndTlpPrefix : 1;
> >     UINT32 MaxEndEndTlpPrefixes : 2;
> >-    UINT32 Reserved2 : 8;
> >+    UINT32 EmergencyPowerReductionSupported : 2;
> >+    UINT32 EmergencyPowerReductionInitializationRequired : 1;
> >+    UINT32 Reserved3 : 4;
> >+    UINT32 FrsSupported : 1;
> >   } Bits;
> >   UINT32   Uint32;
> > } PCI_REG_PCIE_DEVICE_CAPABILITY2;
> >
> >+#define PCIE_COMPLETION_TIMEOUT_NOT_SUPPORTED           0
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_SUPPORTED       1
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_SUPPORTED       2
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_SUPPORTED     3
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_SUPPORTED     6
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_SUPPORTED   7
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_B_C_D_SUPPORTED   14
> >+#define PCIE_COMPLETION_TIMEOUT_RANGE_A_B_C_D_SUPPORTED 15
> >+
> > #define PCIE_DEVICE_CAPABILITY_OBFF_MESSAGE BIT0
> > #define PCIE_DEVICE_CAPABILITY_OBFF_WAKE    BIT1
> >
> >@@ -273,7 +305,8 @@ typedef union {
> >     UINT16 IdoRequest : 1;
> >     UINT16 IdoCompletion : 1;
> >     UINT16 LtrMechanism : 2;
> >-    UINT16 Reserved : 2;
> >+    UINT16 EmergencyPowerReductionRequest : 1;
> >+    UINT16 TenBitTagRequesterEnable : 1;
> >     UINT16 Obff : 2;
> >     UINT16 EndEndTlpPrefixBlocking : 1;
> >   } Bits;
> >--
> >2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44486): https://edk2.groups.io/g/devel/message/44486
Mute This Topic: https://groups.io/mt/32638894/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.