[edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Laszlo Ersek posted 5 patches 18 weeks ago
Failed in applying to current master (apply log)
MdePkg/Include/Protocol/Hash.h                                              |   5 -
OvmfPkg/OvmfPkgIa32.dsc                                                     |   2 -
OvmfPkg/OvmfPkgIa32X64.dsc                                                  |   2 -
OvmfPkg/OvmfPkgX64.dsc                                                      |   2 -
SecurityPkg/Include/Library/HashLib.h                                       |   1 -
SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c                 | 150 --------------------
SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf               |  41 ------
SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni               |  15 --
SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c |   1 -
SecurityPkg/SecurityPkg.dec                                                 |   5 +-
SecurityPkg/SecurityPkg.dsc                                                 |   3 -
11 files changed, 2 insertions(+), 225 deletions(-)
delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni

[edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Laszlo Ersek 18 weeks ago
Repo:   https://github.com/lersek/edk2.git
Branch: revert_unreviewed_bz1781

The MdePkg patch and the OvmfPkg patch committed for
<https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
reviewed appropriately, so they must be reverted. Due to the MdePkg
patch being the basis of the entire series, the SecurityPkg patches in
the middle have to be reverted as well. (Leif pointed out that at least
some of the SecurityPkg patches were not reviewed *on the list* either,
so there's that too.)

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Imran Desai <imran.desai@intel.com>
Cc: Jian Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>

Thanks
Laszlo

Laszlo Ersek (5):
  Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe"
  Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default"
  Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
    algorithm"
  Revert "SecurityPkg: introduce the SM3 digest algorithm"
  Revert "MdePkg/Protocol/Hash: introduce GUID for SM3"

 MdePkg/Include/Protocol/Hash.h                                              |   5 -
 OvmfPkg/OvmfPkgIa32.dsc                                                     |   2 -
 OvmfPkg/OvmfPkgIa32X64.dsc                                                  |   2 -
 OvmfPkg/OvmfPkgX64.dsc                                                      |   2 -
 SecurityPkg/Include/Library/HashLib.h                                       |   1 -
 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c                 | 150 --------------------
 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf               |  41 ------
 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni               |  15 --
 SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c |   1 -
 SecurityPkg/SecurityPkg.dec                                                 |   5 +-
 SecurityPkg/SecurityPkg.dsc                                                 |   3 -
 11 files changed, 2 insertions(+), 225 deletions(-)
 delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
 delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
 delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni

-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43257): https://edk2.groups.io/g/devel/message/43257
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Laszlo Ersek 18 weeks ago
On 07/04/19 11:46, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: revert_unreviewed_bz1781
> 
> The MdePkg patch and the OvmfPkg patch committed for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> reviewed appropriately, so they must be reverted. Due to the MdePkg
> patch being the basis of the entire series, the SecurityPkg patches in
> the middle have to be reverted as well. (Leif pointed out that at least
> some of the SecurityPkg patches were not reviewed *on the list* either,
> so there's that too.)

I've now pushed this series (commit range 1ec05b81e59f..6a34c1ce7054),
with Leif's (as a steward's) R-b, and Phil's R-b.

If these patches had been normal patches, obviously I would have waited
for package maintainer review. However, these are *not* normal patches;
they are reverts which return the tree to an earlier state -- to a state
where unreviewed patches had not gone in yet. There's an argument to be
made that Jian should have reverted the original patches without me
having to post a revert series to the list at all -- either way, this
has been urgent because the delta with the unreviewed patches "in"
should be as minimal as possible. (Which is why I took it upon me to
send the set.) For example, a bisection should preferably not hit the
unreviewed range (good point from Leif). Furthermore, if we diverge too
much meanwhile, then the reverts themselves could become messy.

Imran: please resubmit your patches now. Please pay attention to shallow
threading, and to actually working CC's. Regarding the SecurityPkg
patches, if you are going to post them unchanged, please preserve the
Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those
Reviewed-by tags had been given publicly, on the list. (In other words,
if they can be found in the mailing list archive.)

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43314): https://edk2.groups.io/g/devel/message/43314
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Wang, Jian J 18 weeks ago
Hi Laszlo,

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Friday, July 05, 2019 12:05 AM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Desai, Imran
> <imran.desai@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Gao,
> Liming <liming.gao@intel.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Stefan Berger <stefanb@linux.ibm.com>
> Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg:
> revert unreviewed SM3 patches
> 
> On 07/04/19 11:46, Laszlo Ersek wrote:
> > Repo:   https://github.com/lersek/edk2.git
> > Branch: revert_unreviewed_bz1781
> >
> > The MdePkg patch and the OvmfPkg patch committed for
> > <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> > reviewed appropriately, so they must be reverted. Due to the MdePkg
> > patch being the basis of the entire series, the SecurityPkg patches in
> > the middle have to be reverted as well. (Leif pointed out that at least
> > some of the SecurityPkg patches were not reviewed *on the list* either,
> > so there's that too.)
> 
> I've now pushed this series (commit range 1ec05b81e59f..6a34c1ce7054),
> with Leif's (as a steward's) R-b, and Phil's R-b.
> 
> If these patches had been normal patches, obviously I would have waited
> for package maintainer review. However, these are *not* normal patches;
> they are reverts which return the tree to an earlier state -- to a state
> where unreviewed patches had not gone in yet. There's an argument to be
> made that Jian should have reverted the original patches without me
> having to post a revert series to the list at all -- either way, this
> has been urgent because the delta with the unreviewed patches "in"
> should be as minimal as possible. (Which is why I took it upon me to
> send the set.) For example, a bisection should preferably not hit the
> unreviewed range (good point from Leif). Furthermore, if we diverge too
> much meanwhile, then the reverts themselves could become messy.
> 

Understood. Thanks for doing this for me.

Regards,
Jian

> Imran: please resubmit your patches now. Please pay attention to shallow
> threading, and to actually working CC's. Regarding the SecurityPkg
> patches, if you are going to post them unchanged, please preserve the
> Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those
> Reviewed-by tags had been given publicly, on the list. (In other words,
> if they can be found in the mailing list archive.)
> 
> Thanks
> Laszlo
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43326): https://edk2.groups.io/g/devel/message/43326
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Philippe Mathieu-Daudé 18 weeks ago
On 7/4/19 6:05 PM, Laszlo Ersek wrote:
> On 07/04/19 11:46, Laszlo Ersek wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: revert_unreviewed_bz1781
>>
>> The MdePkg patch and the OvmfPkg patch committed for
>> <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
>> reviewed appropriately, so they must be reverted. Due to the MdePkg
>> patch being the basis of the entire series, the SecurityPkg patches in
>> the middle have to be reverted as well. (Leif pointed out that at least
>> some of the SecurityPkg patches were not reviewed *on the list* either,
>> so there's that too.)
> 
> I've now pushed this series (commit range 1ec05b81e59f..6a34c1ce7054),
> with Leif's (as a steward's) R-b, and Phil's R-b.
> 
> If these patches had been normal patches, obviously I would have waited
> for package maintainer review. However, these are *not* normal patches;
> they are reverts which return the tree to an earlier state -- to a state
> where unreviewed patches had not gone in yet. There's an argument to be
> made that Jian should have reverted the original patches without me
> having to post a revert series to the list at all -- either way, this
> has been urgent because the delta with the unreviewed patches "in"
> should be as minimal as possible. (Which is why I took it upon me to
> send the set.) For example, a bisection should preferably not hit the
> unreviewed range (good point from Leif). Furthermore, if we diverge too
> much meanwhile, then the reverts themselves could become messy.

Agreed, this is why I wanted this merged quickly, thanks.

> Imran: please resubmit your patches now. Please pay attention to shallow
> threading, and to actually working CC's. Regarding the SecurityPkg
> patches, if you are going to post them unchanged, please preserve the
> Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those
> Reviewed-by tags had been given publicly, on the list. (In other words,
> if they can be found in the mailing list archive.)
> 
> Thanks
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43319): https://edk2.groups.io/g/devel/message/43319
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Philippe Mathieu-Daudé 18 weeks ago
On 7/4/19 11:46 AM, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: revert_unreviewed_bz1781
> 
> The MdePkg patch and the OvmfPkg patch committed for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> reviewed appropriately, so they must be reverted. Due to the MdePkg
> patch being the basis of the entire series, the SecurityPkg patches in
> the middle have to be reverted as well. (Leif pointed out that at least
> some of the SecurityPkg patches were not reviewed *on the list* either,
> so there's that too.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Imran Desai <imran.desai@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (5):
>   Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe"
>   Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default"
>   Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm"
>   Revert "SecurityPkg: introduce the SM3 digest algorithm"
>   Revert "MdePkg/Protocol/Hash: introduce GUID for SM3"

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43263): https://edk2.groups.io/g/devel/message/43263
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches

Posted by Leif Lindholm 18 weeks ago
On Thu, Jul 04, 2019 at 11:46:19AM +0200, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: revert_unreviewed_bz1781
> 
> The MdePkg patch and the OvmfPkg patch committed for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> reviewed appropriately, so they must be reverted. Due to the MdePkg
> patch being the basis of the entire series, the SecurityPkg patches in
> the middle have to be reverted as well. (Leif pointed out that at least
> some of the SecurityPkg patches were not reviewed *on the list* either,
> so there's that too.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Imran Desai <imran.desai@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (5):
>   Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe"
>   Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default"
>   Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm"
>   Revert "SecurityPkg: introduce the SM3 digest algorithm"
>   Revert "MdePkg/Protocol/Hash: introduce GUID for SM3"

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  MdePkg/Include/Protocol/Hash.h                                              |   5 -
>  OvmfPkg/OvmfPkgIa32.dsc                                                     |   2 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                                                  |   2 -
>  OvmfPkg/OvmfPkgX64.dsc                                                      |   2 -
>  SecurityPkg/Include/Library/HashLib.h                                       |   1 -
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c                 | 150 --------------------
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf               |  41 ------
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni               |  15 --
>  SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c |   1 -
>  SecurityPkg/SecurityPkg.dec                                                 |   5 +-
>  SecurityPkg/SecurityPkg.dsc                                                 |   3 -
>  11 files changed, 2 insertions(+), 225 deletions(-)
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> 
> -- 
> 2.19.1.3.g30247aa5d201
> 
> 
> 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#43262): https://edk2.groups.io/g/devel/message/43262
Mute This Topic: https://groups.io/mt/32306503/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-