From nobody Fri Apr 19 01:04:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43256+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43256+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562233600; cv=none; d=zoho.com; s=zohoarc; b=KUqHkjbH9/LoOAtAz+v11VDYmNmKYB/63VY0BVWM1PGDR53HIEAl7FIBO0tTTUM33b2/auRfqoNzh1zvQeWQlEweDZz6Z14ggfTE4pl+EyV+KH053ife4tUkJrd5HRRyE4ObYJqrsExYDSK6FIOq/X+OxZVO/nu4j9iEApLMAes= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562233600; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=yA1W0epiTh31khnF+mcDbJ93Gp4he65wVrX+gIu5qzw=; b=mAQsqJETae3upAL1QUDp3oN4bFi0FWKrOyda53oFjb0+ZBtgyklbVa+xHgyoweQUsidRO2RJMZd3MN5AN9sqwSxSUGkS77yusJ4qmUdbiXSQ1mqHjr3Wd7iWQHbU8IpwbUBvagGZF87MidQ8DyPSOK8FItVJAOqNlhgHJaHmZOM= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43256+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 156223360058851.72621427024592; Thu, 4 Jul 2019 02:46:40 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 02:46:37 -0700 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1531F3084242; Thu, 4 Jul 2019 09:46:37 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60B945947C; Thu, 4 Jul 2019 09:46:35 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Imran Desai , Jordan Justen , Leif Lindholm , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Stefan Berger Subject: [edk2-devel] [PATCH 1/5] Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe" Date: Thu, 4 Jul 2019 11:46:20 +0200 Message-Id: <20190704094624.21057-2-lersek@redhat.com> In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Thu, 04 Jul 2019 09:46:37 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562233598; bh=Lh2DwoXrCG8AQb8DLqoctOKRIAwmbXX2s/Jb04Vhhco=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=s75anHNJMF49ZB1N4z1WqBFWH0U8OSEDbo1VMjdlM/rqqjOxIgpQ9YUQBsB0BTlIwin NwKX3kuoD0buVLWTMVtIOazDIyres1VIAYfgt3TcUBdQijoF3aJhuhRxYcK6VzvcbP9hf oziJzmprHyOuu97qjnLdxs/Iw0pVCzK77Mw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This reverts commit a7c7d21ffa9ad14b418e728a882df0a9b8815bf6. The reason is that said commit had not been reviewed by OvmfPkg maintainers/reviewers, before it was pushed. Cc: Ard Biesheuvel Cc: Imran Desai Cc: Jordan Justen Cc: Leif Lindholm Cc: Marc-Andr=C3=A9 Lureau Cc: Stefan Berger Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 Signed-off-by: Laszlo Ersek Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those Reviewed-by tags had been given publicly, on the list. (In other words, Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/OvmfPkgIa32.dsc | 2 -- OvmfPkg/OvmfPkgIa32X64.dsc | 2 -- OvmfPkg/OvmfPkgX64.dsc | 2 -- 3 files changed, 6 deletions(-) diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index d60bcd5e5407..87716123997a 100644 --- a/OvmfPkg/OvmfPkgIa32.dsc +++ b/OvmfPkg/OvmfPkgIa32.dsc @@ -625,7 +625,6 @@ [Components] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf @@ -907,6 +906,5 @@ [Components] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !endif diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc index ded3e8a46478..ad20531ceb8b 100644 --- a/OvmfPkg/OvmfPkgIa32X64.dsc +++ b/OvmfPkg/OvmfPkgIa32X64.dsc @@ -637,7 +637,6 @@ [Components.IA32] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf @@ -921,6 +920,5 @@ [Components.X64] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !endif diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 131f2b0b47da..0542ac2235b4 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -636,7 +636,6 @@ [Components] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !if $(TPM2_CONFIG_ENABLE) =3D=3D TRUE SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf @@ -919,6 +918,5 @@ [Components] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } !endif --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43256): https://edk2.groups.io/g/devel/message/43256 Mute This Topic: https://groups.io/mt/32306502/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 01:04:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43258+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43258+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562233607; cv=none; d=zoho.com; s=zohoarc; b=TgXhO4SWS9QQ1bx76rvZ8fnKuPZsJm2Tuxi5GDl/Enxehu7m43dCpBNZ2a7EMfzyNO/su8SgVNi5FyOR95w7UyqoV7UsTfROONXbFq5F0TXezJCY5e8J7hKer+8Aj70tQzlUfkM27Snf+9puEw78okAjOSH6gOy/aiXsLiv45Z0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562233607; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=5wkgfy6Aj+x5Z4XiBI5FT3eAQY5jlVo+9RwlpI41Q58=; b=EPkBNARgcCD7ZgGP89dYBml8nAEG8UJ456b/IyYBmDx8fe8oVVWwZTORSxiEwQr1FX1akwozewsfRsScIZaJSG7fC9N+emlKaMsNeSahlOonZlPIhtoFQRQ5tHCVGNh2Kz0oz0ciPNMeL7XgZUeAB/gmfAAlAEn/oWUT3uHDQBk= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43258+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562233607854900.6164180868955; Thu, 4 Jul 2019 02:46:47 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 02:46:47 -0700 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AE2485A07; Thu, 4 Jul 2019 09:46:42 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id E3C725B2D5; Thu, 4 Jul 2019 09:46:40 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Imran Desai , Jian Wang , Jiewen Yao , Leif Lindholm Subject: [edk2-devel] [PATCH 2/5] Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default" Date: Thu, 4 Jul 2019 11:46:21 +0200 Message-Id: <20190704094624.21057-3-lersek@redhat.com> In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 04 Jul 2019 09:46:42 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562233607; bh=w2+rU6Awxuiud9VGy2SD/G55T0Nj80tuNvl5eNQCyFI=; h=Cc:Date:From:Reply-To:Subject:To; b=MkhIWbAMv7s4DHwF9qcp6aE/Ys+Ym0++WfBtzvSWLpp2YiUZRfEcp4dVJe2akVwQ3c1 8yZVOJ/B3fW+4SD0GpuI8IF/pzezbPx8/Abfb3zF7Nlag/dZK79zuKFgUzTc4QKYNnwGz 4TT5jUOl8Jiosnn9lVEydTWBh46i9ARasBc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This reverts commit d5af8fc5a975feb6c745587d0d834733ad2048fd. The reason is that said commit indirectly depends on commit 49c1e683c452 ("MdePkg/Protocol/Hash: introduce GUID for SM3", 2019-07-03), and the latter commit is going to be reverted, due to its review process not having followed established edk2 norms. Cc: Chao Zhang Cc: Imran Desai Cc: Jian Wang Cc: Jiewen Yao Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 Signed-off-by: Laszlo Ersek Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those Reviewed-by tags had been given publicly, on the list. (In other words, Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- SecurityPkg/SecurityPkg.dec | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index d2f6a6fd1293..b9c04a3d13d1 100644 --- a/SecurityPkg/SecurityPkg.dec +++ b/SecurityPkg/SecurityPkg.dec @@ -453,10 +453,9 @@ [PcdsDynamic, PcdsDynamicEx] # BIT1 - SHA256.
# BIT2 - SHA384.
# BIT3 - SHA512.
- # BIT4 - SM3_256.
# @Prompt Hash mask for TPM 2.0 - # @ValidRange 0x80000001 | 0x00000000 - 0x0000001F - gEfiSecurityPkgTokenSpaceGuid.PcdTpm2HashMask|0x0000001F|UINT32|0x000100= 10 + # @ValidRange 0x80000001 | 0x00000000 - 0x0000000F + gEfiSecurityPkgTokenSpaceGuid.PcdTpm2HashMask|0x0000000F|UINT32|0x000100= 10 =20 ## This PCD indicated final BIOS supported Hash mask. # Bios may choose to register a subset of PcdTpm2HashMask. --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43258): https://edk2.groups.io/g/devel/message/43258 Mute This Topic: https://groups.io/mt/32306504/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 01:04:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43261+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43261+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562233613; cv=none; d=zoho.com; s=zohoarc; b=S6CDk3Pdd7hc7HHHBmwxTowVX/CngkOH3+Q4yocoTmGywwd278HiWh5XIT3i0Fa8aghQrfGwrRi4ONXENOYvv+q42c0Q0EBM22/Adgvipxk7oWWLWVGt03wywcdzgG6ewyLANNHknKA48MJs5/RZv8Vh4BSUPJ4AOODOYTU5uTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562233613; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=y16ibDjmc13+M+C+IrnMIblt0Q1ogb4HSy1UMn8UBzQ=; b=hf+KLRqhIbm7AJpresjdtMR8hO2WiHIOQJUag3R+0+XnI9+AYn8PUe6j9mdK3m0sttMT+YT1TpoPb0x8mYb7JD3y42HD28rFQAYDmmFS6wtIWs8d3YO37emBPU5hkOXA859eTobBaTw99nCHHFuhm8OhHuh4BZzQmyd4kDlPC4s= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43261+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562233613420327.03445813343944; Thu, 4 Jul 2019 02:46:53 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 02:46:52 -0700 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 48A23308FE9A; Thu, 4 Jul 2019 09:46:44 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id BDE5D5B2D5; Thu, 4 Jul 2019 09:46:42 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Imran Desai , Jian Wang , Jiewen Yao , Leif Lindholm Subject: [edk2-devel] [PATCH 3/5] Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm" Date: Thu, 4 Jul 2019 11:46:22 +0200 Message-Id: <20190704094624.21057-4-lersek@redhat.com> In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Thu, 04 Jul 2019 09:46:44 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562233613; bh=9MfPD1ml+8SfRaWsscPLpGcgH2BhaRhFjifzQdgqlZA=; h=Cc:Date:From:Reply-To:Subject:To; b=cAKO5ENd5DSURJCPFwBysU/IKJN/7OjAPDXxW7bnvfalpnaHWt0X58LViVbLhWwBiLv fl4kVIWBS0nb1sey9O46Qr4S0x37Xbs/9GrozqCQS3s47wZ6CwAMUhPwQRCkkcR2SYREy uBg8/yzbNAz/tX6CnmgBhW2jLzg8858AS9s= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This reverts commit 542d04e2a4fec0df0340d2ad7b59f011f20d03cc. The reason is that said commit indirectly depends on commit 49c1e683c452 ("MdePkg/Protocol/Hash: introduce GUID for SM3", 2019-07-03), and the latter commit is going to be reverted, due to its review process not having followed established edk2 norms. Cc: Chao Zhang Cc: Imran Desai Cc: Jian Wang Cc: Jiewen Yao Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 Signed-off-by: Laszlo Ersek Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those Reviewed-by tags had been given publicly, on the list. (In other words, Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.= c | 1 - 1 file changed, 1 deletion(-) diff --git a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoR= outerCommon.c b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryp= toRouterCommon.c index aec874a9e072..7f3bdab53066 100644 --- a/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCo= mmon.c +++ b/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCo= mmon.c @@ -25,7 +25,6 @@ TPM2_HASH_MASK mTpm2HashMask[] =3D { {HASH_ALGORITHM_SHA256_GUID, HASH_ALG_SHA256}, {HASH_ALGORITHM_SHA384_GUID, HASH_ALG_SHA384}, {HASH_ALGORITHM_SHA512_GUID, HASH_ALG_SHA512}, - {HASH_ALGORITHM_SM3_256_GUID, HASH_ALG_SM3_256}, }; =20 /** --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43261): https://edk2.groups.io/g/devel/message/43261 Mute This Topic: https://groups.io/mt/32306507/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 01:04:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43259+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43259+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562233608; cv=none; d=zoho.com; s=zohoarc; b=AlB5jalb3rVMKfjL8U3RdxMZ27hXjy4nqJPZidB1kazpnbrn3wWEJx+MXG9iiBGl+r03Tfn7BlIopI3CkRlrtajk3hq91eVRmyQDvD98YDAIX7fve7+lLSukYOpNNq5LHvy70jmCBXkYf3nhNmThOp1vaCckWMc3PkmQ3SUzO6o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562233608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=sEqwL5p6k25IdRzkUXq+GvlVZsBS7egcT4FfpjVVPYc=; b=OuoVx7CbwdOPsvMHHB5rJuu876j3B5UXbsX08KT7IlV0E75yLidmDQRGZu8o1ookR0bnfVryu+7V2iD+rwj/D+nEXxKvCa52vbe8Yrvodb+347OHD7KvC0hf3tzIGNIVhRg7sJIgkpcuwiuaosDeUQHLYI5FXUQ34ibOJ9zRCVo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43259+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562233608085367.9777769500653; Thu, 4 Jul 2019 02:46:48 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 02:46:47 -0700 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2291385A04; Thu, 4 Jul 2019 09:46:46 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 990665B2D7; Thu, 4 Jul 2019 09:46:44 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Imran Desai , Jian Wang , Jiewen Yao , Leif Lindholm Subject: [edk2-devel] [PATCH 4/5] Revert "SecurityPkg: introduce the SM3 digest algorithm" Date: Thu, 4 Jul 2019 11:46:23 +0200 Message-Id: <20190704094624.21057-5-lersek@redhat.com> In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 04 Jul 2019 09:46:46 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562233607; bh=dc+hxG2s9EqHiv6EQnzUksSMkVPbWG2M7o4X+fVB9l0=; h=Cc:Date:From:Reply-To:Subject:To; b=Hcl+3mh6GhZljbIzQ4ux/5GseqVoalXFEl7QcYA5MUEJOhQEImzvM1J8dSpU9sFoECS 4t4jYN9PteJ3be8TMWTVnoXcJrHs0nQSZCzJYMiL+WlhjiyTziFfbvt0chiJYegi/zz3h f2wyaOhzYmdpOpygXkACQwrJRi/QWp18KFA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This reverts commit 06dd5863b66edd9908834371e07fb4e11383c172. The reason is that said commit directly depends on commit 49c1e683c452 ("MdePkg/Protocol/Hash: introduce GUID for SM3", 2019-07-03), and the latter commit is going to be reverted, due to its review process not having followed established edk2 norms. Cc: Chao Zhang Cc: Imran Desai Cc: Jian Wang Cc: Jiewen Yao Cc: Leif Lindholm Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 Signed-off-by: Laszlo Ersek Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those Reviewed-by tags had been given publicly, on the list. (In other words, Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni | 15 -- SecurityPkg/SecurityPkg.dsc | 3 - SecurityPkg/Include/Library/HashLib.h | 1 - SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf | 41 ------ SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c | 150 ------= -------------- 5 files changed, 210 deletions(-) diff --git a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni = b/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni deleted file mode 100644 index 07a5c53d9915..000000000000 --- a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni +++ /dev/null @@ -1,15 +0,0 @@ -// /** @file -// Provides BaseCrypto SM3 hash service -// -// This library can be registered to BaseCrypto router, to serve as hash e= ngine. -// -// Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.
-// SPDX-License-Identifier: BSD-2-Clause-Patent -// -// **/ - - -#string STR_MODULE_ABSTRACT #language en-US "Provides BaseCryp= to SM3 hash service" - -#string STR_MODULE_DESCRIPTION #language en-US "This library can = be registered to BaseCrypto router, to serve as hash engine." - diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index aef2ac3a208d..60f3b0110eb7 100644 --- a/SecurityPkg/SecurityPkg.dsc +++ b/SecurityPkg/SecurityPkg.dsc @@ -226,7 +226,6 @@ [Components.IA32, Components.X64] SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256.inf SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384.inf SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512.inf - SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf =20 SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigPei.inf { @@ -241,7 +240,6 @@ [Components.IA32, Components.X64] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf } =20 SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf { @@ -252,7 +250,6 @@ [Components.IA32, Components.X64] NULL|SecurityPkg/Library/HashInstanceLibSha256/HashInstanceLibSha256= .inf NULL|SecurityPkg/Library/HashInstanceLibSha384/HashInstanceLibSha384= .inf NULL|SecurityPkg/Library/HashInstanceLibSha512/HashInstanceLibSha512= .inf - NULL|SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf } SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigDxe.inf { diff --git a/SecurityPkg/Include/Library/HashLib.h b/SecurityPkg/Include/Li= brary/HashLib.h index a5b433d824a4..63f08398788b 100644 --- a/SecurityPkg/Include/Library/HashLib.h +++ b/SecurityPkg/Include/Library/HashLib.h @@ -137,7 +137,6 @@ EFI_STATUS #define HASH_ALGORITHM_SHA256_GUID EFI_HASH_ALGORITHM_SHA256_GUID #define HASH_ALGORITHM_SHA384_GUID EFI_HASH_ALGORITHM_SHA384_GUID #define HASH_ALGORITHM_SHA512_GUID EFI_HASH_ALGORITHM_SHA512_GUID -#define HASH_ALGORITHM_SM3_256_GUID EFI_HASH_ALGORITHM_SM3_256_GUID =20 typedef struct { EFI_GUID HashGuid; diff --git a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf = b/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf deleted file mode 100644 index 781164d74ea0..000000000000 --- a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf +++ /dev/null @@ -1,41 +0,0 @@ -## @file -# Provides BaseCrypto SM3 hash service -# -# This library can be registered to BaseCrypto router, to serve as hash e= ngine. -# -# Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.
-# SPDX-License-Identifier: BSD-2-Clause-Patent -# -## - -[Defines] - INF_VERSION =3D 0x00010005 - BASE_NAME =3D HashInstanceLibSm3 - MODULE_UNI_FILE =3D HashInstanceLibSm3.uni - FILE_GUID =3D C5865D5D-9ACE-39FB-DC7C-0511891D40F9 - MODULE_TYPE =3D BASE - VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D NULL - CONSTRUCTOR =3D HashInstanceLibSm3Constructor - -# -# The following information is for reference only and not required by the = build tools. -# -# VALID_ARCHITECTURES =3D IA32 X64 -# - -[Sources] - HashInstanceLibSm3.c - -[Packages] - MdePkg/MdePkg.dec - SecurityPkg/SecurityPkg.dec - CryptoPkg/CryptoPkg.dec - -[LibraryClasses] - BaseLib - BaseMemoryLib - DebugLib - Tpm2CommandLib - MemoryAllocationLib - BaseCryptLib diff --git a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c b/= SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c deleted file mode 100644 index 8fd95162118a..000000000000 --- a/SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c +++ /dev/null @@ -1,150 +0,0 @@ -/** @file - BaseCrypto SM3 hash instance library. - It can be registered to BaseCrypto router, to serve as hash engine. - - Copyright (c) 2013 - 2019, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent -**/ - -#include -#include -#include -#include -#include -#include -#include -#include - -/** - The function set SM3 to digest list. - - @param DigestList digest list - @param Sm3Digest SM3 digest -**/ -VOID -Tpm2SetSm3ToDigestList ( - IN TPML_DIGEST_VALUES *DigestList, - IN UINT8 *Sm3Digest - ) -{ - DigestList->count =3D 1; - DigestList->digests[0].hashAlg =3D TPM_ALG_SM3_256; - CopyMem ( - DigestList->digests[0].digest.sm3_256, - Sm3Digest, - SM3_256_DIGEST_SIZE - ); -} - -/** - Start hash sequence. - - @param HashHandle Hash handle. - - @retval EFI_SUCCESS Hash sequence start and HandleHandle return= ed. - @retval EFI_OUT_OF_RESOURCES No enough resource to start hash. -**/ -EFI_STATUS -EFIAPI -Sm3HashInit ( - OUT HASH_HANDLE *HashHandle - ) -{ - VOID *Sm3Ctx; - UINTN CtxSize; - - CtxSize =3D Sm3GetContextSize (); - Sm3Ctx =3D AllocatePool (CtxSize); - if (Sm3Ctx =3D=3D NULL) { - return EFI_OUT_OF_RESOURCES; - } - - Sm3Init (Sm3Ctx); - - *HashHandle =3D (HASH_HANDLE)Sm3Ctx; - - return EFI_SUCCESS; -} - -/** - Update hash sequence data. - - @param HashHandle Hash handle. - @param DataToHash Data to be hashed. - @param DataToHashLen Data size. - - @retval EFI_SUCCESS Hash sequence updated. -**/ -EFI_STATUS -EFIAPI -Sm3HashUpdate ( - IN HASH_HANDLE HashHandle, - IN VOID *DataToHash, - IN UINTN DataToHashLen - ) -{ - VOID *Sm3Ctx; - - Sm3Ctx =3D (VOID *)HashHandle; - Sm3Update (Sm3Ctx, DataToHash, DataToHashLen); - - return EFI_SUCCESS; -} - -/** - Complete hash sequence complete. - - @param HashHandle Hash handle. - @param DigestList Digest list. - - @retval EFI_SUCCESS Hash sequence complete and DigestList is returne= d. -**/ -EFI_STATUS -EFIAPI -Sm3HashFinal ( - IN HASH_HANDLE HashHandle, - OUT TPML_DIGEST_VALUES *DigestList - ) -{ - UINT8 Digest[SM3_256_DIGEST_SIZE]; - VOID *Sm3Ctx; - - Sm3Ctx =3D (VOID *)HashHandle; - Sm3Final (Sm3Ctx, Digest); - - FreePool (Sm3Ctx); - - Tpm2SetSm3ToDigestList (DigestList, Digest); - - return EFI_SUCCESS; -} - -HASH_INTERFACE mSm3InternalHashInstance =3D { - HASH_ALGORITHM_SM3_256_GUID, - Sm3HashInit, - Sm3HashUpdate, - Sm3HashFinal, -}; - -/** - The function register SM3 instance. - - @retval EFI_SUCCESS SM3 instance is registered, or system dose not sup= port register SM3 instance -**/ -EFI_STATUS -EFIAPI -HashInstanceLibSm3Constructor ( - VOID - ) -{ - EFI_STATUS Status; - - Status =3D RegisterHashInterfaceLib (&mSm3InternalHashInstance); - if ((Status =3D=3D EFI_SUCCESS) || (Status =3D=3D EFI_UNSUPPORTED)) { - // - // Unsupported means platform policy does not need this instance enabl= ed. - // - return EFI_SUCCESS; - } - return Status; -} --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43259): https://edk2.groups.io/g/devel/message/43259 Mute This Topic: https://groups.io/mt/32306505/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 01:04:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+43260+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43260+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1562233608; cv=none; d=zoho.com; s=zohoarc; b=g2IWkhspZZU8U97HV9leZVU2Jx5LoOCOo4sOlVTAfoWbO/bRdvfOddel6BXy0BfSdOp4qCDjEzCmLqLHsz7GBqRy2InO5Oe0E7nU594oorgv05SPdQ/WxMAUIklsf2eAvj6RpP6bYRiBVUwmNuDpcehTf5+LhP8P9n1NL06ot8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562233608; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To:ARC-Authentication-Results; bh=P1YCMJ9nIIa8mP6v3BfZzG9QWbXPCDknGaz31eCVG3Q=; b=MaMWN2kTtMsr8XKasCi0OSjvaFJJnlESwdjW5A7pFBnmA3vnPhbWZsF6IpMZdbh6h2BZYYwX+QhaxqrGowTIRcyrpcF57zD0+UK+watVnIR+slsxekLsvxAbPaJOgLsEbi5eDOBh/qnWgFWCCJaNjKdA4dsFFBe9N+t3CmFSY1c= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+43260+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1562233608867783.6058803823172; Thu, 4 Jul 2019 02:46:48 -0700 (PDT) Return-Path: X-Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 04 Jul 2019 02:46:48 -0700 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0533368E3; Thu, 4 Jul 2019 09:46:47 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-165.ams2.redhat.com [10.36.117.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 726985B2C8; Thu, 4 Jul 2019 09:46:46 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Imran Desai , Leif Lindholm , Liming Gao , Michael D Kinney Subject: [edk2-devel] [PATCH 5/5] Revert "MdePkg/Protocol/Hash: introduce GUID for SM3" Date: Thu, 4 Jul 2019 11:46:24 +0200 Message-Id: <20190704094624.21057-6-lersek@redhat.com> In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 04 Jul 2019 09:46:47 +0000 (UTC) Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1562233608; bh=8isJZJM5z3eHuecatnK6DZwL8Jk+MqTlHPtf4STHuRU=; h=Cc:Date:From:Reply-To:Subject:To; b=Zd8qBVxHubgHA4+ll5KsN/T8WDrikBPpzF6SGsAiYI1WjTkgMbApKKk9SUWna2jYqAs CZwnnm+IAG1IU5/elPE9+Xh1EeW6HeLX2OdMMYoYTU4Ty2ggGPd1cUUZv7uiuRiyHKj5o y3/5vlHfGXWjZ2K5A/Wyz1KLNEPC6Vuh6JY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This reverts commit 49c1e683c452f68c7315454280d81449f7d94d2b. The reason is that said commit had not been reviewed by MdePkg maintainers, before it was pushed. Cc: Imran Desai Cc: Leif Lindholm Cc: Liming Gao Cc: Michael D Kinney Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 Signed-off-by: Laszlo Ersek Reviewed-by tags from the SecurityPkg maintainers, but *ONLY IF* those Reviewed-by tags had been given publicly, on the list. (In other words, Reviewed-by: Leif Lindholm Reviewed-by: Philippe Mathieu-Daude --- MdePkg/Include/Protocol/Hash.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/MdePkg/Include/Protocol/Hash.h b/MdePkg/Include/Protocol/Hash.h index 8abf1a4fa305..931d7916ef1e 100644 --- a/MdePkg/Include/Protocol/Hash.h +++ b/MdePkg/Include/Protocol/Hash.h @@ -48,11 +48,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent 0xcaa4381e, 0x750c, 0x4770, {0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x21,= 0x30 } \ } =20 -#define EFI_HASH_ALGORITHM_SM3_256_GUID \ - { \ - 0x251C7818, 0x0DBF, 0xE619, { 0x7F, 0xC2, 0xD6, 0xAC, 0x43, 0x42, 0x7D= , 0xA3 } \ - } - #define EFI_HASH_ALGORTIHM_MD5_GUID \ { \ 0xaf7c79c, 0x65b5, 0x4319, {0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a, = 0xd7 } \ --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43260): https://edk2.groups.io/g/devel/message/43260 Mute This Topic: https://groups.io/mt/32306506/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-