On 06/06/19 15:14, Anthony PERARD wrote:
> SERIAL_DXE_FILE_GUID is now defined in MdeModulePkg as
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID, simply use it.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index b8f50ea96b..30c015eec5 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -26,6 +26,7 @@
> #include <Protocol/VirtioDevice.h>
> #include <Guid/EventGroup.h>
> #include <Guid/RootBridgesConnectedEventGroup.h>
> +#include <Guid/SerialPortLibVendor.h>
>
> #include "PlatformBm.h"
>
> @@ -41,18 +42,13 @@ typedef struct {
> } PLATFORM_SERIAL_CONSOLE;
> #pragma pack ()
>
> -#define SERIAL_DXE_FILE_GUID { \
> - 0xD3987D4B, 0x971A, 0x435F, \
> - { 0x8C, 0xAF, 0x49, 0x67, 0xEB, 0x62, 0x72, 0x41 } \
> - }
> -
> STATIC PLATFORM_SERIAL_CONSOLE mSerialConsole = {
> //
> // VENDOR_DEVICE_PATH SerialDxe
> //
> {
> { HARDWARE_DEVICE_PATH, HW_VENDOR_DP, DP_NODE_LEN (VENDOR_DEVICE_PATH) },
> - SERIAL_DXE_FILE_GUID
> + EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> },
>
> //
>
I would drop "from MdeModulePkg" from the subject line. With that change,
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
If the maintainer that pushes this series agrees to tweak the subject
like that, then I'm OK if the series is not reposted just for this. (BTW
I could be that maintainer too.)
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42013): https://edk2.groups.io/g/devel/message/42013
Mute This Topic: https://groups.io/mt/31950871/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-