[edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Anthony PERARD posted 4 patches 2 weeks ago
Failed in applying to current master (apply log)
MdeModulePkg/MdeModulePkg.dec                 |  3 +++
.../Universal/SerialDxe/SerialDxe.inf         |  1 +
.../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
.../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
.../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
.../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
7 files changed, 31 insertions(+), 14 deletions(-)
create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h

[edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Anthony PERARD 2 weeks ago
The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
once without defining the macro. This patch series define a macro in
MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
EDKII_SERIAL_PORT_LIB_VENDOR_GUID.

Note that I haven't build/test those changes, but I have test the first patch
by applying a similar change to a patch series I'm working on.

Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2

Thanks.

Anthony PERARD (4):
  MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
  ArmVirtPkg/PlatformBootManagerLib: Use
    EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
  ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
    from MdeModulePkg
  UefiPayloadPkg/PlatformBootManagerLib: Use
    EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg

 MdeModulePkg/MdeModulePkg.dec                 |  3 +++
 .../Universal/SerialDxe/SerialDxe.inf         |  1 +
 .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
 .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
 .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
 MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
 .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
 7 files changed, 31 insertions(+), 14 deletions(-)
 create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h

-- 
Anthony PERARD


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42006): https://edk2.groups.io/g/devel/message/42006
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Laszlo Ersek 2 weeks ago
On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> 
> Note that I haven't build/test those changes, but I have test the first patch
> by applying a similar change to a patch series I'm working on.
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> 
> Thanks.
> 
> Anthony PERARD (4):
>   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>   ArmVirtPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
>   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>     from MdeModulePkg
>   UefiPayloadPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> 
>  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
>  .../Universal/SerialDxe/SerialDxe.inf         |  1 +
>  .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
>  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
>  7 files changed, 31 insertions(+), 14 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> 

For patches #1 and #2:

Tested-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42015): https://edk2.groups.io/g/devel/message/42015
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Ard Biesheuvel 2 weeks ago
On Thu, 6 Jun 2019 at 19:16, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 06/06/19 15:14, Anthony PERARD wrote:
> > The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> > once without defining the macro. This patch series define a macro in
> > MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> > EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> >
> > Note that I haven't build/test those changes, but I have test the first patch
> > by applying a similar change to a patch series I'm working on.
> >
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> >
> > Thanks.
> >
> > Anthony PERARD (4):
> >   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >   ArmVirtPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> >   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >     from MdeModulePkg
> >   UefiPayloadPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> >
> >  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
> >  .../Universal/SerialDxe/SerialDxe.inf         |  1 +
> >  .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
> >  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
> >  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
> >  MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
> >  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
> >  7 files changed, 31 insertions(+), 14 deletions(-)
> >  create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> >
>
> For patches #1 and #2:
>
> Tested-by: Laszlo Ersek <lersek@redhat.com>
>

For the series:

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42016): https://edk2.groups.io/g/devel/message/42016
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Laszlo Ersek 1 week ago
On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> 
> Note that I haven't build/test those changes, but I have test the first patch
> by applying a similar change to a patch series I'm working on.
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> 
> Thanks.
> 
> Anthony PERARD (4):
>   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>   ArmVirtPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
>   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>     from MdeModulePkg

Leif, Ard, can you please review patch #3?

>   UefiPayloadPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg

Maurice, Guo, Benjamin, can you please review patch #4?

Thanks,
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42383): https://edk2.groups.io/g/devel/message/42383
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Ma, Maurice 1 week ago
Hi, Laszlo

Thank you for the reminder.   Reviewed patch #4 just now.

Regards,
Maurice
> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Thursday, June 13, 2019 8:32
> To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; Leif Lindholm
> <leif.lindholm@linaro.org>; Ma, Maurice <maurice.ma@intel.com>; Dong,
> Guo <guo.dong@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>;
> Zeng, Star <star.zeng@intel.com>; devel@edk2.groups.io; Anthony Perard
> <anthony.perard@citrix.com>; Julien Grall <julien.grall@arm.com>; Ni, Ray
> <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 0/4] Define
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> 
> On 06/06/19 15:14, Anthony PERARD wrote:
> > The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is
> > been used once without defining the macro. This patch series define a
> > macro in MdeModulePkg where the SerialDxe is, and replace all other
> > use by this new one, EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> >
> > Note that I haven't build/test those changes, but I have test the
> > first patch by applying a similar change to a patch series I'm working on.
> >
> > Patch series available in this git branch:
> > https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> > br.serial-dxe-guid-v2
> >
> > Thanks.
> >
> > Anthony PERARD (4):
> >   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >   ArmVirtPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> >   ArmPkg/PlatformBootManagerLib: Use
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> >     from MdeModulePkg
> 
> Leif, Ard, can you please review patch #3?
> 
> >   UefiPayloadPkg/PlatformBootManagerLib: Use
> >     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> 
> Maurice, Guo, Benjamin, can you please review patch #4?
> 
> Thanks,
> Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42386): https://edk2.groups.io/g/devel/message/42386
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Laszlo Ersek 1 week ago
On 06/13/19 17:32, Laszlo Ersek wrote:
> On 06/06/19 15:14, Anthony PERARD wrote:
>> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
>> once without defining the macro. This patch series define a macro in
>> MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
>> EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
>>
>> Note that I haven't build/test those changes, but I have test the first patch
>> by applying a similar change to a patch series I'm working on.
>>
>> Patch series available in this git branch:
>> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
>>
>> Thanks.
>>
>> Anthony PERARD (4):
>>   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>>   ArmVirtPkg/PlatformBootManagerLib: Use
>>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
>>   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>>     from MdeModulePkg
> 
> Leif, Ard, can you please review patch #3?

Ooops, nevermind, I missed for a moment Ard's ACK for the whole series:

http://mid.mail-archive.com/CAKv+Gu9jx+xgQBfD0DOc+ZLJ1XqKb6=TJDBh09_LUAwdSXs-hg@mail.gmail.com

However,

> 
>>   UefiPayloadPkg/PlatformBootManagerLib: Use
>>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> 
> Maurice, Guo, Benjamin, can you please review patch #4?

the UefiPayloadPkg patch still needs a maintainer A-b or R-b.

Thanks
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42384): https://edk2.groups.io/g/devel/message/42384
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID

Posted by Laszlo Ersek 1 week ago
On 06/06/19 15:14, Anthony PERARD wrote:
> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used
> once without defining the macro. This patch series define a macro in
> MdeModulePkg where the SerialDxe is, and replace all other use by this new one,
> EDKII_SERIAL_PORT_LIB_VENDOR_GUID.
> 
> Note that I haven't build/test those changes, but I have test the first patch
> by applying a similar change to a patch series I'm working on.
> 
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v2
> 
> Thanks.
> 
> Anthony PERARD (4):
>   MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>   ArmVirtPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
>   ArmPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID
>     from MdeModulePkg
>   UefiPayloadPkg/PlatformBootManagerLib: Use
>     EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
> 
>  MdeModulePkg/MdeModulePkg.dec                 |  3 +++
>  .../Universal/SerialDxe/SerialDxe.inf         |  1 +
>  .../Include/Guid/SerialPortLibVendor.h        | 19 +++++++++++++++++++
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  .../PlatformBootManagerLib/PlatformBm.c       |  8 ++------
>  MdeModulePkg/Universal/SerialDxe/SerialIo.c   |  3 ++-
>  .../PlatformBootManagerLib/PlatformConsole.c  |  3 ++-
>  7 files changed, 31 insertions(+), 14 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Guid/SerialPortLibVendor.h
> 

Pushed as commit range b0663641c977..fec63bb922d1.

Thanks!
Laszlo

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#42447): https://edk2.groups.io/g/devel/message/42447
Mute This Topic: https://groups.io/mt/31950872/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-