On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
>
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
This still does not build. It has lots of other errors, but with those
fixes, we still need to set NETWORK_ALLOW_HTTP_CONNECTIONS to TRUE to
retain the old behavior.
I will follow up with a patch that fixes this platform, no need to resend.
> ---
> Platform/Comcast/RDKQemu/RDKQemu.dsc | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> index 64b6699ae7..e73a907891 100644
> --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc
> +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc
> @@ -33,7 +33,7 @@
> # Network definition
> #
> DEFINE NETWORK_SNP_ENABLE = FALSE
> - DEFINE NETWORK_TLS_ENABLE = FALSE
> + DEFINE NETWORK_TLS_ENABLE = TRUE
> DEFINE NETWORK_IP6_ENABLE = FALSE
> DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE
>
> @@ -65,9 +65,6 @@
> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf
> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf
> RdkBootManagerLib|Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.inf
> -!if $(HTTP_BOOT_ENABLE) == TRUE
> - HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf
> -!endif
>
> [LibraryClasses.common.PEIM]
> ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf
> --
> 2.13.0.windows.1
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42082): https://edk2.groups.io/g/devel/message/42082
Mute This Topic: https://groups.io/mt/31819933/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-