Clean up Platform DSC/FDF to refer to NetworkPkg

[edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

Posted by Liming Gao 4 years, 11 months ago

1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
2. Update Update RPi3 DSC/FDF to refer to Network package segment files

These changes are required, because Network modules have been moved into NetworkPkg.

Liming Gao (7):
  BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary
    Network libs
  RDKQemu: Update RDKQemu.dsc to remove unnecessary Network libs
  Hisilicon: Update D06.dsc to remove unnecessary Network libs
  QuarkPlatform: Update Quark dsc to remove unnecessary Network libs
  Vlv2TbltDevicePkg: Update Platform dsc to remove unnecessary Network
    libs
  RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment
    files
  SoftIron: Update Overdrive1000Board.dsc to refer to new Network module
    path

 Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc      |  2 +-
 Platform/Comcast/RDKQemu/RDKQemu.dsc                        |  5 +----
 Platform/Hisilicon/D06/D06.dsc                              |  5 -----
 Platform/Intel/QuarkPlatformPkg/Quark.dsc                   |  4 ----
 Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                |  4 ----
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc      |  2 --
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc        |  4 ----
 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc         |  2 --
 Platform/RaspberryPi/RPi3/RPi3.dsc                          | 30 ++++++++++++++----------------
 Platform/RaspberryPi/RPi3/RPi3.fdf                          | 11 +----------
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc |  2 +-
 11 files changed, 18 insertions(+), 53 deletions(-)

-- 
2.13.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41474): https://edk2.groups.io/g/devel/message/41474
Mute This Topic: https://groups.io/mt/31819930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

Posted by Ard Biesheuvel 4 years, 11 months ago

On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
>
> 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
> 2. Update Update RPi3 DSC/FDF to refer to Network package segment files
>
> These changes are required, because Network modules have been moved into NetworkPkg.
>

Am I understanding correctly that all platforms below are now broken
due to the NetworkPkg changes?


> Liming Gao (7):
>   BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary
>     Network libs
>   RDKQemu: Update RDKQemu.dsc to remove unnecessary Network libs
>   Hisilicon: Update D06.dsc to remove unnecessary Network libs
>   QuarkPlatform: Update Quark dsc to remove unnecessary Network libs
>   Vlv2TbltDevicePkg: Update Platform dsc to remove unnecessary Network
>     libs
>   RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment
>     files
>   SoftIron: Update Overdrive1000Board.dsc to refer to new Network module
>     path
>
>  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc      |  2 +-
>  Platform/Comcast/RDKQemu/RDKQemu.dsc                        |  5 +----
>  Platform/Hisilicon/D06/D06.dsc                              |  5 -----
>  Platform/Intel/QuarkPlatformPkg/Quark.dsc                   |  4 ----
>  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                |  4 ----
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc      |  2 --
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc        |  4 ----
>  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc         |  2 --
>  Platform/RaspberryPi/RPi3/RPi3.dsc                          | 30 ++++++++++++++----------------
>  Platform/RaspberryPi/RPi3/RPi3.fdf                          | 11 +----------
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc |  2 +-
>  11 files changed, 18 insertions(+), 53 deletions(-)
>
> --
> 2.13.0.windows.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41483): https://edk2.groups.io/g/devel/message/41483
Mute This Topic: https://groups.io/mt/31819930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

Posted by Liming Gao 4 years, 11 months ago

> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 28, 2019 6:06 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> 
> On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
> >
> > 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
> > 2. Update Update RPi3 DSC/FDF to refer to Network package segment files
> >
> > These changes are required, because Network modules have been moved into NetworkPkg.
> >
> 
> Am I understanding correctly that all platforms below are now broken
> due to the NetworkPkg changes?
> 
Right. Before the change, I send the patch to update platform DSC/FDF to refer to Network segment files, 
these platform DSC/FDF should not be impacted by Network module movement. 

After push Network module movement, I find I miss some cases in platform DSC/FDF.
So, I send this patch set to clean up the remaining issues. Sorry for the platform break. 

> 
> > Liming Gao (7):
> >   BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary
> >     Network libs
> >   RDKQemu: Update RDKQemu.dsc to remove unnecessary Network libs
> >   Hisilicon: Update D06.dsc to remove unnecessary Network libs
> >   QuarkPlatform: Update Quark dsc to remove unnecessary Network libs
> >   Vlv2TbltDevicePkg: Update Platform dsc to remove unnecessary Network
> >     libs
> >   RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment
> >     files
> >   SoftIron: Update Overdrive1000Board.dsc to refer to new Network module
> >     path
> >
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc      |  2 +-
> >  Platform/Comcast/RDKQemu/RDKQemu.dsc                        |  5 +----
> >  Platform/Hisilicon/D06/D06.dsc                              |  5 -----
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc                   |  4 ----
> >  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                |  4 ----
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc      |  2 --
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc        |  4 ----
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc         |  2 --
> >  Platform/RaspberryPi/RPi3/RPi3.dsc                          | 30 ++++++++++++++----------------
> >  Platform/RaspberryPi/RPi3/RPi3.fdf                          | 11 +----------
> >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc |  2 +-
> >  11 files changed, 18 insertions(+), 53 deletions(-)
> >
> > --
> > 2.13.0.windows.1
> >
> >
> > 
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41491): https://edk2.groups.io/g/devel/message/41491
Mute This Topic: https://groups.io/mt/31819930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

Posted by Ard Biesheuvel 4 years, 11 months ago

On Tue, 28 May 2019 at 13:03, Gao, Liming <liming.gao@intel.com> wrote:
>
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Tuesday, May 28, 2019 6:06 PM
> > To: edk2-devel-groups-io <devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>
> > Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> >
> > On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
> > >
> > > 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
> > > 2. Update Update RPi3 DSC/FDF to refer to Network package segment files
> > >
> > > These changes are required, because Network modules have been moved into NetworkPkg.
> > >
> >
> > Am I understanding correctly that all platforms below are now broken
> > due to the NetworkPkg changes?
> >
> Right. Before the change, I send the patch to update platform DSC/FDF to refer to Network segment files,
> these platform DSC/FDF should not be impacted by Network module movement.
>
> After push Network module movement, I find I miss some cases in platform DSC/FDF.
> So, I send this patch set to clean up the remaining issues. Sorry for the platform break.
>

Core edk2 is broken as well:

https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3562/console

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41492): https://edk2.groups.io/g/devel/message/41492
Mute This Topic: https://groups.io/mt/31819930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

Posted by Liming Gao 4 years, 11 months ago

Ard:
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Tuesday, May 28, 2019 7:12 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>;
> Leif Lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> 
> On Tue, 28 May 2019 at 13:03, Gao, Liming <liming.gao@intel.com> wrote:
> >
> > > -----Original Message-----
> > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > > Sent: Tuesday, May 28, 2019 6:06 PM
> > > To: edk2-devel-groups-io <devel@edk2.groups.io>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>; Laszlo Ersek <lersek@redhat.com>; Leif Lindholm <leif.lindholm@linaro.org>
> > > Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg
> > >
> > > On Tue, 28 May 2019 at 12:00, Liming Gao <liming.gao@intel.com> wrote:
> > > >
> > > > 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them.
> > > > 2. Update Update RPi3 DSC/FDF to refer to Network package segment files
> > > >
> > > > These changes are required, because Network modules have been moved into NetworkPkg.
> > > >
> > >
> > > Am I understanding correctly that all platforms below are now broken
> > > due to the NetworkPkg changes?
> > >
> > Right. Before the change, I send the patch to update platform DSC/FDF to refer to Network segment files,
> > these platform DSC/FDF should not be impacted by Network module movement.
> >
> > After push Network module movement, I find I miss some cases in platform DSC/FDF.
> > So, I send this patch set to clean up the remaining issues. Sorry for the platform break.
> >
> 
> Core edk2 is broken as well:
> 
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/3562/console

Thanks for your note. I scan DSC/FDF again in edk2, and find three missing cases. 
The patches have been sent for review. 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#41502): https://edk2.groups.io/g/devel/message/41502
Mute This Topic: https://groups.io/mt/31819930/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-