Repo:   https://github.com/lersek/edk2.git
Branch: sev_debug_messages

I've now looked at quite a bit of SEV-related DEBUG messages, and I find
them really hard to read, and to process with command line utilities
like grep, sort, uniq.

For example, shell pipelines should be possible to construct with these
utilities to collect decrypt/encrypt operations, in chronological order,
grouped by address ever decrypted.

The log should also be human-readable as much as possible -- it
shouldn't be redundant, but all information for forward- and
back-referencing should be available.

I propose this series for the above improvements.

Cc: Brijesh Singh <brijesh.singh@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>

Thanks,
Laszlo

Laszlo Ersek (11):
  OvmfPkg/BaseMemEncryptSevLib: unify encrypt/decrypt DEBUG messages
  OvmfPkg/BaseMemEncryptSevLib: break DEBUG calls to multiple lines
  OvmfPkg/BaseMemEncryptSevLib: clean up DEBUG prefixes
  OvmfPkg/BaseMemEncryptSevLib: clean up debug logging of
    PhysicalAddress
  OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR
  OvmfPkg/BaseMemEncryptSevLib: clean up upper-case / lower-case in
    DEBUGs
  OvmfPkg/BaseMemEncryptSevLib: fix typos in DEBUG messages
  OvmfPkg/IoMmuDxe: IoMmuMap(): log nicer and more informative DEBUG
    msgs
  OvmfPkg/IoMmuDxe: IoMmuUnmap(): clean up DEBUG message
  OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative
    DEBUGs
  OvmfPkg/IoMmuDxe: IoMmuFreeBuffer(): clean up DEBUG message

 OvmfPkg/IoMmuDxe/AmdSevIoMmu.c                           | 72 +++++++++++-----
 OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 89 ++++++++++++++------
 2 files changed, 110 insertions(+), 51 deletions(-)

-- 
2.14.1.3.gb7cf6e02401b

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

On 08/30/2017 10:53 AM, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: sev_debug_messages
> 
> I've now looked at quite a bit of SEV-related DEBUG messages, and I find
> them really hard to read, and to process with command line utilities
> like grep, sort, uniq.
> 
> For example, shell pipelines should be possible to construct with these
> utilities to collect decrypt/encrypt operations, in chronological order,
> grouped by address ever decrypted.
> 
> The log should also be human-readable as much as possible -- it
> shouldn't be redundant, but all information for forward- and
> back-referencing should be available.
> 
> I propose this series for the above improvements.
> 
> Cc: Brijesh Singh <brijesh.singh@amd.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> 

Very nice improvement in debug message, thank you !

Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
Tested-by: Brijesh Singh <brijesh.singh@amd.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

On 08/31/17 17:14, Brijesh Singh wrote:
> 
> 
> On 08/30/2017 10:53 AM, Laszlo Ersek wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: sev_debug_messages
>>
>> I've now looked at quite a bit of SEV-related DEBUG messages, and I find
>> them really hard to read, and to process with command line utilities
>> like grep, sort, uniq.
>>
>> For example, shell pipelines should be possible to construct with these
>> utilities to collect decrypt/encrypt operations, in chronological order,
>> grouped by address ever decrypted.
>>
>> The log should also be human-readable as much as possible -- it
>> shouldn't be redundant, but all information for forward- and
>> back-referencing should be available.
>>
>> I propose this series for the above improvements.
>>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>
> 
> Very nice improvement in debug message, thank you !
> 
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>
> Tested-by: Brijesh Singh <brijesh.singh@amd.com>

Thank you, pushed as commit range 63ed4d2757eb..1afbb85f8736.

Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel