From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108407790909.8858329022687; Wed, 30 Aug 2017 08:53:27 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id AC5ED21E70D23; Wed, 30 Aug 2017 08:53:21 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99C8E21E47D74 for ; Wed, 30 Aug 2017 08:53:18 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 122CF7EA93; Wed, 30 Aug 2017 15:53:22 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21F878F367; Wed, 30 Aug 2017 15:53:20 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 122CF7EA93 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:07 +0200 Message-Id: <20170830155317.30917-2-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 30 Aug 2017 15:53:22 +0000 (UTC) Subject: [edk2] [PATCH 01/11] OvmfPkg/BaseMemEncryptSevLib: unify encrypt/decrypt DEBUG messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Unify the debug messages between InternalMemEncryptSevSetMemoryEncrypted() and InternalMemEncryptSevSetMemoryDecrypted(). Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 20 ++++++++++++= -------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 7cbbf915f443..dbaad7766dbe 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -239,6 +239,18 @@ SetMemoryEncDec ( UINT64 PgTableMask; UINT64 AddressEncMask; =20 + DEBUG (( + DEBUG_VERBOSE, + "%a:%a: Cr3Base=3D0x%Lx Physical=3D0x%Lx Length=3D0x%Lx Mode=3D%a Cach= eFlush=3D%u\n", + gEfiCallerBaseName, + __FUNCTION__, + Cr3BaseAddress, + PhysicalAddress, + (UINT64)Length, + (Mode =3D=3D SetCBit) ? "Encrypt" : "Decrypt", + (UINT32)CacheFlush + )); + // // Check if we have a valid memory encryption mask // @@ -399,10 +411,6 @@ InternalMemEncryptSevSetMemoryDecrypted ( ) { =20 - DEBUG ((DEBUG_VERBOSE, - "%a:%a Clear C-bit Cr3 %Lx Base %Lx Length %Lx flush %d\n", - gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, Len= gth, - Flush)); return SetMemoryEncDec (Cr3BaseAddress, PhysicalAddress, Length, ClearCB= it, Flush); } =20 @@ -431,9 +439,5 @@ InternalMemEncryptSevSetMemoryEncrypted ( IN BOOLEAN Flush ) { - DEBUG ((DEBUG_VERBOSE, - "%a:%a Set C-bit Cr3 %Lx Base %Lx Length %Lx flush %d\n", - gEfiCallerBaseName, __FUNCTION__, Cr3BaseAddress, PhysicalAddress, Len= gth, - Flush)); return SetMemoryEncDec (Cr3BaseAddress, PhysicalAddress, Length, SetCBit= , Flush); } --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108410179987.09562287164; Wed, 30 Aug 2017 08:53:30 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id EC59B21E70D27; Wed, 30 Aug 2017 08:53:24 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 73C6421E70D22 for ; Wed, 30 Aug 2017 08:53:21 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E60537EA94; Wed, 30 Aug 2017 15:53:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id E923C8F34E; Wed, 30 Aug 2017 15:53:23 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E60537EA94 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:08 +0200 Message-Id: <20170830155317.30917-3-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 30 Aug 2017 15:53:25 +0000 (UTC) Subject: [edk2] [PATCH 02/11] OvmfPkg/BaseMemEncryptSevLib: break DEBUG calls to multiple lines X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" None of the DEBUG macro invocations in SetMemoryEncDec() fit on a single line. Break them to multiple lines, for (a) conforming to the coding style spec, (b) easier modification in later patches. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 68 ++++++++++++= ++------ 1 file changed, 48 insertions(+), 20 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index dbaad7766dbe..83e3d8992173 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -286,18 +286,26 @@ SetMemoryEncDec ( PageMapLevel4Entry =3D (VOID*) (Cr3BaseAddress & ~PgTableMask); PageMapLevel4Entry +=3D PML4_OFFSET(PhysicalAddress); if (!PageMapLevel4Entry->Bits.Present) { - DEBUG ((DEBUG_WARN, - "%a:%a ERROR bad PML4 for %lx\n", gEfiCallerBaseName, __FUNCTION__, - PhysicalAddress)); + DEBUG (( + DEBUG_WARN, + "%a:%a ERROR bad PML4 for %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); return RETURN_NO_MAPPING; } =20 PageDirectory1GEntry =3D (VOID*) ((PageMapLevel4Entry->Bits.PageTableB= aseAddress<<12) & ~PgTableMask); PageDirectory1GEntry +=3D PDP_OFFSET(PhysicalAddress); if (!PageDirectory1GEntry->Bits.Present) { - DEBUG ((DEBUG_WARN, - "%a:%a ERROR bad PDPE for %lx\n", gEfiCallerBaseName, - __FUNCTION__, PhysicalAddress)); + DEBUG (( + DEBUG_WARN, + "%a:%a ERROR bad PDPE for %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); return RETURN_NO_MAPPING; } =20 @@ -311,17 +319,25 @@ SetMemoryEncDec ( // if (!(PhysicalAddress & (BIT30 - 1)) && Length >=3D BIT30) { SetOrClearCBit(&PageDirectory1GEntry->Uint64, Mode); - DEBUG ((DEBUG_VERBOSE, - "%a:%a Updated 1GB entry for %lx\n", gEfiCallerBaseName, - __FUNCTION__, PhysicalAddress)); + DEBUG (( + DEBUG_VERBOSE, + "%a:%a Updated 1GB entry for %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); PhysicalAddress +=3D BIT30; Length -=3D BIT30; } else { // // We must split the page // - DEBUG ((DEBUG_VERBOSE, - "%a:%a Spliting 1GB page\n", gEfiCallerBaseName, __FUNCTION__)); + DEBUG (( + DEBUG_VERBOSE, + "%a:%a Spliting 1GB page\n", + gEfiCallerBaseName, + __FUNCTION__ + )); Split1GPageTo2M(((UINT64)PageDirectory1GEntry->Bits.PageTableBaseA= ddress)<<30, (UINT64*) PageDirectory1GEntry, 0, 0); continue; } @@ -333,9 +349,13 @@ SetMemoryEncDec ( PageDirectory2MEntry =3D (VOID*) ((PageUpperDirectoryPointerEntry->B= its.PageTableBaseAddress<<12) & ~PgTableMask); PageDirectory2MEntry +=3D PDE_OFFSET(PhysicalAddress); if (!PageDirectory2MEntry->Bits.Present) { - DEBUG ((DEBUG_WARN, - "%a:%a ERROR bad PDE for %lx\n", gEfiCallerBaseName, __FUNCTION_= _, - PhysicalAddress)); + DEBUG (( + DEBUG_WARN, + "%a:%a ERROR bad PDE for %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); return RETURN_NO_MAPPING; } // @@ -354,9 +374,13 @@ SetMemoryEncDec ( // // We must split up this page into 4K pages // - DEBUG ((DEBUG_VERBOSE, - "%a:%a Spliting 2MB page at %lx\n", gEfiCallerBaseName,__FUNCT= ION__, - PhysicalAddress)); + DEBUG (( + DEBUG_VERBOSE, + "%a:%a Spliting 2MB page at %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); Split2MPageTo4K (((UINT64)PageDirectory2MEntry->Bits.PageTableBa= seAddress) << 21, (UINT64*) PageDirectory2MEntry, 0, 0); continue; } @@ -365,9 +389,13 @@ SetMemoryEncDec ( PageTableEntry =3D (VOID*) (PageDirectoryPointerEntry->Bits.PageTa= bleBaseAddress<<12 & ~PgTableMask); PageTableEntry +=3D PTE_OFFSET(PhysicalAddress); if (!PageTableEntry->Bits.Present) { - DEBUG ((DEBUG_WARN, - "%a:%a ERROR bad PTE for %lx\n", gEfiCallerBaseName, - __FUNCTION__, PhysicalAddress)); + DEBUG (( + DEBUG_WARN, + "%a:%a ERROR bad PTE for %lx\n", + gEfiCallerBaseName, + __FUNCTION__, + PhysicalAddress + )); return RETURN_NO_MAPPING; } SetOrClearCBit (&PageTableEntry->Uint64, Mode); --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108413206254.5375848520954; Wed, 30 Aug 2017 08:53:33 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3475521E70D30; Wed, 30 Aug 2017 08:53:25 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3FE221D2E630 for ; Wed, 30 Aug 2017 08:53:22 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 32881C0587E8; Wed, 30 Aug 2017 15:53:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 436DA8D564; Wed, 30 Aug 2017 15:53:25 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 32881C0587E8 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:09 +0200 Message-Id: <20170830155317.30917-4-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 30 Aug 2017 15:53:26 +0000 (UTC) Subject: [edk2] [PATCH 03/11] OvmfPkg/BaseMemEncryptSevLib: clean up DEBUG prefixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The prefix for the SetMemoryEncDec() DEBUG messages should be "ModuleName:FunctionName: " not "ModuleName:FunctionName " Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 14 +++++++-----= -- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 83e3d8992173..5e8c9b4c439b 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -288,7 +288,7 @@ SetMemoryEncDec ( if (!PageMapLevel4Entry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a ERROR bad PML4 for %lx\n", + "%a:%a: ERROR bad PML4 for %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -301,7 +301,7 @@ SetMemoryEncDec ( if (!PageDirectory1GEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a ERROR bad PDPE for %lx\n", + "%a:%a: ERROR bad PDPE for %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -321,7 +321,7 @@ SetMemoryEncDec ( SetOrClearCBit(&PageDirectory1GEntry->Uint64, Mode); DEBUG (( DEBUG_VERBOSE, - "%a:%a Updated 1GB entry for %lx\n", + "%a:%a: Updated 1GB entry for %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -334,7 +334,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a Spliting 1GB page\n", + "%a:%a: Spliting 1GB page\n", gEfiCallerBaseName, __FUNCTION__ )); @@ -351,7 +351,7 @@ SetMemoryEncDec ( if (!PageDirectory2MEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a ERROR bad PDE for %lx\n", + "%a:%a: ERROR bad PDE for %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -376,7 +376,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a Spliting 2MB page at %lx\n", + "%a:%a: Spliting 2MB page at %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -391,7 +391,7 @@ SetMemoryEncDec ( if (!PageTableEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a ERROR bad PTE for %lx\n", + "%a:%a: ERROR bad PTE for %lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108416254331.6055178104042; Wed, 30 Aug 2017 08:53:36 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 702B821E70D34; Wed, 30 Aug 2017 08:53:28 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0458021D2E630 for ; Wed, 30 Aug 2017 08:53:24 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76B2A7E43F; Wed, 30 Aug 2017 15:53:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 86C588D543; Wed, 30 Aug 2017 15:53:26 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 76B2A7E43F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:10 +0200 Message-Id: <20170830155317.30917-5-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 30 Aug 2017 15:53:27 +0000 (UTC) Subject: [edk2] [PATCH 04/11] OvmfPkg/BaseMemEncryptSevLib: clean up debug logging of PhysicalAddress X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In the SetMemoryEncDec() function, the way we currently report PhysicalAddress is not uniform: - mostly we say "for %lx", - in one spot we say "at %lx" (even though the 2MB page being split does not live *at* PhysicalAddress, instead it maps PhysicalAddress), - in another spot we don't log PhysicalAddress at all (when splitting a 1GB page). Unify this, using the format string "for Physical=3D0x%Lx". Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 17 +++++++++---= ----- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 5e8c9b4c439b..58c793dae6bf 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -288,7 +288,7 @@ SetMemoryEncDec ( if (!PageMapLevel4Entry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a: ERROR bad PML4 for %lx\n", + "%a:%a: ERROR bad PML4 for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -301,7 +301,7 @@ SetMemoryEncDec ( if (!PageDirectory1GEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a: ERROR bad PDPE for %lx\n", + "%a:%a: ERROR bad PDPE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -321,7 +321,7 @@ SetMemoryEncDec ( SetOrClearCBit(&PageDirectory1GEntry->Uint64, Mode); DEBUG (( DEBUG_VERBOSE, - "%a:%a: Updated 1GB entry for %lx\n", + "%a:%a: Updated 1GB entry for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -334,9 +334,10 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: Spliting 1GB page\n", + "%a:%a: Spliting 1GB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, - __FUNCTION__ + __FUNCTION__, + PhysicalAddress )); Split1GPageTo2M(((UINT64)PageDirectory1GEntry->Bits.PageTableBaseA= ddress)<<30, (UINT64*) PageDirectory1GEntry, 0, 0); continue; @@ -351,7 +352,7 @@ SetMemoryEncDec ( if (!PageDirectory2MEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a: ERROR bad PDE for %lx\n", + "%a:%a: ERROR bad PDE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -376,7 +377,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: Spliting 2MB page at %lx\n", + "%a:%a: Spliting 2MB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -391,7 +392,7 @@ SetMemoryEncDec ( if (!PageTableEntry->Bits.Present) { DEBUG (( DEBUG_WARN, - "%a:%a: ERROR bad PTE for %lx\n", + "%a:%a: ERROR bad PTE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108419401779.6568979979575; Wed, 30 Aug 2017 08:53:39 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id A80B021E70D38; Wed, 30 Aug 2017 08:53:28 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5654C21E70D34 for ; Wed, 30 Aug 2017 08:53:25 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BC3D35D687; Wed, 30 Aug 2017 15:53:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id C95718F356; Wed, 30 Aug 2017 15:53:27 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com BC3D35D687 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:11 +0200 Message-Id: <20170830155317.30917-6-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 15:53:28 +0000 (UTC) Subject: [edk2] [PATCH 05/11] OvmfPkg/BaseMemEncryptSevLib: promote DEBUG_WARN levels to DEBUG_ERROR X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" In SetMemoryEncDec(), we have four locations where we (a) log a message on the DEBUG_WARN level that says "ERROR", (b) return the status code RETURN_NO_MAPPING right after. These messages clearly describe actual errors (bad PML4, PDPE, PDE, PTE). Promote their debug levels to DEBUG_ERROR, and remove the word "ERROR" from the messages. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 16 ++++++++----= ---- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 58c793dae6bf..c37d799bc1f4 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -287,8 +287,8 @@ SetMemoryEncDec ( PageMapLevel4Entry +=3D PML4_OFFSET(PhysicalAddress); if (!PageMapLevel4Entry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PML4 for Physical=3D0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PML4 for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -300,8 +300,8 @@ SetMemoryEncDec ( PageDirectory1GEntry +=3D PDP_OFFSET(PhysicalAddress); if (!PageDirectory1GEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDPE for Physical=3D0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDPE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -351,8 +351,8 @@ SetMemoryEncDec ( PageDirectory2MEntry +=3D PDE_OFFSET(PhysicalAddress); if (!PageDirectory2MEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PDE for Physical=3D0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PDE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -391,8 +391,8 @@ SetMemoryEncDec ( PageTableEntry +=3D PTE_OFFSET(PhysicalAddress); if (!PageTableEntry->Bits.Present) { DEBUG (( - DEBUG_WARN, - "%a:%a: ERROR bad PTE for Physical=3D0x%Lx\n", + DEBUG_ERROR, + "%a:%a: bad PTE for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108423053774.3340061404766; Wed, 30 Aug 2017 08:53:43 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id DF6D921E70D3F; Wed, 30 Aug 2017 08:53:28 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9276321E70D26 for ; Wed, 30 Aug 2017 08:53:26 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0B11F20276; Wed, 30 Aug 2017 15:53:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18C378F356; Wed, 30 Aug 2017 15:53:28 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0B11F20276 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:12 +0200 Message-Id: <20170830155317.30917-7-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Wed, 30 Aug 2017 15:53:30 +0000 (UTC) Subject: [edk2] [PATCH 06/11] OvmfPkg/BaseMemEncryptSevLib: clean up upper-case / lower-case in DEBUGs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Debug messages that start as natural (English) language phrases (after the debug prefix) should uniformly begin with lower-case or upper-case. In SetMemoryEncDec() we have a mixture now. Stick with lower-case. (Upper-case is better for full sentences that also end with punctuation.) Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index c37d799bc1f4..96969617e0a3 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -321,7 +321,7 @@ SetMemoryEncDec ( SetOrClearCBit(&PageDirectory1GEntry->Uint64, Mode); DEBUG (( DEBUG_VERBOSE, - "%a:%a: Updated 1GB entry for Physical=3D0x%Lx\n", + "%a:%a: updated 1GB entry for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -334,7 +334,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: Spliting 1GB page for Physical=3D0x%Lx\n", + "%a:%a: spliting 1GB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -377,7 +377,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: Spliting 2MB page for Physical=3D0x%Lx\n", + "%a:%a: spliting 2MB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108426385636.372571514261; Wed, 30 Aug 2017 08:53:46 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 2A0B721E70D4E; Wed, 30 Aug 2017 08:53:33 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D4E5D21D2E630 for ; Wed, 30 Aug 2017 08:53:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B3A1806BE; Wed, 30 Aug 2017 15:53:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C8B98F34E; Wed, 30 Aug 2017 15:53:30 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4B3A1806BE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:13 +0200 Message-Id: <20170830155317.30917-8-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 30 Aug 2017 15:53:31 +0000 (UTC) Subject: [edk2] [PATCH 07/11] OvmfPkg/BaseMemEncryptSevLib: fix typos in DEBUG messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Replace "spliting" with "splitting". Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c b/Ovm= fPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c index 96969617e0a3..e1e705c34626 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/VirtualMemory.c @@ -334,7 +334,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: spliting 1GB page for Physical=3D0x%Lx\n", + "%a:%a: splitting 1GB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress @@ -377,7 +377,7 @@ SetMemoryEncDec ( // DEBUG (( DEBUG_VERBOSE, - "%a:%a: spliting 2MB page for Physical=3D0x%Lx\n", + "%a:%a: splitting 2MB page for Physical=3D0x%Lx\n", gEfiCallerBaseName, __FUNCTION__, PhysicalAddress --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108430504273.21739167994554; Wed, 30 Aug 2017 08:53:50 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6B35C2095BB60; Wed, 30 Aug 2017 08:53:33 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C6BE21E70D2B for ; Wed, 30 Aug 2017 08:53:29 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8DEFF81DFA; Wed, 30 Aug 2017 15:53:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D8D98D564; Wed, 30 Aug 2017 15:53:31 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8DEFF81DFA Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:14 +0200 Message-Id: <20170830155317.30917-9-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 30 Aug 2017 15:53:32 +0000 (UTC) Subject: [edk2] [PATCH 08/11] OvmfPkg/IoMmuDxe: IoMmuMap(): log nicer and more informative DEBUG msgs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Log all relevant IN and IN OUT parameters on entry. When exiting with success, log all relevant OUT and IN OUT parameters. Don't log OUT and IN OUT parameters that are never set or changed after entering the function (i.e., *NumberOfBytes). Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 31 ++++++++++++++++++-- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c index ec625166f459..59cee95c0e21 100644 --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c @@ -44,6 +44,19 @@ STATIC LIST_ENTRY mRecycledMapInfos =3D INITIALIZE_LIST_= HEAD_VARIABLE ( =20 #define COMMON_BUFFER_SIG SIGNATURE_64 ('C', 'M', 'N', 'B', 'U', 'F', 'F',= 'R') =20 +// +// ASCII names for EDKII_IOMMU_OPERATION constants, for debug logging. +// +STATIC CONST CHAR8 * CONST +mBusMasterOperationName[EdkiiIoMmuOperationMaximum] =3D { + "Read", + "Write", + "CommonBuffer", + "Read64", + "Write64", + "CommonBuffer64" +}; + // // The following structure enables Map() and Unmap() to perform in-place // decryption and encryption, respectively, for BusMasterCommonBuffer[64] @@ -116,6 +129,18 @@ IoMmuMap ( COMMON_BUFFER_HEADER *CommonBufferHeader; VOID *DecryptionSource; =20 + DEBUG (( + DEBUG_VERBOSE, + "%a: Operation=3D%a Host=3D0x%p Bytes=3D0x%Lx\n", + __FUNCTION__, + ((Operation >=3D 0 && + Operation < ARRAY_SIZE (mBusMasterOperationName)) ? + mBusMasterOperationName[Operation] : + "Invalid"), + HostAddress, + (UINT64)((NumberOfBytes =3D=3D NULL) ? 0 : *NumberOfBytes) + )); + if (HostAddress =3D=3D NULL || NumberOfBytes =3D=3D NULL || DeviceAddres= s =3D=3D NULL || Mapping =3D=3D NULL) { return EFI_INVALID_PARAMETER; @@ -281,12 +306,12 @@ IoMmuMap ( =20 DEBUG (( DEBUG_VERBOSE, - "%a PlainText 0x%Lx Crypted 0x%Lx Pages 0x%Lx Bytes 0x%Lx\n", + "%a: Mapping=3D0x%p Device(PlainText)=3D0x%Lx Crypted=3D0x%Lx Pages=3D= 0x%Lx\n", __FUNCTION__, + MapInfo, MapInfo->PlainTextAddress, MapInfo->CryptedAddress, - (UINT64)MapInfo->NumberOfPages, - (UINT64)MapInfo->NumberOfBytes + (UINT64)MapInfo->NumberOfPages )); =20 return EFI_SUCCESS; --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108434326100.11567859950742; Wed, 30 Aug 2017 08:53:54 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id ABBBB2095BB65; Wed, 30 Aug 2017 08:53:33 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BEFA21E70D26 for ; Wed, 30 Aug 2017 08:53:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7E88861486; Wed, 30 Aug 2017 15:53:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF91C8D543; Wed, 30 Aug 2017 15:53:32 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7E88861486 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:15 +0200 Message-Id: <20170830155317.30917-10-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 30 Aug 2017 15:53:34 +0000 (UTC) Subject: [edk2] [PATCH 09/11] OvmfPkg/IoMmuDxe: IoMmuUnmap(): clean up DEBUG message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The only important external information for this function, and for the human looking at the log, is the Mapping input parameter. Log it on entry. Stop logging the contents of the MAP_INFO structure pointed-to by Mapping. Thanks to the previous patch, we can now associate IoMmuUnmap() messages with IoMmuMap() messages -- and thereby with MAP_INFO contents -- purely via Mapping. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c index 59cee95c0e21..a153d250d545 100644 --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c @@ -348,6 +348,8 @@ IoMmuUnmap ( COMMON_BUFFER_HEADER *CommonBufferHeader; VOID *EncryptionTarget; =20 + DEBUG ((DEBUG_VERBOSE, "%a: Mapping=3D0x%p\n", __FUNCTION__, Mapping)); + if (Mapping =3D=3D NULL) { return EFI_INVALID_PARAMETER; } @@ -399,16 +401,6 @@ IoMmuUnmap ( break; } =20 - DEBUG (( - DEBUG_VERBOSE, - "%a PlainText 0x%Lx Crypted 0x%Lx Pages 0x%Lx Bytes 0x%Lx\n", - __FUNCTION__, - MapInfo->PlainTextAddress, - MapInfo->CryptedAddress, - (UINT64)MapInfo->NumberOfPages, - (UINT64)MapInfo->NumberOfBytes - )); - // // Restore the memory encryption mask on the area we used to hold the // plaintext. --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108439286411.8083666266158; Wed, 30 Aug 2017 08:53:59 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id E88D02095BB68; Wed, 30 Aug 2017 08:53:35 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 339A221E70D26 for ; Wed, 30 Aug 2017 08:53:32 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A66ADC0587E6; Wed, 30 Aug 2017 15:53:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id B87378D543; Wed, 30 Aug 2017 15:53:34 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A66ADC0587E6 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:16 +0200 Message-Id: <20170830155317.30917-11-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 30 Aug 2017 15:53:35 +0000 (UTC) Subject: [edk2] [PATCH 10/11] OvmfPkg/IoMmuDxe: IoMmuAllocateBuffer(): nicer and more informative DEBUGs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Log all relevant IN and IN OUT parameters on entry. (Note that the HostAddress parameter is IN OUT rather than OUT due to historical reasons. The "IN EFI_ALLOCATE_TYPE Type" parameter is now to be ignored, but historically it could be set to AllocateMaxAddress for example, and for that HostAddress had to be IN OUT.) When exiting with success, log all relevant OUT parameters (i.e., HostAddress). Also log the new (internal) StashBuffer address, on which IoMmuMap() and IoMmuUnmap() rely on, for BusMasterCommonBuffer operations (in-place decryption and encryption, respectively). Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c index a153d250d545..0ab7043498bd 100644 --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c @@ -490,6 +490,15 @@ IoMmuAllocateBuffer ( UINTN CommonBufferPages; COMMON_BUFFER_HEADER *CommonBufferHeader; =20 + DEBUG (( + DEBUG_VERBOSE, + "%a: MemoryType=3D%u Pages=3D0x%Lx Attributes=3D0x%Lx\n", + __FUNCTION__, + (UINT32)MemoryType, + (UINT64)Pages, + Attributes + )); + // // Validate Attributes // @@ -566,10 +575,10 @@ IoMmuAllocateBuffer ( =20 DEBUG (( DEBUG_VERBOSE, - "%a Address 0x%Lx Pages 0x%Lx\n", + "%a: Host=3D0x%Lx Stash=3D0x%p\n", __FUNCTION__, PhysicalAddress, - (UINT64)Pages + StashBuffer )); return EFI_SUCCESS; =20 --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel From nobody Wed May 1 22:42:19 2024 Delivered-To: importer@patchew.org Received-SPF: none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) client-ip=198.145.21.10; envelope-from=edk2-devel-bounces@lists.01.org; helo=ml01.01.org; Authentication-Results: mx.zohomail.com; spf=none (zoho.com: 198.145.21.10 is neither permitted nor denied by domain of lists.01.org) smtp.mailfrom=edk2-devel-bounces@lists.01.org Return-Path: Received: from ml01.01.org (ml01.01.org [198.145.21.10]) by mx.zohomail.com with SMTPS id 1504108443175463.2115657710882; Wed, 30 Aug 2017 08:54:03 -0700 (PDT) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 25E242095BB6C; Wed, 30 Aug 2017 08:53:36 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 777962095BB62 for ; Wed, 30 Aug 2017 08:53:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E97DB883AC; Wed, 30 Aug 2017 15:53:36 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-136.rdu2.redhat.com [10.10.120.136]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0476F8D543; Wed, 30 Aug 2017 15:53:35 +0000 (UTC) X-Original-To: edk2-devel@lists.01.org DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E97DB883AC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com From: Laszlo Ersek To: edk2-devel-01 Date: Wed, 30 Aug 2017 17:53:17 +0200 Message-Id: <20170830155317.30917-12-lersek@redhat.com> In-Reply-To: <20170830155317.30917-1-lersek@redhat.com> References: <20170830155317.30917-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 30 Aug 2017 15:53:37 +0000 (UTC) Subject: [edk2] [PATCH 11/11] OvmfPkg/IoMmuDxe: IoMmuFreeBuffer(): clean up DEBUG message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jordan Justen MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" X-ZohoMail: RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" Log all relevant IN parameters on entry. (There are only IN parameters.) Beautify the format string. Cc: Brijesh Singh Cc: Jordan Justen Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek Reviewed-by: Brijesh Singh Tested-by: Brijesh Singh --- OvmfPkg/IoMmuDxe/AmdSevIoMmu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c index 0ab7043498bd..bc57de5b572b 100644 --- a/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c +++ b/OvmfPkg/IoMmuDxe/AmdSevIoMmu.c @@ -611,6 +611,14 @@ IoMmuFreeBuffer ( UINTN CommonBufferPages; COMMON_BUFFER_HEADER *CommonBufferHeader; =20 + DEBUG (( + DEBUG_VERBOSE, + "%a: Host=3D0x%p Pages=3D0x%Lx\n", + __FUNCTION__, + HostAddress, + (UINT64)Pages + )); + CommonBufferPages =3D Pages + 1; CommonBufferHeader =3D (COMMON_BUFFER_HEADER *)( (UINTN)HostAddress - EFI_PAGE_SIZE @@ -630,14 +638,6 @@ IoMmuFreeBuffer ( // FreePages (CommonBufferHeader->StashBuffer, Pages); =20 - DEBUG (( - DEBUG_VERBOSE, - "%a Address 0x%Lx Pages 0x%Lx\n", - __FUNCTION__, - (UINT64)(UINTN)HostAddress, - (UINT64)Pages - )); - // // Release the common buffer itself. Unmap() has re-encrypted it in-plac= e, so // no need to zero it. --=20 2.14.1.3.gb7cf6e02401b _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel