[edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

Wasim Khan posted 16 patches 3 days ago
Failed in applying to current master (apply log)
Silicon/NXP/NxpQoriqLs.dec                         |  13 +
Silicon/NXP/LS1043A/LS1043A.dsc.inc                |   8 +
Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |  20 +
Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |  20 +-
Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf  |  40 +
.../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  45 ++
.../NXP/Library/PciSegmentLib/PciSegmentLib.inf    |  36 +
Silicon/NXP/Include/Pcie.h                         | 231 ++++++
Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c    | 628 +++++++++++++++
.../Library/PciHostBridgeLib/PciHostBridgeLib.c    | 842 +++++++++++++++++++++
Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c  | 699 +++++++++++++++++
11 files changed, 2579 insertions(+), 3 deletions(-)
create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
create mode 100755 Silicon/NXP/Include/Pcie.h
create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c

[edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

Posted by Wasim Khan 3 days ago
From: Wasim Khan <wasim.khan@nxp.com>

Add PCIe Support for NXP Layerscape SoC which supports
different PCIe controllers.
Use generic PCIe drivers and wire up PciHostBridgeLib,
PciSegmentLib and PciCpuIo2Dxe driver for controller
specific implementation.

Wasim Khan (16):
  Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.
  Silicon/NXP: LS1043A: Define PCIe related PCDs
  Silicon/NXP: Implement PciHostBridgeLib support
  Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS
    Ctrl
  Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU
    Windows
  Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451
  Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows
  Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows
  Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller
  Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS
    Controller
  Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller
  Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264
  Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver
  Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
  Platform/NXP: LS1043aRdbPkg: Enable PCIE support
  Platform/NXP: LS1043aRdbPkg : Increase fv image size

 Silicon/NXP/NxpQoriqLs.dec                         |  13 +
 Silicon/NXP/LS1043A/LS1043A.dsc.inc                |   8 +
 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |  20 +
 Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |  20 +-
 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf  |  40 +
 .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  45 ++
 .../NXP/Library/PciSegmentLib/PciSegmentLib.inf    |  36 +
 Silicon/NXP/Include/Pcie.h                         | 231 ++++++
 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c    | 628 +++++++++++++++
 .../Library/PciHostBridgeLib/PciHostBridgeLib.c    | 842 +++++++++++++++++++++
 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c  | 699 +++++++++++++++++
 11 files changed, 2579 insertions(+), 3 deletions(-)
 create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
 create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
 create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
 create mode 100755 Silicon/NXP/Include/Pcie.h
 create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
 create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
 create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60116): https://edk2.groups.io/g/devel/message/60116
Mute This Topic: https://groups.io/mt/74395799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

Posted by Ard Biesheuvel 3 days ago
On 5/22/20 1:02 AM, Wasim Khan wrote:
> From: Wasim Khan <wasim.khan@nxp.com>
> 
> Add PCIe Support for NXP Layerscape SoC which supports
> different PCIe controllers.
> Use generic PCIe drivers and wire up PciHostBridgeLib,
> PciSegmentLib and PciCpuIo2Dxe driver for controller
> specific implementation.
> 

Thanks. This is looking good. Please take a look at the feedback, and 
give others some time to respond as well.

In the meantime, I think we can simply merge #14 and #16 right away 
(unless Leif has any objections)


> Wasim Khan (16):
>    Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.
>    Silicon/NXP: LS1043A: Define PCIe related PCDs
>    Silicon/NXP: Implement PciHostBridgeLib support
>    Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS
>      Ctrl
>    Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU
>      Windows
>    Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451
>    Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows
>    Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows
>    Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller
>    Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS
>      Controller
>    Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller
>    Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264
>    Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver
>    Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
>    Platform/NXP: LS1043aRdbPkg: Enable PCIE support
>    Platform/NXP: LS1043aRdbPkg : Increase fv image size
> 
>   Silicon/NXP/NxpQoriqLs.dec                         |  13 +
>   Silicon/NXP/LS1043A/LS1043A.dsc.inc                |   8 +
>   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |  20 +
>   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |  20 +-
>   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf  |  40 +
>   .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  45 ++
>   .../NXP/Library/PciSegmentLib/PciSegmentLib.inf    |  36 +
>   Silicon/NXP/Include/Pcie.h                         | 231 ++++++
>   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c    | 628 +++++++++++++++
>   .../Library/PciHostBridgeLib/PciHostBridgeLib.c    | 842 +++++++++++++++++++++
>   Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c  | 699 +++++++++++++++++
>   11 files changed, 2579 insertions(+), 3 deletions(-)
>   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
>   create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
>   create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
>   create mode 100755 Silicon/NXP/Include/Pcie.h
>   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
>   create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
>   create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60106): https://edk2.groups.io/g/devel/message/60106
Mute This Topic: https://groups.io/mt/74395799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

Posted by Leif Lindholm 2 days ago
On Fri, May 22, 2020 at 11:46:07 +0200, Ard Biesheuvel wrote:
> On 5/22/20 1:02 AM, Wasim Khan wrote:
> > From: Wasim Khan <wasim.khan@nxp.com>
> > 
> > Add PCIe Support for NXP Layerscape SoC which supports
> > different PCIe controllers.
> > Use generic PCIe drivers and wire up PciHostBridgeLib,
> > PciSegmentLib and PciCpuIo2Dxe driver for controller
> > specific implementation.
> > 
> 
> Thanks. This is looking good. Please take a look at the feedback, and give
> others some time to respond as well.
> 
> In the meantime, I think we can simply merge #14 and #16 right away (unless
> Leif has any objections)

(Looking at those two out of order.)
16, sure.
14 - is there any reason to do so before there is PCI to connect
network devices through?

/
    Leif

> 
> > Wasim Khan (16):
> >    Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.
> >    Silicon/NXP: LS1043A: Define PCIe related PCDs
> >    Silicon/NXP: Implement PciHostBridgeLib support
> >    Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS
> >      Ctrl
> >    Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU
> >      Windows
> >    Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451
> >    Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows
> >    Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows
> >    Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller
> >    Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS
> >      Controller
> >    Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller
> >    Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264
> >    Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver
> >    Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
> >    Platform/NXP: LS1043aRdbPkg: Enable PCIE support
> >    Platform/NXP: LS1043aRdbPkg : Increase fv image size
> > 
> >   Silicon/NXP/NxpQoriqLs.dec                         |  13 +
> >   Silicon/NXP/LS1043A/LS1043A.dsc.inc                |   8 +
> >   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |  20 +
> >   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |  20 +-
> >   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf  |  40 +
> >   .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  45 ++
> >   .../NXP/Library/PciSegmentLib/PciSegmentLib.inf    |  36 +
> >   Silicon/NXP/Include/Pcie.h                         | 231 ++++++
> >   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c    | 628 +++++++++++++++
> >   .../Library/PciHostBridgeLib/PciHostBridgeLib.c    | 842 +++++++++++++++++++++
> >   Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c  | 699 +++++++++++++++++
> >   11 files changed, 2579 insertions(+), 3 deletions(-)
> >   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
> >   create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> >   create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
> >   create mode 100755 Silicon/NXP/Include/Pcie.h
> >   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
> >   create mode 100644 Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
> >   create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c
> > 
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60130): https://edk2.groups.io/g/devel/message/60130
Mute This Topic: https://groups.io/mt/74395799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

Posted by Wasim Khan (OSS) 16 hours ago

> -----Original Message-----
> From: Leif Lindholm <leif@nuviainc.com>
> Sent: Friday, May 22, 2020 4:29 PM
> To: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Wasim Khan (OSS) <wasim.khan@oss.nxp.com>; devel@edk2.groups.io;
> Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; Vabhav Sharma
> <vabhav.sharma@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; jon@solid-
> run.com; Wasim Khan <wasim.khan@nxp.com>
> Subject: Re: [PATCH edk2-platforms 00/16] Add PCIe Support
> 
> On Fri, May 22, 2020 at 11:46:07 +0200, Ard Biesheuvel wrote:
> > On 5/22/20 1:02 AM, Wasim Khan wrote:
> > > From: Wasim Khan <wasim.khan@nxp.com>
> > >
> > > Add PCIe Support for NXP Layerscape SoC which supports different
> > > PCIe controllers.
> > > Use generic PCIe drivers and wire up PciHostBridgeLib, PciSegmentLib
> > > and PciCpuIo2Dxe driver for controller specific implementation.
> > >
> >
> > Thanks. This is looking good. Please take a look at the feedback, and
> > give others some time to respond as well.
> >

Thank you so much Ard for your review and comments. 
I have incorporated all your comments and waiting to push the V2 once I close on the some open items. 


> > In the meantime, I think we can simply merge #14 and #16 right away
> > (unless Leif has any objections)
> 
> (Looking at those two out of order.)
> 16, sure.
> 14 - is there any reason to do so before there is PCI to connect network devices
> through?
> 
> /
>     Leif
> 
> >
> > > Wasim Khan (16):
> > >    Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.
> > >    Silicon/NXP: LS1043A: Define PCIe related PCDs
> > >    Silicon/NXP: Implement PciHostBridgeLib support
> > >    Silicon/NXP: PciHostBridgeLib: CFG Shift feature support for PCIeLS
> > >      Ctrl
> > >    Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU
> > >      Windows
> > >    Silicon/NXP: PciHostBridgeLib: add Workaround for A-011451
> > >    Silicon/NXP: PciHostBridgeLib: Dump Layerscale Gen4 ATU windows
> > >    Silicon/NXP: PciHostBridgeLib: Dump Layerscale iATU windows
> > >    Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller
> > >    Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS
> > >      Controller
> > >    Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller
> > >    Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264
> > >    Silicon/NXP/Drivers: Implement PciCpuIo2Dxe Driver
> > >    Platform/NXP: LS1043aRdbPkg: Enable NetworkPkg
> > >    Platform/NXP: LS1043aRdbPkg: Enable PCIE support
> > >    Platform/NXP: LS1043aRdbPkg : Increase fv image size
> > >
> > >   Silicon/NXP/NxpQoriqLs.dec                         |  13 +
> > >   Silicon/NXP/LS1043A/LS1043A.dsc.inc                |   8 +
> > >   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc       |  20 +
> > >   Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf       |  20 +-
> > >   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf  |  40 +
> > >   .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  45 ++
> > >   .../NXP/Library/PciSegmentLib/PciSegmentLib.inf    |  36 +
> > >   Silicon/NXP/Include/Pcie.h                         | 231 ++++++
> > >   Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c    | 628
> +++++++++++++++
> > >   .../Library/PciHostBridgeLib/PciHostBridgeLib.c    | 842
> +++++++++++++++++++++
> > >   Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c  | 699
> +++++++++++++++++
> > >   11 files changed, 2579 insertions(+), 3 deletions(-)
> > >   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.inf
> > >   create mode 100644
> Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> > >   create mode 100755 Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.inf
> > >   create mode 100755 Silicon/NXP/Include/Pcie.h
> > >   create mode 100755 Silicon/NXP/Drivers/PciCpuIo2Dxe/PciCpuIo2Dxe.c
> > >   create mode 100644
> Silicon/NXP/Library/PciHostBridgeLib/PciHostBridgeLib.c
> > >   create mode 100755
> > > Silicon/NXP/Library/PciSegmentLib/PciSegmentLib.c
> > >
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60192): https://edk2.groups.io/g/devel/message/60192
Mute This Topic: https://groups.io/mt/74395799/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-