[edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements

Marcin Wojtas posted 4 patches 5 years ago
Failed in applying to current master (apply log)
Silicon/Marvell/Marvell.dec                                 |   7 +-
Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  18 ++-
Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |   3 -
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf           |  14 +-
Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |   5 +-
Silicon/Marvell/Drivers/Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf |   5 +-
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.h             |   1 +
Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c             | 149 +++++++++++++++-----
8 files changed, 140 insertions(+), 62 deletions(-)
[edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Marcin Wojtas 5 years ago
Hi,

The third version of the patchset cleans up the dependencies between
the SPI drivers, so that now they explicitly rely on the protocols'
instead of BEFORE statements and modules GUIDs. Also force dependency
between FTW and MvFvbDxe using library NULL resolution.

The patches are available in the github:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/fvb-upstream-r20190425

I'm looking forward to your comments or remarks.

Best regards,
Marcin

Changelog:
v2->v3

3/4 (new patch)
 * Clean-up MvSpiFlashDxe / MvSpiOrionDxe / MvFvbDxe dependencies and
   rely on the protocols' GUIDs

4/4
 * Force dependency for loading FTW driver

v1->v2
 * Replace clock-enabling patch with PEI phase FV cleanup

Hanna Hawa (1):
  Marvell/Drivers: MvFvbDxe: Change Pcd parameters to be 64 bit

Kornel Duleba (1):
  Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode

Marcin Wojtas (2):
  Marvell/Armada7k8k: Cleanup PEI phase FV
  Marvell/Drivers/Spi: Improve modules dependencies

 Silicon/Marvell/Marvell.dec                                 |   7 +-
 Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  18 ++-
 Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |   3 -
 Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf           |  14 +-
 Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |   5 +-
 Silicon/Marvell/Drivers/Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf |   5 +-
 Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.h             |   1 +
 Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c             | 149 +++++++++++++++-----
 8 files changed, 140 insertions(+), 62 deletions(-)

-- 
2.7.4


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39542): https://edk2.groups.io/g/devel/message/39542
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Leif Lindholm 5 years ago
Hi Marcin,

Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet
been relicensed, so we still need "contributed-under" here.

For this series, can you confirm to the list that this is indeed
Contributed-under: TianoCore Contribution Agreement 1.1
? If so, we can fix that up before committing.

I'll start looking into what we need to do for a license transition
for edk2-platforms master next week.

Best Regards,

Leif

On Thu, Apr 25, 2019 at 01:28:20PM +0200, Marcin Wojtas wrote:
> Hi,
> 
> The third version of the patchset cleans up the dependencies between
> the SPI drivers, so that now they explicitly rely on the protocols'
> instead of BEFORE statements and modules GUIDs. Also force dependency
> between FTW and MvFvbDxe using library NULL resolution.
> 
> The patches are available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/fvb-upstream-r20190425
> 
> I'm looking forward to your comments or remarks.
> 
> Best regards,
> Marcin
> 
> Changelog:
> v2->v3
> 
> 3/4 (new patch)
>  * Clean-up MvSpiFlashDxe / MvSpiOrionDxe / MvFvbDxe dependencies and
>    rely on the protocols' GUIDs
> 
> 4/4
>  * Force dependency for loading FTW driver
> 
> v1->v2
>  * Replace clock-enabling patch with PEI phase FV cleanup
> 
> Hanna Hawa (1):
>   Marvell/Drivers: MvFvbDxe: Change Pcd parameters to be 64 bit
> 
> Kornel Duleba (1):
>   Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode
> 
> Marcin Wojtas (2):
>   Marvell/Armada7k8k: Cleanup PEI phase FV
>   Marvell/Drivers/Spi: Improve modules dependencies
> 
>  Silicon/Marvell/Marvell.dec                                 |   7 +-
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  18 ++-
>  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |   3 -
>  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf           |  14 +-
>  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |   5 +-
>  Silicon/Marvell/Drivers/Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf |   5 +-
>  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.h             |   1 +
>  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c             | 149 +++++++++++++++-----
>  8 files changed, 140 insertions(+), 62 deletions(-)
> 
> -- 
> 2.7.4
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39547): https://edk2.groups.io/g/devel/message/39547
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Marcin Wojtas 5 years ago
Hi Leif,

czw., 25 kwi 2019 o 14:01 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> Hi Marcin,
>
> Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet
> been relicensed, so we still need "contributed-under" here.
>
> For this series, can you confirm to the list that this is indeed
> Contributed-under: TianoCore Contribution Agreement 1.1
> ? If so, we can fix that up before committing.
>

Yes, I confirm that - if possible fix-up. Actually I removed those
lines right before sending :)

Best regards,
Marcin

> I'll start looking into what we need to do for a license transition
> for edk2-platforms master next week.
>
> Best Regards,
>
> Leif
>
> On Thu, Apr 25, 2019 at 01:28:20PM +0200, Marcin Wojtas wrote:
> > Hi,
> >
> > The third version of the patchset cleans up the dependencies between
> > the SPI drivers, so that now they explicitly rely on the protocols'
> > instead of BEFORE statements and modules GUIDs. Also force dependency
> > between FTW and MvFvbDxe using library NULL resolution.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/fvb-upstream-r20190425
> >
> > I'm looking forward to your comments or remarks.
> >
> > Best regards,
> > Marcin
> >
> > Changelog:
> > v2->v3
> >
> > 3/4 (new patch)
> >  * Clean-up MvSpiFlashDxe / MvSpiOrionDxe / MvFvbDxe dependencies and
> >    rely on the protocols' GUIDs
> >
> > 4/4
> >  * Force dependency for loading FTW driver
> >
> > v1->v2
> >  * Replace clock-enabling patch with PEI phase FV cleanup
> >
> > Hanna Hawa (1):
> >   Marvell/Drivers: MvFvbDxe: Change Pcd parameters to be 64 bit
> >
> > Kornel Duleba (1):
> >   Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode
> >
> > Marcin Wojtas (2):
> >   Marvell/Armada7k8k: Cleanup PEI phase FV
> >   Marvell/Drivers/Spi: Improve modules dependencies
> >
> >  Silicon/Marvell/Marvell.dec                                 |   7 +-
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  18 ++-
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |   3 -
> >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf           |  14 +-
> >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |   5 +-
> >  Silicon/Marvell/Drivers/Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf |   5 +-
> >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.h             |   1 +
> >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c             | 149 +++++++++++++++-----
> >  8 files changed, 140 insertions(+), 62 deletions(-)
> >
> > --
> > 2.7.4
> >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39552): https://edk2.groups.io/g/devel/message/39552
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Marcin Wojtas 4 years, 12 months ago
Hi Leif, Ard,

czw., 25 kwi 2019 o 14:35 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> Hi Leif,
>
> czw., 25 kwi 2019 o 14:01 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> >
> > Hi Marcin,
> >
> > Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet
> > been relicensed, so we still need "contributed-under" here.
> >
> > For this series, can you confirm to the list that this is indeed
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > ? If so, we can fix that up before committing.
> >
>
> Yes, I confirm that - if possible fix-up. Actually I removed those
> lines right before sending :)
>

Do you have any more comments on the patchset?

Thanks,
Marcin

> Best regards,
> Marcin
>
> > I'll start looking into what we need to do for a license transition
> > for edk2-platforms master next week.
> >
> > Best Regards,
> >
> > Leif
> >
> > On Thu, Apr 25, 2019 at 01:28:20PM +0200, Marcin Wojtas wrote:
> > > Hi,
> > >
> > > The third version of the patchset cleans up the dependencies between
> > > the SPI drivers, so that now they explicitly rely on the protocols'
> > > instead of BEFORE statements and modules GUIDs. Also force dependency
> > > between FTW and MvFvbDxe using library NULL resolution.
> > >
> > > The patches are available in the github:
> > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/fvb-upstream-r20190425
> > >
> > > I'm looking forward to your comments or remarks.
> > >
> > > Best regards,
> > > Marcin
> > >
> > > Changelog:
> > > v2->v3
> > >
> > > 3/4 (new patch)
> > >  * Clean-up MvSpiFlashDxe / MvSpiOrionDxe / MvFvbDxe dependencies and
> > >    rely on the protocols' GUIDs
> > >
> > > 4/4
> > >  * Force dependency for loading FTW driver
> > >
> > > v1->v2
> > >  * Replace clock-enabling patch with PEI phase FV cleanup
> > >
> > > Hanna Hawa (1):
> > >   Marvell/Drivers: MvFvbDxe: Change Pcd parameters to be 64 bit
> > >
> > > Kornel Duleba (1):
> > >   Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode
> > >
> > > Marcin Wojtas (2):
> > >   Marvell/Armada7k8k: Cleanup PEI phase FV
> > >   Marvell/Drivers/Spi: Improve modules dependencies
> > >
> > >  Silicon/Marvell/Marvell.dec                                 |   7 +-
> > >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc               |  18 ++-
> > >  Silicon/Marvell/Armada7k8k/Armada7k8k.fdf                   |   3 -
> > >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.inf           |  14 +-
> > >  Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.inf |   5 +-
> > >  Silicon/Marvell/Drivers/Spi/MvSpiOrionDxe/MvSpiOrionDxe.inf |   5 +-
> > >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.h             |   1 +
> > >  Silicon/Marvell/Drivers/Spi/MvFvbDxe/MvFvbDxe.c             | 149 +++++++++++++++-----
> > >  8 files changed, 140 insertions(+), 62 deletions(-)
> > >
> > > --
> > > 2.7.4
> > >

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39773): https://edk2.groups.io/g/devel/message/39773
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Ard Biesheuvel 4 years, 12 months ago
On Mon, 29 Apr 2019 at 15:54, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Hi Leif, Ard,
>
> czw., 25 kwi 2019 o 14:35 Marcin Wojtas <mw@semihalf.com> napisał(a):
> >
> > Hi Leif,
> >
> > czw., 25 kwi 2019 o 14:01 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> > >
> > > Hi Marcin,
> > >
> > > Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet
> > > been relicensed, so we still need "contributed-under" here.
> > >
> > > For this series, can you confirm to the list that this is indeed
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > ? If so, we can fix that up before committing.
> > >
> >
> > Yes, I confirm that - if possible fix-up. Actually I removed those
> > lines right before sending :)
> >
>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 304e51ae3579..cee103d37d6b

Thanks! Any updates on the PCI support?

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39913): https://edk2.groups.io/g/devel/message/39913
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements
Posted by Marcin Wojtas 4 years, 12 months ago
Hi Ard,

czw., 2 maj 2019 o 13:07 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> On Mon, 29 Apr 2019 at 15:54, Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > Hi Leif, Ard,
> >
> > czw., 25 kwi 2019 o 14:35 Marcin Wojtas <mw@semihalf.com> napisał(a):
> > >
> > > Hi Leif,
> > >
> > > czw., 25 kwi 2019 o 14:01 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
> > > >
> > > > Hi Marcin,
> > > >
> > > > Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet
> > > > been relicensed, so we still need "contributed-under" here.
> > > >
> > > > For this series, can you confirm to the list that this is indeed
> > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > ? If so, we can fix that up before committing.
> > > >
> > >
> > > Yes, I confirm that - if possible fix-up. Actually I removed those
> > > lines right before sending :)
> > >
> >
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Pushed as 304e51ae3579..cee103d37d6b
>

Thanks!

> Thanks! Any updates on the PCI support?

I need to spend 2-3h to rebase and test on my boards, I plan to submit
tomorrow. Now I will send a patch allowing to burn images on SD/MMC
from shell, as I have nothing to do with it - I think it will be
helpful.

Best regards,
Marcin

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#39914): https://edk2.groups.io/g/devel/message/39914
Mute This Topic: https://groups.io/mt/31341161/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-