Series comparison

-[PATCH 0/3] staging: rtl8723bs: Code cleanup patches
+[PATCH v2 0/3] staging: rtl8723bs: Code cleanup patches
+This patchset refactors the rtl8723bs driver by replacing
+integer literals (1 and 0) with true and false in instances where
+values are already defined with true or false but some defination
+contains (1 or 0)
-This patchset refactors the rtl8723bs driver by replacing
+Changes in v2:
-integer literals (1 and 0) with true and false,
+    - [PATCH 1/3]: Rename the subject line and improve on the subject
       body
     - [PATCH 2/3]: Rename the subject line and improve on the subject
       body
     - [PATCH 3/3]: Rename the subject line and improve in the
       subject body
 improving code readability and consistency with standard kernel practices.
 The transformation was performed using Coccinelle.
 below is the coccinelle script used:
 @initialize:ocaml@
 ...
 - 0
 + false
 )
 Erick Karanja (3):
-  staging: rtl8723bs: Use true/false instead of 1/0
+  staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted
-  staging: rtl8723bs: Use true/false instead of 1/0
+  staging: rtl8723bs: Modify struct sta_info attribute qos_option
-  staging: rtl8723bs: Use true/false instead of 1/0
+  staging: rtl8723bs: Modify struct sta_info attribute qos_option and
     ieee8021x_blocked
  drivers/staging/rtl8723bs/core/rtw_ap.c       | 12 ++++++------
  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  4 ++--
  drivers/staging/rtl8723bs/core/rtw_recv.c     |  2 +-
 files changed, 9 insertions(+), 9 deletions(-)
 --
 .43.0

-[PATCH 3/3] staging: rtl8723bs: Use true/false instead of 1/0
+[PATCH v2 1/3] staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted
-    standardize boolean representation by replacing 1/0
+Standardize boolean representation by ensuring consistency,
-    with true/false in cases where boolean logic is implied.
+replace instances of 1/0 with true/false where boolean logic is implied,
-    This improves code clarity and aligns with the kernel’s bool type usage.
+as some definitions already use true/false.
 This improves code clarity and aligns with the kernel’s bool type usage.
 Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
 ---
  drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
 file changed, 1 insertion(+), 1 deletion(-)
 ...

-[PATCH 2/3] staging: rtl8723bs: Use true/false instead of 1/0
+[PATCH v2 2/3] staging: rtl8723bs: Modify struct sta_info attribute qos_option
-Standardize boolean representation by replacing 1/0
+Standardize boolean representation by ensuring consistency,
-with true/false in cases where boolean logic is implied.
+replacing instances of 1/0 with true/false where boolean logic
 is implied, as some definitions already use true/false.
 This improves code clarity and aligns with the kernel’s bool type usage.
 Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
 ---
  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
 ...

-[PATCH 1/3] staging: rtl8723bs: Use true/false instead of 1/0
+[PATCH v2 3/3] staging: rtl8723bs: Modify struct sta_info attribute qos_option and ieee8021x_blocked
-Standardize boolean representation by replacing 1/0
+Standardize boolean representation by ensuring consistency,
-with true/false in cases where boolean logic is implied.
+replacing instances of 1/0 with true/false where boolean
 logic is implied, as some definitions already use true/false.
 This improves code clarity and aligns with the kernel’s bool type usage.
 Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
 ---
  drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
 ...

This patchset refactors the rtl8723bs driver by replacing
integer literals (1 and 0) with true and false,
improving code readability and consistency with standard kernel practices.
The transformation was performed using Coccinelle.

below is the coccinelle script used:
@initialize:ocaml@
@@

let same_function p q =
  (List.hd p).Coccilib.current_element = (List.hd q).Coccilib.current_element

@r@
expression e;
position p;
symbol true,false;
@@

e =@p \(true\|false\)

@@
expression r.e;
position q : script:ocaml(r.p) { same_function p q };
@@

e =@q
(
- 1
+ true
|
- 0
+ false
)

@s@
type T;
T e;
identifier fld;
symbol true,false;
@@

e.fld = \(true\|false\)

@@
type s.T;
T e;
identifier s.fld;
@@

e.fld =
(
- 1
+ true
|
- 0
+ false
)

Erick Karanja (3):
  staging: rtl8723bs: Use true/false instead of 1/0
  staging: rtl8723bs: Use true/false instead of 1/0
  staging: rtl8723bs: Use true/false instead of 1/0

drivers/staging/rtl8723bs/core/rtw_ap.c       | 12 ++++++------
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c |  4 ++--
 drivers/staging/rtl8723bs/core/rtw_recv.c     |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.43.0

Standardize boolean representation by replacing 1/0
with true/false in cases where boolean logic is implied.
This improves code clarity and aligns with the kernel’s bool type usage.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index XXXXXXX..XXXXXXX 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -XXX,XX +XXX,XX @@ void update_bmc_sta(struct adapter *padapter)
 
 		pmlmeinfo->FW_sta_info[psta->mac_id].psta = psta;
 
-		psta->qos_option = 0;
+		psta->qos_option = false;
 		psta->htpriv.ht_option = false;
 
-		psta->ieee8021x_blocked = 0;
+		psta->ieee8021x_blocked = false;
 
 		memset((void *)&psta->sta_stats, 0, sizeof(struct stainfo_stats));
 
@@ -XXX,XX +XXX,XX @@ void sta_info_update(struct adapter *padapter, struct sta_info *psta)
 
 	/* update wmm cap. */
 	if (WLAN_STA_WME & flags)
-		psta->qos_option = 1;
+		psta->qos_option = true;
 	else
-		psta->qos_option = 0;
+		psta->qos_option = false;
 
 	if (pmlmepriv->qospriv.qos_option == 0)
-		psta->qos_option = 0;
+		psta->qos_option = false;
 
 	/* update 802.11n ht cap. */
 	if (WLAN_STA_HT & flags) {
 		psta->htpriv.ht_option = true;
-		psta->qos_option = 1;
+		psta->qos_option = true;
 	} else {
 		psta->htpriv.ht_option = false;
 	}
-- 
2.43.0

Standardize boolean representation by replacing 1/0
with true/false in cases where boolean logic is implied.
This improves code clarity and aligns with the kernel’s bool type usage.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index XXXXXXX..XXXXXXX 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -XXX,XX +XXX,XX @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 
 	/*  check if there is WMM IE & support WWM-PS */
 	pstat->flags &= ~WLAN_STA_WME;
-	pstat->qos_option = 0;
+	pstat->qos_option = false;
 	pstat->qos_info = 0;
 	pstat->has_legacy_ac = true;
 	pstat->uapsd_vo = 0;
@@ -XXX,XX +XXX,XX @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
 
 					pstat->flags |= WLAN_STA_WME;
 
-					pstat->qos_option = 1;
+					pstat->qos_option = true;
 					pstat->qos_info = *(p+8);
 
 					pstat->max_sp_len = (pstat->qos_info>>5)&0x3;
-- 
2.43.0

This patchset refactors the rtl8723bs driver by replacing
integer literals (1 and 0) with true and false in instances where
values are already defined with true or false but some defination
contains (1 or 0)

Changes in v2:
	- [PATCH 1/3]: Rename the subject line and improve on the subject
	  body
	- [PATCH 2/3]: Rename the subject line and improve on the subject
	  body
	- [PATCH 3/3]: Rename the subject line and improve in the
	  subject body
improving code readability and consistency with standard kernel practices.
The transformation was performed using Coccinelle.

below is the coccinelle script used:
@initialize:ocaml@
@@

let same_function p q =
  (List.hd p).Coccilib.current_element = (List.hd q).Coccilib.current_element

@r@
expression e;
position p;
symbol true,false;
@@

e =@p \(true\|false\)

@@
expression r.e;
position q : script:ocaml(r.p) { same_function p q };
@@

e =@q
(
- 1
+ true
|
- 0
+ false
)

@s@
type T;
T e;
identifier fld;
symbol true,false;
@@

e.fld = \(true\|false\)

@@
type s.T;
T e;
identifier s.fld;
@@

e.fld =
(
- 1
+ true
|
- 0
+ false
)

Erick Karanja (3):
  staging: rtl8723bs: Modify struct rx_pkt_attrib attribute bdecrypted
  staging: rtl8723bs: Modify struct sta_info attribute qos_option
  staging: rtl8723bs: Modify struct sta_info attribute qos_option and
    ieee8021x_blocked

-- 
2.43.0

Standardize boolean representation by ensuring consistency,
replacing instances of 1/0 with true/false where boolean logic
is implied, as some definitions already use true/false.
This improves code clarity and aligns with the kernel’s bool type usage.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Standardize boolean representation by ensuring consistency,
replacing instances of 1/0 with true/false where boolean
logic is implied, as some definitions already use true/false.
This improves code clarity and aligns with the kernel’s bool type usage.

Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)