| 1 | The struct field uses the uint values 0 and 1 to represent false and | 1 | The struct sta_info field ieee8021x_blocked uses the uint values |
|---|---|---|---|
| 2 | true values respectively. | 2 | 0 and 1 to represent false and true values respectively. |
| 3 | 3 | ||
| 4 | Convert cases to use the bool type instead to ensure consistency | 4 | Convert cases to use the bool type instead to ensure consistency |
| 5 | with other parts of the containing code where true or false has | 5 | with other parts of the containing code where true or false have |
| 6 | been used. | 6 | been used. |
| 7 | 7 | ||
| 8 | reported by Coccinelle: | 8 | This change causes the struct field to change size from a 32bit to |
| 9 | an 8bit. However, the change is safe to make because the sta_info | ||
| 10 | struct is not read from the hardware. | ||
| 11 | |||
| 12 | Reported by Coccinelle. | ||
| 9 | 13 | ||
| 10 | Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> | 14 | Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> |
| 11 | --- | 15 | --- |
| 16 | Changes in v5: | ||
| 17 | - Added "PATCH" omitted in v4 to Subject title as observed by Greg. | ||
| 18 | Changes in v4: | ||
| 19 | - Added information about chnaging size of struct field in commit. | ||
| 20 | message and why it is safe to do so as suggested by Julia Lawall. | ||
| 12 | Changes in v3: | 21 | Changes in v3: |
| 13 | - Added more patch recipients | 22 | - Added more patch recipients. |
| 14 | Changes in v2: | 23 | Changes in v2: |
| 15 | - Improved commit message based on suggestion from Julia Lawal | 24 | - Improved commit message based on suggestion from Julia Lawall |
| 16 | - Clarity was provided to Greg Kroah-Hartman by Dan Carpenter on why | 25 | - Clarity was provided to Greg Kroah-Hartman by Dan Carpenter on why |
| 17 | it is safe to make the change to the struct. | 26 | it is safe to make the change to the struct field. |
| 18 | 27 | ||
| 19 | drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- | 28 | drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- |
| 20 | drivers/staging/rtl8723bs/include/sta_info.h | 2 +- | 29 | drivers/staging/rtl8723bs/include/sta_info.h | 2 +- |
| 21 | 2 files changed, 2 insertions(+), 2 deletions(-) | 30 | 2 files changed, 2 insertions(+), 2 deletions(-) |
| 22 | 31 | ||
| ... | ... | diff view generated by jsdifflib |