| 1 | The struct field uses the uint values 0 and 1 to represent false and | 1 | The struct sta_info field ieee8021x_blocked uses the uint values |
|---|---|---|---|
| 2 | true values respectively. | 2 | 0 and 1 to represent false and true values respectively. |
| 3 | 3 | ||
| 4 | Convert cases to use the bool type instead to conform to Linux | 4 | Convert cases to use the bool type instead to ensure consistency |
| 5 | coding styles and ensure consistency. | 5 | with other parts of the containing code where true or false have |
| 6 | been used. | ||
| 7 | |||
| 8 | This change causes the struct field to change size from a 32bit to | ||
| 9 | an 8bit. However, the change is safe to make because the sta_info | ||
| 10 | struct is not read from the hardware. | ||
| 6 | 11 | ||
| 7 | reported by Coccinelle: | 12 | reported by Coccinelle: |
| 8 | 13 | ||
| 9 | Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> | 14 | Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> |
| 10 | --- | 15 | --- |
| 16 | Changes in v4: | ||
| 17 | - Added information about changing size of struct field in commit | ||
| 18 | message and why it is safe to do so as suggested by Julia Lawall | ||
| 19 | Changes in v3: | ||
| 20 | - Added more patch recipients | ||
| 21 | Changes in v2: | ||
| 22 | - Improved commit message based on suggestion from Julia Lawall | ||
| 23 | - Clarity was provided to Greg kroah-Hartman by Dan Carpenter on why | ||
| 24 | it is safe to make the change to the struct field. | ||
| 25 | |||
| 11 | drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- | 26 | drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- |
| 12 | drivers/staging/rtl8723bs/include/sta_info.h | 2 +- | 27 | drivers/staging/rtl8723bs/include/sta_info.h | 2 +- |
| 13 | 2 files changed, 2 insertions(+), 2 deletions(-) | 28 | 2 files changed, 2 insertions(+), 2 deletions(-) |
| 14 | 29 | ||
| 15 | diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c | 30 | diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c |
| ... | ... | diff view generated by jsdifflib |