[PATCH] x86/mem_sharing: fix wrong field name used in 2c5119d

Tamas K Lengyel posted 1 patch 3 days, 21 hours ago
Failed in applying to current master (apply log)
xen/arch/x86/mm/mem_sharing.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] x86/mem_sharing: fix wrong field name used in 2c5119d

Posted by Tamas K Lengyel 3 days, 21 hours ago
The arch_domain struct has "msr", not "msrs".

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
---
I've build tested originally with "msr" but typod "msrs" when creating the
patch that was sent in. Sorry for the noise.
---
 xen/arch/x86/mm/mem_sharing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
index a98a1709c2..c8a6d11b90 100644
--- a/xen/arch/x86/mm/mem_sharing.c
+++ b/xen/arch/x86/mm/mem_sharing.c
@@ -1781,7 +1781,7 @@ static int fork(struct domain *cd, struct domain *d)
         domain_pause(d);
         cd->max_pages = d->max_pages;
         *cd->arch.cpuid = *d->arch.cpuid;
-        *cd->arch.msrs = *d->arch.msrs;
+        *cd->arch.msr = *d->arch.msr;
         cd->parent = d;
     }
 
-- 
2.25.1


Re: [PATCH] x86/mem_sharing: fix wrong field name used in 2c5119d

Posted by Andrew Cooper 3 days, 5 hours ago
On 13/01/2021 02:28, Tamas K Lengyel wrote:
> The arch_domain struct has "msr", not "msrs".
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> ---
> I've build tested originally with "msr" but typod "msrs" when creating the
> patch that was sent in. Sorry for the noise.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

It was actually a Travis Randconfig run which happened to turn
CONFIG_MEM_SHARING on.  I'll add words to that effect, but probably not
a URL as its about to cease to exist.