[PATCH 8/8] x86/shadow: drop zero initialization from shadow_domain_init()

Jan Beulich posted 8 patches 3 years, 1 month ago
There is a newer version of this series
[PATCH 8/8] x86/shadow: drop zero initialization from shadow_domain_init()
Posted by Jan Beulich 3 years, 1 month ago
There's no need for this as struct domain starts out zero-filled.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/shadow/common.c
+++ b/xen/arch/x86/mm/shadow/common.c
@@ -64,12 +64,8 @@ int shadow_domain_init(struct domain *d)
 
     d->arch.paging.update_paging_mode = shadow_update_paging_mode;
 
-#if (SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
-    d->arch.paging.shadow.oos_active = 0;
-#endif
 #ifdef CONFIG_HVM
     d->arch.paging.flush_tlb = shadow_flush_tlb;
-    d->arch.paging.shadow.pagetable_dying_op = 0;
 #endif
 
     return 0;
Re: [PATCH 8/8] x86/shadow: drop zero initialization from shadow_domain_init()
Posted by Andrew Cooper 3 years, 1 month ago
On 21/12/2022 1:28 pm, Jan Beulich wrote:
> There's no need for this as struct domain starts out zero-filled.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>