[PATCH] x86/vPIC: correct vcpi_domain()

Jan Beulich posted 1 patch 5 months, 1 week ago
Failed in applying to current master (apply log)
[PATCH] x86/vPIC: correct vcpi_domain()
Posted by Jan Beulich 5 months, 1 week ago
Make it use its parameter in both places.

Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/vpic.c
+++ b/xen/arch/x86/hvm/vpic.c
@@ -35,7 +35,7 @@
 #include <asm/hvm/save.h>
 
 #define vpic_domain(v) (container_of((v), struct domain, \
-                        arch.hvm.vpic[!vpic->is_master]))
+                                     arch.hvm.vpic[!(v)->is_master]))
 #define __vpic_lock(v) &container_of((v), struct hvm_domain, \
                                         vpic[!(v)->is_master])->irq_lock
 #define vpic_lock(v)   spin_lock(__vpic_lock(v))
Re: [PATCH] x86/vPIC: correct vcpi_domain()
Posted by Roger Pau Monné 5 months, 1 week ago
^ typo in the subject :).

On Thu, Nov 23, 2023 at 11:20:24AM +0100, Jan Beulich wrote:
> Make it use its parameter in both places.
> 
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

Re: [PATCH] x86/vPIC: correct vcpi_domain()
Posted by Andrew Cooper 5 months, 1 week ago
On 23/11/2023 10:20 am, Jan Beulich wrote:
> Make it use its parameter in both places.
>
> Fixes: 00a70f44a68c ("[HVM] Update VPIC device model for new interrupt delivery code")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>