build: correct gas --noexecstack check

[PATCH] build: correct gas --noexecstack check

Posted by Jan Beulich 9 months, 2 weeks ago

The check was missing an escape for the inner $, thus breaking things
in the unlikely event that the underlying assembler doesn't support this
option.

Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -397,7 +397,7 @@ endif
 
 AFLAGS += -D__ASSEMBLY__
 
-$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack)
 
 LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments

Re: [PATCH] build: correct gas --noexecstack check

Posted by Anthony PERARD 8 months, 2 weeks ago

On Wed, Jul 12, 2023 at 04:23:22PM +0200, Jan Beulich wrote:
> The check was missing an escape for the inner $, thus breaking things
> in the unlikely event that the underlying assembler doesn't support this
> option.
> 
> Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD