scripts/add_maintainers.pl: add -o as an alternative to --patchdir

[PATCH] scripts/add_maintainers.pl: add -o as an alternative to --patchdir

Elliott Mitchell posted 1 patch 2 years ago

Download mbox

Test gitlab-ci failed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/dc05a59dc0e186f9dcec8d0e877ee80af168b6a8.1650551981.git.ehem+xen@m5p.com

scripts/add_maintainers.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] scripts/add_maintainers.pl: add -o as an alternative to --patchdir

Posted by Elliott Mitchell 2 years ago

This matches the output directory option used by `git format-patch`.  I
suspect I'm not the only one who finds matching `git format-patch` more
intuitive, than -d for directory.

Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>
---
 scripts/add_maintainers.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/add_maintainers.pl b/scripts/add_maintainers.pl
index 5a6d0f631b..380e8da22a 100755
--- a/scripts/add_maintainers.pl
+++ b/scripts/add_maintainers.pl
@@ -32,7 +32,7 @@ $get_maintainer =~ s/add_maintainers/get_maintainer/;
 my $usage = <<EOT;
 OPTIONS:
 --------
-USAGE: $tool [options] (--patchdir | -d) <patchdir>
+USAGE: $tool [options] (--patchdir | -d | -o) <patchdir>
 
   --reroll-count <n> | -v <n>
     Choose patch files for specific version. This results into the
@@ -223,7 +223,7 @@ my $patch_ext           = ".patch";
 my $maintainers         = "MAINTAINERS";
 
 if (!GetOptions(
-                'd|patchdir=s'     => \$patch_dir,
+                'd|o|patchdir=s'   => \$patch_dir,
                 'v|reroll-count=i' => \$rerollcount,
                 'p|patchcc=s'      => \$plocation,
                 'c|covercc=s'      => \$clocation,
-- 
2.30.2

Re: [PATCH] scripts/add_maintainers.pl: add -o as an alternative to --patchdir

Posted by Juergen Gross 2 years ago

On 21.04.22 16:35, Elliott Mitchell wrote:
> This matches the output directory option used by `git format-patch`.  I
> suspect I'm not the only one who finds matching `git format-patch` more
> intuitive, than -d for directory.

Thank you for doing that!

> Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen