[PATCH] XSM: correct xsm_get_domain_state()

Jan Beulich posted 1 patch 3 days ago
Failed in applying to current master (apply log)
[PATCH] XSM: correct xsm_get_domain_state()
Posted by Jan Beulich 3 days ago
Add the missing first parameter and move it next to a close relative.

Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xsm/xsm.h
+++ b/xen/include/xsm/xsm.h
@@ -231,6 +231,11 @@ static inline int xsm_getdomaininfo(xsm_
     return alternative_call(xsm_ops.getdomaininfo, d);
 }
 
+static inline int xsm_get_domain_state(xsm_default_t def, struct domain *d)
+{
+    return alternative_call(xsm_ops.get_domain_state, d);
+}
+
 static inline int xsm_domctl_scheduler_op(
     xsm_default_t def, struct domain *d, int cmd)
 {
@@ -775,11 +780,6 @@ static inline int xsm_argo_send(const st
 
 #endif /* CONFIG_ARGO */
 
-static inline int xsm_get_domain_state(struct domain *d)
-{
-    return alternative_call(xsm_ops.get_domain_state, d);
-}
-
 #endif /* XSM_NO_WRAPPERS */
 
 #ifdef CONFIG_MULTIBOOT
Re: [PATCH] XSM: correct xsm_get_domain_state()
Posted by Jürgen Groß 2 days, 23 hours ago
On 06.03.25 15:16, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
> 
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Juergen Gross <jgross@suse.com>

With this patch you can ignore my patch just sent out, I guess. :-)


Juergen
Re: [PATCH] XSM: correct xsm_get_domain_state()
Posted by Daniel P. Smith 2 days, 23 hours ago
On 3/6/25 09:16, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
> 
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Re: [PATCH] XSM: correct xsm_get_domain_state()
Posted by Andrew Cooper 3 days ago
On 06/03/2025 2:16 pm, Jan Beulich wrote:
> Add the missing first parameter and move it next to a close relative.
>
> Fixes: 3ad3df1bd0aa ("xen: add new domctl get_domain_state")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>