[XEN PATCH] eclair: allow and document use of GCC extension for label addresses

Nicola Vetrini posted 1 patch 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/d9dbce35d6857f79a21b68e4edd45f0febe3d3c9.1747984747.git.nicola.vetrini@bugseng.com
automation/eclair_analysis/ECLAIR/toolchain.ecl | 5 +++++
docs/misra/C-language-toolchain.rst             | 4 ++++
2 files changed, 9 insertions(+)
[XEN PATCH] eclair: allow and document use of GCC extension for label addresses
Posted by Nicola Vetrini 5 months, 1 week ago
No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
This fixes the CI error for R1.1 on this patch that stems from using the label inside asm goto:
https://lore.kernel.org/xen-devel/20250521143658.312514-1-andrew.cooper3@citrix.com/
---
 automation/eclair_analysis/ECLAIR/toolchain.ecl | 5 +++++
 docs/misra/C-language-toolchain.rst             | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl b/automation/eclair_analysis/ECLAIR/toolchain.ecl
index 8ebf9f132cf2..842f8377e561 100644
--- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
+++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
@@ -108,6 +108,11 @@ volatile"
 -config=STD.funojptr,behavior+={c99,GCC_X86_64,specified}
 -doc_end
 
+-doc_begin="See section \"6.3 Labels as Values\" of "GCC_MANUAL"."
+-config=STD.adrslabl,behavior={c99,GCC_ARM64,specified}
+-config=STD.adrslabl,behavior={c99,GCC_X86_64,specified}
+-doc_end
+
 -doc_begin="
     ext_c_missing_varargs_arg: see Section \"6.21 Macros with a Variable Number of Arguments\" of "GCC_MANUAL".
     ext_enum_value_not_int: non-documented GCC extension.
diff --git a/docs/misra/C-language-toolchain.rst b/docs/misra/C-language-toolchain.rst
index 3a1ce651d7fd..cb81f5c09872 100644
--- a/docs/misra/C-language-toolchain.rst
+++ b/docs/misra/C-language-toolchain.rst
@@ -214,6 +214,10 @@ The table columns are as follows:
      - All architectures
      - See Section "4.5 Integers" of GCC_MANUAL.
 
+   * - Taking the address of a label
+     - All architectures
+     - See Section "6.3 Labels as Values" of GCC_MANUAL.
+
 Translation Limits
 __________________
 
-- 
2.43.0
Re: [XEN PATCH] eclair: allow and document use of GCC extension for label addresses
Posted by Andrew Cooper 5 months, 1 week ago
On 23/05/2025 8:20 am, Nicola Vetrini wrote:
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Ah, very nice and easy.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Is this dependent on the updated Eclair, or can it go in now?

~Andrew
Re: [XEN PATCH] eclair: allow and document use of GCC extension for label addresses
Posted by Nicola Vetrini 5 months, 1 week ago
On 2025-05-23 14:57, Andrew Cooper wrote:
> On 23/05/2025 8:20 am, Nicola Vetrini wrote:
>> No functional change.
>> 
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> 
> Ah, very nice and easy.
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 
> Is this dependent on the updated Eclair, or can it go in now?
> 

Hi Andrew,

it's independent on the updated ECLAIR.

Thanks,
  Nicola

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253