tools/tests/domid: don't pass -E to sed

[PATCH for-4.21] tools/tests/domid: don't pass -E to sed

Posted by Jan Beulich 1 week, 2 days ago

Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
doesn't name -E as a standard option; only Issue 8 [2] does. As we can
easily avoid anything "extended" about the expression used, drop the -E,
escape the parentheses, and replace the sole + by *.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/
[2] https://pubs.opengroup.org/onlinepubs/9799919799/

Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/domid/Makefile
+++ b/tools/tests/domid/Makefile
@@ -10,8 +10,8 @@ include $(XEN_ROOT)/tools/Rules.mk
 TESTS := test-domid
 
 define list-c-headers
-$(shell sed -n -E \
-    's/^[ \t]*# *include[ \t]*[<"]([^">]+)[">].*/\1/p' $(1) 2>/dev/null)
+$(shell sed -n \
+    's/^[ \t]*# *include[ \t]*[<"]\([^">]*\)[">].*/\1/p' $(1) 2>/dev/null)
 endef
 
 # NB: $1 cannot be a list

Re: [PATCH for-4.21] tools/tests/domid: don't pass -E to sed

Posted by Oleksii Kurochko 1 week, 2 days ago

On 10/20/25 3:40 PM, Jan Beulich wrote:
> Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
> doesn't name -E as a standard option; only Issue 8 [2] does. As we can
> easily avoid anything "extended" about the expression used, drop the -E,
> escape the parentheses, and replace the sole + by *.
>
> [1]https://pubs.opengroup.org/onlinepubs/9699919799/
> [2]https://pubs.opengroup.org/onlinepubs/9799919799/
>
> Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
> Signed-off-by: Jan Beulich<jbeulich@suse.com>

Release-Acked-by: Oleksii Kurochko<oleksii.kurochko@gmail.com>

~ Oleksii

>
> --- a/tools/tests/domid/Makefile
> +++ b/tools/tests/domid/Makefile
> @@ -10,8 +10,8 @@ include $(XEN_ROOT)/tools/Rules.mk
>   TESTS := test-domid
>   
>   define list-c-headers
> -$(shell sed -n -E \
> -    's/^[ \t]*# *include[ \t]*[<"]([^">]+)[">].*/\1/p' $(1) 2>/dev/null)
> +$(shell sed -n \
> +    's/^[ \t]*# *include[ \t]*[<"]\([^">]*\)[">].*/\1/p' $(1) 2>/dev/null)
>   endef
>   
>   # NB: $1 cannot be a list

Re: [PATCH for-4.21] tools/tests/domid: don't pass -E to sed

Posted by Andrew Cooper 1 week, 2 days ago

On 20/10/2025 2:40 pm, Jan Beulich wrote:
> Even the 2018 edition of The Open Group Base Specifications Issue 7 [1]
> doesn't name -E as a standard option; only Issue 8 [2] does. As we can
> easily avoid anything "extended" about the expression used, drop the -E,
> escape the parentheses, and replace the sole + by *.
>
> [1] https://pubs.opengroup.org/onlinepubs/9699919799/
> [2] https://pubs.opengroup.org/onlinepubs/9799919799/
>
> Fixes: b3d31533a047 ("tools/tests: introduce unit tests for domain ID allocator")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>