[PATCH v1 04/10] ehci-dbgp: fix selecting n-th ehci controller

Marek Marczykowski-Górecki posted 10 patches 3 years, 8 months ago
There is a newer version of this series
[PATCH v1 04/10] ehci-dbgp: fix selecting n-th ehci controller
Posted by Marek Marczykowski-Górecki 3 years, 8 months ago
The ehci<n> number was parsed but ignored.

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
---
 xen/drivers/char/ehci-dbgp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index 16c8ff394d5c..92c588ec0aa3 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -1480,7 +1480,7 @@ void __init ehci_dbgp_init(void)
         unsigned int num = 0;
 
         if ( opt_dbgp[4] )
-            simple_strtoul(opt_dbgp + 4, &e, 10);
+            num = simple_strtoul(opt_dbgp + 4, &e, 10);
 
         dbgp->cap = find_dbgp(dbgp, num);
         if ( !dbgp->cap )
-- 
git-series 0.9.1

Re: [PATCH v1 04/10] ehci-dbgp: fix selecting n-th ehci controller
Posted by Jan Beulich 3 years, 7 months ago
On 07.06.2022 16:30, Marek Marczykowski-Górecki wrote:
> The ehci<n> number was parsed but ignored.

Oops.

> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>

This could do with a Fixes: tag. Then
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan