[PATCH v5 0/2] efi: Support Shim LoadImage

Gerald Elder-Vass posted 2 patches 6 hours ago
Failed in applying to current master (apply log)
xen/common/efi/boot.c    | 87 ++++++++++++++++++++++++++++++++++++----
xen/common/efi/runtime.c |  1 +
xen/include/xen/efi.h    |  2 +
3 files changed, 82 insertions(+), 8 deletions(-)
[PATCH v5 0/2] efi: Support Shim LoadImage
Posted by Gerald Elder-Vass 6 hours ago
Support Shim LoadImage protocol but keep Shim Lock for compatibility

https://gitlab.com/xen-project/people/geraldev/xen/-/pipelines/2029800410
- Saw known unrelated debian-12-x86_64 issue

Gerald Elder-Vass (1):
  efi: Support using Shim's LoadImage protocol

Ross Lagerwall (1):
  efi: Add a function to check if Secure Boot mode is enabled

 xen/common/efi/boot.c    | 87 ++++++++++++++++++++++++++++++++++++----
 xen/common/efi/runtime.c |  1 +
 xen/include/xen/efi.h    |  2 +
 3 files changed, 82 insertions(+), 8 deletions(-)

-- 
2.47.3
Re: [PATCH v5 0/2] efi: Support Shim LoadImage
Posted by Jan Beulich 6 hours ago
On 09.09.2025 16:52, Gerald Elder-Vass wrote:
> Support Shim LoadImage protocol but keep Shim Lock for compatibility
> 
> https://gitlab.com/xen-project/people/geraldev/xen/-/pipelines/2029800410
> - Saw known unrelated debian-12-x86_64 issue
> 
> Gerald Elder-Vass (1):
>   efi: Support using Shim's LoadImage protocol
> 
> Ross Lagerwall (1):
>   efi: Add a function to check if Secure Boot mode is enabled

You realize that both patches have gone in already, so adjustments need to
be incremental patches now?

Jan
Re: [PATCH v5 0/2] efi: Support Shim LoadImage
Posted by Gerald Elder-Vass 6 hours ago
Apologies I did not realise, as there were outstanding comments I assumed
more changes were required

*Gerald Elder-Vass*
Senior Software Engineer

XenServer
Cambridge, UK

On Tue, Sep 9, 2025 at 4:09 PM Jan Beulich <jbeulich@suse.com> wrote:

> On 09.09.2025 16:52, Gerald Elder-Vass wrote:
> > Support Shim LoadImage protocol but keep Shim Lock for compatibility
> >
> >
> https://gitlab.com/xen-project/people/geraldev/xen/-/pipelines/2029800410
> > - Saw known unrelated debian-12-x86_64 issue
> >
> > Gerald Elder-Vass (1):
> >   efi: Support using Shim's LoadImage protocol
> >
> > Ross Lagerwall (1):
> >   efi: Add a function to check if Secure Boot mode is enabled
>
> You realize that both patches have gone in already, so adjustments need to
> be incremental patches now?
>
> Jan
>
Re: [PATCH v5 0/2] efi: Support Shim LoadImage
Posted by Jan Beulich 6 hours ago
On 09.09.2025 17:12, Gerald Elder-Vass wrote:
> Apologies I did not realise, as there were outstanding comments I assumed
> more changes were required

More changes may be required, just that now they will need doing incrementally.
Imo the committing was done a little too quickly.

Jan