[PATCH v3 1/3] tools: add sizeof_field and offsetofend macros

Petr Beneš posted 3 patches 3 months ago
There is a newer version of this series
[PATCH v3 1/3] tools: add sizeof_field and offsetofend macros
Posted by Petr Beneš 3 months ago
From: Petr Beneš <w1benny@gmail.com>

'offsetofend' macro appears in Linux codebase, so the name was chosen to be
consistent with it.

Signed-off-by: Petr Beneš <w1benny@gmail.com>
---
 tools/include/xen-tools/common-macros.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tools/include/xen-tools/common-macros.h b/tools/include/xen-tools/common-macros.h
index 0088208c2e..c98a6beffd 100644
--- a/tools/include/xen-tools/common-macros.h
+++ b/tools/include/xen-tools/common-macros.h
@@ -83,6 +83,11 @@
 #define __packed __attribute__((__packed__))
 #endif
 
+#define sizeof_field(type, member) sizeof(((type *)NULL)->member)
+
+#define offsetofend(type, member) \
+    (offsetof(type, member) + sizeof_field(type, member))
+
 #define container_of(ptr, type, member) ({              \
     typeof(((type *)0)->member) *mptr__ = (ptr);        \
     (type *)((char *)mptr__ - offsetof(type, member));  \
-- 
2.34.1


Re: [PATCH v3 1/3] tools: add sizeof_field and offsetofend macros
Posted by Jan Beulich 3 months ago
On 29.07.2025 23:25, Petr Beneš wrote:
> --- a/tools/include/xen-tools/common-macros.h
> +++ b/tools/include/xen-tools/common-macros.h
> @@ -83,6 +83,11 @@
>  #define __packed __attribute__((__packed__))
>  #endif
>  
> +#define sizeof_field(type, member) sizeof(((type *)NULL)->member)
> +
> +#define offsetofend(type, member) \
> +    (offsetof(type, member) + sizeof_field(type, member))

I'm not a maintainer of this code, but offsetof_end() or even offset_of_end()
would look like a better name to me.

Jan