[v2] Unflattening and relocation of host device tree

[PATCH v2 1/7] xen/riscv: update layout table in config.h

Posted by Oleksii Kurochko 1 month, 3 weeks ago

Make all upper bounds (end addresses) for areas inclusive to align
with the corresponding definitions.

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in v2:
 - new patch
---
 xen/arch/riscv/include/asm/config.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/riscv/include/asm/config.h b/xen/arch/riscv/include/asm/config.h
index 4954677aff..826e5c7172 100644
--- a/xen/arch/riscv/include/asm/config.h
+++ b/xen/arch/riscv/include/asm/config.h
@@ -41,17 +41,17 @@
  * Start addr          | End addr         | Slot       | area description
  * ============================================================================
  *                   .....                 L2 511          Unused
- *  0xffffffffc0a00000  0xffffffffc0c00000 L2 511          Fixmap
+ *  0xffffffffc0a00000  0xffffffffc0bfffff L2 511          Fixmap
  *                   ..... ( 2 MB gap )
- *  0xffffffffc0400000  0xffffffffc0800000 L2 511          FDT
+ *  0xffffffffc0400000  0xffffffffc07fffff L2 511          FDT
  *                   ..... ( 2 MB gap )
- *  0xffffffffc0000000  0xffffffffc0200000 L2 511          Xen
+ *  0xffffffffc0000000  0xffffffffc01fffff L2 511          Xen
  *                   .....                 L2 510          Unused
- *  0x3200000000        0x7f40000000       L2 200-509      Direct map
+ *  0x3200000000        0x7f7fffffff       L2 200-509      Direct map
  *                   .....                 L2 199          Unused
- *  0x30c0000000        0x31c0000000       L2 195-198      Frametable
+ *  0x30c0000000        0x31bfffffff       L2 195-198      Frametable
  *                   .....                 L2 194          Unused
- *  0x3040000000        0x3080000000       L2 193          VMAP
+ *  0x3040000000        0x307fffffff       L2 193          VMAP
  *                   .....                 L2 0-192        Unused
 #elif RV_STAGE1_MODE == SATP_MODE_SV48
  * Memory layout is the same as for SV39 in terms of slots, so only start and
-- 
2.47.1

Re: [PATCH v2 1/7] xen/riscv: update layout table in config.h

Posted by Jan Beulich 1 month, 3 weeks ago

On 11.12.2024 18:27, Oleksii Kurochko wrote:
> Make all upper bounds (end addresses) for areas inclusive to align
> with the corresponding definitions.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

I expected this would be straightforward to ack, but ...

> --- a/xen/arch/riscv/include/asm/config.h
> +++ b/xen/arch/riscv/include/asm/config.h
> @@ -41,17 +41,17 @@
>   * Start addr          | End addr         | Slot       | area description
>   * ============================================================================
>   *                   .....                 L2 511          Unused
> - *  0xffffffffc0a00000  0xffffffffc0c00000 L2 511          Fixmap
> + *  0xffffffffc0a00000  0xffffffffc0bfffff L2 511          Fixmap
>   *                   ..... ( 2 MB gap )
> - *  0xffffffffc0400000  0xffffffffc0800000 L2 511          FDT
> + *  0xffffffffc0400000  0xffffffffc07fffff L2 511          FDT
>   *                   ..... ( 2 MB gap )
> - *  0xffffffffc0000000  0xffffffffc0200000 L2 511          Xen
> + *  0xffffffffc0000000  0xffffffffc01fffff L2 511          Xen
>   *                   .....                 L2 510          Unused
> - *  0x3200000000        0x7f40000000       L2 200-509      Direct map
> + *  0x3200000000        0x7f7fffffff       L2 200-509      Direct map

... this isn't just an adjustment by -1. If the old table entry was wrong,
the description wants to say so. Else an adjustment to the number is needed
here.

Jan